Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation error: ambiguity w/ make_unique #530

Closed
egordon opened this issue Jul 1, 2019 · 2 comments
Closed

Compilation error: ambiguity w/ make_unique #530

egordon opened this issue Jul 1, 2019 · 2 comments
Assignees
@egordon
Labels
bug

Comments

@egordon
Copy link
Contributor

egordon commented Jul 1, 2019

This issue has been fixed before in most files by #481 , but a recent update in GCC has brought it back to the fore.

Compilation errors with ambiguity in make_unique has been reproduced by myself, @jt10y , and Haoran.

I'll make a quick branch to fix it.
@egordon egordon added the bug label Jul 1, 2019
@egordon egordon self-assigned this Jul 1, 2019
@jslee02
Copy link
Member

jslee02 commented Jul 1, 2019

I hope #527 is first merged so that this kind of erros can be captured by the CI tests.

@egordon egordon mentioned this issue Jul 1, 2019
Closed
1 task
@jslee02
Copy link
Member

jslee02 commented Jul 20, 2019

Addressed by #527

@jslee02 jslee02 closed this as completed Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egordon egordon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egordon @jslee02