Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly call dart::common::make_unique to get over std ambiguity. #531

Closed
wants to merge 1 commit into from
Closed

Explicitly call dart::common::make_unique to get over std ambiguity. #531

wants to merge 1 commit into from

Conversation

egordon
Copy link
Contributor

@egordon egordon commented Jul 1, 2019

Fix issue #530 .

Compilation tested on my box (Ubuntu 18.04, GCC 7.0.4). No other tests needed, since no semantics have changed.

Before creating a pull request

  • [ N/A ] Document new methods and classes
  • [ N/A ] Format code with make format

Before merging a pull request

  • [ N/A ] Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • [ N/A ] Add unit test(s) for this change

@egordon egordon added this to the Aikido 0.4.0 milestone Jul 1, 2019
@egordon egordon requested review from jslee02 and gilwoolee July 1, 2019 22:54
@brianhou
Copy link
Contributor

I think this was addressed by #532.

@brianhou brianhou closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslee02 jslee02 jslee02 approved these changes

@gilwoolee gilwoolee Awaiting requested review from gilwoolee

@aditya-vk aditya-vk Awaiting requested review from aditya-vk

@brianhou brianhou Awaiting requested review from brianhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aikido 0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@egordon @brianhou @jslee02