Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple CI issues #527

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Fix multiple CI issues #527

merged 1 commit into from
Jul 1, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 26, 2019 •
edited
Loading

Currently, all the CI tests are failing due to several issues, which may need to be addressed one by one. It seems mostly they're related to building with ROS packages.

This PR is just to add CMake build option (without using Catkin) so that we can test ROS agnostic AIKIDO components at least. All the catkin builds are disabled (put them to the allowed_failure section). Only building with CMake and building on macOS are working fine.

This PR is based on and targetting to #524. Feel free to modify this PR directly.

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 requested review from egordon and brianhou May 26, 2019 16:55
@jslee02 jslee02 mentioned this pull request May 26, 2019
Merged
5 tasks
@jslee02 jslee02 mentioned this pull request Jul 1, 2019
Closed
egordon
egordon approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@egordon egordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all LGTM at first glance, though I haven't pulled and tested everything on my end. Doesn't seem like an issue when merging off-master.

@egordon egordon merged commit 7301020 into egordon-dart-6.8.2 Jul 1, 2019
@egordon egordon deleted the dart-6.8.4_js branch July 1, 2019 23:04
@egordon egordon restored the dart-6.8.4_js branch July 1, 2019 23:06
@egordon
Copy link
Contributor

egordon commented Jul 1, 2019

@jslee02 We can do this testing inside of egordon-dart-6.8.2, since I don't plan on making any other changes to that branch.

brianhou pushed a commit that referenced this pull request Jul 19, 2019
@egordon @brianhou
Fix Travis CI builds (#524)
de5ee11 
* Update CMakeLists.txt

Update DART version to match PPA (unblocks other repos like `libada` that are dealing with an interface change).

* Updated Travis to Xenial to get newer version of DART

* Removed 6.6.2 deprecation

* Keep current behavior

* Updated CHANGELOG

* Revert to original behavior (per @jslee02)

* Update src/constraint/dart/InverseKinematicsSampleable.cpp

Co-Authored-By: egordon <ekgordon@cs.uw.edu>

* Fix multiple CI issues (#527)

* Remove use of deprecated dart::common::make_unique (#532)

* Merge duplicated if-blocks

* Install more DART dependencies

* Change to `make test` rather than `ctest`
@jslee02 jslee02 deleted the dart-6.8.4_js branch July 20, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egordon egordon egordon approved these changes

@brianhou brianhou Awaiting requested review from brianhou

@aditya-vk aditya-vk Awaiting requested review from aditya-vk

@gilwoolee gilwoolee Awaiting requested review from gilwoolee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @egordon