Remove use of deprecated dart::common::make_unique #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
requested review from
aditya-vk,
brianhou,
gilwoolee and
sniyaz
as code owners
|
It seems two build tests are failing:
I'd move the failing builds to the allowed failures list for now and fix them later. |
1 task
brianhou
approved these changes
Jul 17, 2019
| @@ -8,4 +8,4 @@ mkdir build | |||
| cd build | |||
| cmake -DCMAKE_BUILD_TYPE=${BUILD_TYPE} -DTREAT_WARNINGS_AS_ERRORS=ON .. | |||
| make -j4 tests | |||
| make test | |||
| ctest | |||
There was a problem hiding this comment.
Just to see if it makes any difference that turned out not. Feel free to revert it.
|
Yes, exactly! |
brianhou
pushed a commit
that referenced
this pull request
Jul 19, 2019
* Update CMakeLists.txt Update DART version to match PPA (unblocks other repos like `libada` that are dealing with an interface change). * Updated Travis to Xenial to get newer version of DART * Removed 6.6.2 deprecation * Keep current behavior * Updated CHANGELOG * Revert to original behavior (per @jslee02) * Update src/constraint/dart/InverseKinematicsSampleable.cpp Co-Authored-By: egordon <ekgordon@cs.uw.edu> * Fix multiple CI issues (#527) * Remove use of deprecated dart::common::make_unique (#532) * Merge duplicated if-blocks * Install more DART dependencies * Change to `make test` rather than `ctest`
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md