Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ForeignDataWrapperRelationId OID definitions #1432

Conversation

@burmecia
Copy link
Contributor Author

The test failure looks like not related to this PR.

@eeeebbbbrrrr
Copy link
Contributor

eeeebbbbrrrr commented Dec 11, 2023

This PR is wrong. :)

The files you modified are actually machine generated, based on processing of the pgrx-pg-sys/include/. The files in git are not actually used by pgrx.

What you need to do is add the proper set of Postgres headers into those files and PR that.

I know it's unusual to have machine-generated code committed into a repo, but these files need to exist only to appease docs.rs.

The test failure looks like not related to this PR.

It's not. We'll handle that separately.

@burmecia
Copy link
Contributor Author

Thanks for that info, I updated the PR and it looks good now.

@eeeebbbbrrrr
Copy link
Contributor

Great! Thanks!

I'll merge this now. It might be January before we publish another release. It kinda depends on our vacation schedules this month and what other changes we see come in over the next week or two.

@eeeebbbbrrrr eeeebbbbrrrr merged commit be7807a into pgcentralfoundation:develop Dec 12, 2023
8 checks passed
@burmecia burmecia deleted the feat/foreign-data-wrapper-oid branch December 12, 2023 22:10
workingjubilee added a commit that referenced this pull request Jan 25, 2024
The pgrx 0.11.3 release addresses a few UB risks in pgrx, updates its
dependencies on many points, and includes many additional headers. It
should also now be easier to use cargo-pgrx on more-complicated network
configurations.

## New Bindings!

New bindings added thanks to
- @burmecia in #1432
- @daamien in
  - #1431
  - #1485
- @rebasedming in #1486
- @usamoi in #1436
- @workingjubilee in
#1453

## "...wait, that's UB?"

Two UB fixes!
- Thanks to @Lokathor in
#1443
- Thanks to @usamoi in
#1466

## Ergonomics

- A better `ereport!` macro in
#1472

## Less transport-level security problems in cargo-pgrx

- We no longer secretly require rustls! Thanks to @jirutka in
#1448
- We now use native certs if possible, even with rustls, since
#1449

Together these should mean it's possible to actually use cargo-pgrx on
whatever your network configuration is, but you might have to use `cargo
install --no-default-features --features native-tls` to install with
native-tls (which, on Linux, means OpenSSL). By default, you will use
rustls.

## Many dependency updates

These address some largely-hypothetical security risks, but one is
particularly important: the bindgen update means we now should be
compatible with some aarch64 builds that might have failed.

- #1492
- #1493
- #1494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants