Allow detail argument and trailing commas in ereport!
#1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use `ereport!` because I like to include a `detail` entry but it comes with some inconveniences. When I would write the following snippet in my `Err` match arms, compiler would complain about mismatch types being output from the match arms thus requiring the inclusion of `unreachable!` in my code.
```rust
pgrx::ereport!(
PgLogLevel::ERROR,
PgSqlErrorCode::ERRCODE_INTERNAL_ERROR,
format!("{} failed", stringify!(snowflake_pool_stats)),
err.to_string()
);
// necessary to satisfy the compiler
unreachable!()
```
After looking at the macro src for `ereport!` I realized why I started writing `PgLogLevel::ERROR` rather than simply `ERROR`; the `ERROR` case didn't support a `detail` argument.
Going forward, I would like to use the dedicated macros for the common use cases of logging/aborting so hopefully someone will find these proposed changes to be a worthwhile improvement.
|
This seems reasonable, yep! |
workingjubilee
pushed a commit
that referenced
this pull request
Jan 24, 2024
I use `ereport!` because I like to include a `detail` entry but it comes
with some inconveniences. When I would write the following snippet in my
`Err` match arms, the compiler would complain about mismatch type output
from the match arms thus requiring the inclusion of `unreachable!`
```rust
pgrx::ereport!(
PgLogLevel::ERROR,
PgSqlErrorCode::ERRCODE_INTERNAL_ERROR,
format!("{} failed", stringify!(snowflake_pool_stats)),
err.to_string()
);
// necessary to satisfy the compiler
unreachable!()
```
After looking at the macro src for `ereport!` I realized why I started
writing `PgLogLevel::ERROR` rather than simply `ERROR`:
the `ERROR` case didn't support a `detail` argument so let's add that.
Merged
workingjubilee
added a commit
that referenced
this pull request
Jan 25, 2024
The pgrx 0.11.3 release addresses a few UB risks in pgrx, updates its dependencies on many points, and includes many additional headers. It should also now be easier to use cargo-pgrx on more-complicated network configurations. ## New Bindings! New bindings added thanks to - @burmecia in #1432 - @daamien in - #1431 - #1485 - @rebasedming in #1486 - @usamoi in #1436 - @workingjubilee in #1453 ## "...wait, that's UB?" Two UB fixes! - Thanks to @Lokathor in #1443 - Thanks to @usamoi in #1466 ## Ergonomics - A better `ereport!` macro in #1472 ## Less transport-level security problems in cargo-pgrx - We no longer secretly require rustls! Thanks to @jirutka in #1448 - We now use native certs if possible, even with rustls, since #1449 Together these should mean it's possible to actually use cargo-pgrx on whatever your network configuration is, but you might have to use `cargo install --no-default-features --features native-tls` to install with native-tls (which, on Linux, means OpenSSL). By default, you will use rustls. ## Many dependency updates These address some largely-hypothetical security risks, but one is particularly important: the bindgen update means we now should be compatible with some aarch64 builds that might have failed. - #1492 - #1493 - #1494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
ereport!because I like to include adetailentry but it comes with some inconveniences. When I would write the following snippet in myErrmatch arms, compiler would complain about mismatch types being output from the match arms thus requiring the inclusion ofunreachable!in my code.After looking at the macro src for
ereport!I realized why I started writingPgLogLevel::ERRORrather than simplyERROR; theERRORcase didn't support adetailargument.Going forward, I would like to use the dedicated macros for the common use cases of logging/aborting so hopefully someone will find these proposed changes to be a worthwhile improvement.