-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bindings for libpq #1436
add bindings for libpq #1436
Conversation
Hi, @usamoi, would you mind rebasing this PR with Looking at these headers, looks like they're mostly a combination of What symbols from these headers are you trying to get access to? |
Hi, @eeeebbbbrrrr. I need symbols including |
I see. Because they're So I'll just note here that we may need to port those to run at some point (and would happily accept a PR!). Once you rebase and we can confirm CI passes, I'll merge this. I was thinking of doing another release on Monday or Tuesday. |
I was worried about something like this. I think this header is related to Kerberos. It's being pulled in through the new Do you need |
e02fb7d
to
828183e
Compare
I think I don't need |
Yeah. I was getting concerned about potentially adding another development requirement on Kerberos. Assuming the latest ci job passes, I’ll merge and get a new release out early next week. Thanks for your efforts on this Saturday afternoon! |
Discussed was also adding `libpq.h` but that would expand development requirements to Kerberos development headers and that isn't a good situation for existing users.
The pgrx 0.11.3 release addresses a few UB risks in pgrx, updates its dependencies on many points, and includes many additional headers. It should also now be easier to use cargo-pgrx on more-complicated network configurations. ## New Bindings! New bindings added thanks to - @burmecia in #1432 - @daamien in - #1431 - #1485 - @rebasedming in #1486 - @usamoi in #1436 - @workingjubilee in #1453 ## "...wait, that's UB?" Two UB fixes! - Thanks to @Lokathor in #1443 - Thanks to @usamoi in #1466 ## Ergonomics - A better `ereport!` macro in #1472 ## Less transport-level security problems in cargo-pgrx - We no longer secretly require rustls! Thanks to @jirutka in #1448 - We now use native certs if possible, even with rustls, since #1449 Together these should mean it's possible to actually use cargo-pgrx on whatever your network configuration is, but you might have to use `cargo install --no-default-features --features native-tls` to install with native-tls (which, on Linux, means OpenSSL). By default, you will use rustls. ## Many dependency updates These address some largely-hypothetical security risks, but one is particularly important: the bindgen update means we now should be compatible with some aarch64 builds that might have failed. - #1492 - #1493 - #1494
add two header files:
They are useful for a PostgreSQL type to implement
send_function
andreceive_function
.