check-task: do not show successful pre-check items if fail(#712) (#730)

pingcap · Jun 11, 2020 · e1752be · e1752be
1 parent 9b6c012
commit e1752be
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/checker/checker.go b/checker/checker.go
@@ -255,6 +255,15 @@ func (c *Checker) Process(ctx context.Context, pr chan pb.ProcessResult) {
 		errs = append(errs, unit.NewProcessError(pb.ErrorType_CheckFailed, err))
 	} else if !result.Summary.Passed {
 		errs = append(errs, unit.NewProcessError(pb.ErrorType_CheckFailed, errors.New("check was failed, please see detail")))
+
+		// remove success result if not pass
+		results := result.Results[:0]
+		for _, r := range result.Results {
+			if r.State != check.StateSuccess {
+				results = append(results, r)
+			}
+		}
+		result.Results = results
 	}
 
 	c.updateInstruction(result)