Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

check-task: do not show successful pre-check items if fail #712

Merged
merged 3 commits into from
Jun 11, 2020
Merged

check-task: do not show successful pre-check items if fail #712

merged 3 commits into from
Jun 11, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 4, 2020

What problem does this PR solve?

#647 do not show the successful pre-check items if some items failed when starting task

What is changed and how it works?

remove successful result if fail

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    run mysql with binlog disable
    Screenshot (38)

    Screenshot (37)

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes type/feature New feature labels Jun 4, 2020
csuzhangxc
csuzhangxc reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

checker/checker.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Jun 5, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020 •
edited
Loading

Codecov Report

Merging #712 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #712   +/-   ##
===========================================
  Coverage   57.1327%   57.1327%           
===========================================
  Files           205        205           
  Lines         21198      21198           
===========================================
  Hits          12111      12111           
  Misses         7924       7924           
  Partials       1163       1163

@csuzhangxc csuzhangxc added needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 priority/normal Minor change, requires approval from ≥1 primary reviewer labels Jun 5, 2020
@csuzhangxc csuzhangxc added this to the v1.0.6 milestone Jun 5, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 11, 2020
@csuzhangxc csuzhangxc merged commit 9cfe765 into pingcap:master Jun 11, 2020
@sre-bot
Copy link

sre-bot commented Jun 11, 2020

cherry pick to release-1.0 failed

@csuzhangxc
Copy link
Member

@GMHDBJD you need to cherry-pick it manually. 😢

@GMHDBJD GMHDBJD mentioned this pull request Jun 11, 2020
Merged
csuzhangxc pushed a commit that referenced this pull request Jun 11, 2020
@GMHDBJD
check-task: do not show successful pre-check items if fail(#712) (#730)
e1752be
@csuzhangxc csuzhangxc added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
None yet
Milestone
v1.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @sre-bot @csuzhangxc @WangXiangUSTC