Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

check-task: do not show successful pre-check items if fail(#712) #730

Merged
merged 2 commits into from
Jun 11, 2020
Merged

check-task: do not show successful pre-check items if fail(#712) #730

merged 2 commits into from
Jun 11, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 11, 2020

cherry-pick #712 manually.

What problem does this PR solve?

#647

What is changed and how it works?

remove successful result if fail

Tests

  • Unit test
  • Integration test

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Jun 11, 2020
csuzhangxc
csuzhangxc reviewed Jun 11, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #730 into release-1.0 will increase coverage by 0.0253%.
The diff coverage is 45.4545%.

@@                 Coverage Diff                 @@
##           release-1.0       #730        +/-   ##
===================================================
+ Coverage      57.8399%   57.8653%   +0.0253%     
===================================================
  Files              166        166                
  Lines            16990      16986         -4     
===================================================
+ Hits              9827       9829         +2     
+ Misses            6207       6201         -6     
  Partials           956        956

@csuzhangxc csuzhangxc added this to the v1.0.6 milestone Jun 11, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 11, 2020
@csuzhangxc csuzhangxc merged commit e1752be into pingcap:release-1.0 Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@GMHDBJD @csuzhangxc @WangXiangUSTC