Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: fix show grants privilege check (#15524,#15825) #15904

Merged
merged 7 commits into from
Mar 31, 2020

Conversation

imtbkcat
Copy link

What problem does this PR solve?

cherry-pick #15524 and #15825

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the sig/execution SIG execution label Mar 31, 2020
@imtbkcat imtbkcat changed the title privilege: fix show grants privilege check (#15524) privilege: fix show grants privilege check (#15524) and (15825) Mar 31, 2020
@imtbkcat
Copy link
Author

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But it is better to cherry-pick them one by one.

@jackysp
Copy link
Member

jackysp commented Mar 31, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Mar 31, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

/run-all-tests

@sre-bot sre-bot merged commit 9f26cf7 into pingcap:release-3.1 Mar 31, 2020
@XuHuaiyu XuHuaiyu changed the title privilege: fix show grants privilege check (#15524) and (15825) privilege: fix show grants privilege check (#15524,#15825) Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants