privilege: fix show grants privilege check #15524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #15524 +/- ##
===============================================
+ Coverage 80.4029% 80.414% +0.0111%
===============================================
Files 503 503
Lines 134408 134423 +15
===============================================
+ Hits 108068 108095 +27
+ Misses 17838 17836 -2
+ Partials 8502 8492 -10 |
|
LGTM |
tiancaiamao
previously approved these changes
Mar 23, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for 15534 |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@imtbkcat merge failed. |
imtbkcat
added
the
priority/release-blocker
imtbkcat
force-pushed
the
fixShowGrantCheck
branch
from
feedf60
to
ff9f5d6
Compare
|
/run-all-tests |
imtbkcat
force-pushed
the
fixShowGrantCheck
branch
from
ff9f5d6
to
0455ca1
Compare
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/1009 |
|
/run-common-test tidb-test=pr/1009 |
|
/run-integration-common-test tidb-test=pr/1009 |
tiancaiamao
approved these changes
Mar 23, 2020
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #15601 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 23, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15602 |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Mar 24, 2020
jackysp
pushed a commit
that referenced
this pull request
Mar 27, 2020
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Mar 31, 2020
sre-bot
pushed a commit
that referenced
this pull request
Mar 31, 2020
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Apr 8, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 8, 2020
imtbkcat
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 13, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
SHOW GRANTSneedSELECTprivilege onmysqldatabase, but tidb dosen't check.What is changed and how it works?
add privilege check for
show grantsRelated changes
Check List
Tests
Side effects
Release note
fix
SHOW GRANTSprivilege check