privilege: fix user with % hostname can not show grants.
#15825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2020 11:58
imtbkcat
added
type/bugfix
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #15825 +/- ##
===========================================
Coverage 80.5380% 80.5380%
===========================================
Files 504 504
Lines 135238 135238
===========================================
Hits 108918 108918
Misses 17820 17820
Partials 8500 8500 |
jackysp
reviewed
Mar 30, 2020
executor/show_test.go
Outdated
| c.Assert(err, IsNil) | ||
| c.Assert(se2.Auth(&auth.UserIdentity{Username: "show_grants", Hostname: "127.0.0.1", AuthUsername: "show_grants", AuthHostname: "%"}, nil, nil), IsTrue) | ||
| tk2.Se = se2 | ||
| err = tk2.QueryToErr("show grants") |
|
LGTM |
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/merge |
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 15837 |
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/run-unit-test |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 30, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Mar 30, 2020
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 30, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 30, 2020
jackysp
pushed a commit
that referenced
this pull request
Mar 30, 2020
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Mar 31, 2020
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0 release-3.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @imtbkcat PTAL. |
|
/run-cherry-picker |
|
cherry pick to release-3.0 failed |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Apr 8, 2020
sre-bot
pushed a commit
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#15524 didn't fix this case:
Authhostname of u1 is
%, hostname ofu1is127.0.0.1.ShowGrantschecks hostname in executor which cause show grants fail.What is changed and how it works?
if user in
ShowGrantsisnil, copy session variable user to executor.Related changes
Check List
Tests
Side effects
Release note