Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: fix user with % hostname can not show grants(#15825,#15524) #16168

Merged
merged 5 commits into from
Apr 8, 2020

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Apr 8, 2020

What problem does this PR solve?

cherry-pick #15825 #15524 to release-3.0

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 8, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Apr 8, 2020
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 8, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

@imtbkcat merge failed.

@XuHuaiyu XuHuaiyu changed the title privilege: fix user with % hostname can not show grants(#15825)(#15524) privilege: fix user with % hostname can not show grants(#15825,#15524) Apr 8, 2020
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 8, 2020

Do we need to cherry-pick this to release-3.1?

@imtbkcat
Copy link
Author

imtbkcat commented Apr 8, 2020

@XuHuaiyu This pr has been cherry-pick to 3.1

@imtbkcat
Copy link
Author

imtbkcat commented Apr 8, 2020

/run-unit-test

@zz-jason
Copy link
Member

zz-jason commented Apr 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

Your auto merge job has been accepted, waiting for 15700, 16171, 16170, 16169

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit f75d6fe into pingcap:release-3.0 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/privilege sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants