Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: check ddl history, timestamp and privilege for flashback #37265

Merged
merged 34 commits into from
Aug 23, 2022
Merged

executor: check ddl history, timestamp and privilege for flashback #37265

merged 34 commits into from
Aug 23, 2022

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #37262

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

check ddl history, timestamp, tiflash and privilege for flashback

lcwangchao and others added 15 commits August 18, 2022 17:54
@lcwangchao
ddl: forbid exchange partition with temporary table (pingcap#37204)
ad0f3dd 
close pingcap#37201
@mjonss
ddl: Fix for unsigned partitioning expressions (pingcap#36830)
a1d1356 
close pingcap#35827
@lcwangchao
*: only create TemporaryTableAttachedInfoSchema if needed (pingcap#…
44f684e 
…37196)

close pingcap#37195
@ForwardStar
lightning: Fix panic when downstream table schema has changed (pingca…
8511b9b 
…p#36805)

close pingcap#34163
@SeaRise
expression: fix incorrect unit test from pingcap#37036 (pingcap#37115)
7d401c5 
close pingcap#37116
@xiongjiwei
expression: make collation work with json type (pingcap#37211)
d6ebc60 
close pingcap#31640
@cfzjywxk
txn: seperate the prewrite and commit details information to make it …
8c79898 
…clear (pingcap#37158)

ref pingcap#34106
@lcwangchao
ddl: set tiflash placement group index to 120 (pingcap#37179)
d1f75f0 
ref pingcap#37171
@lance6716
dumpling: fix wrong behaviour of StrictCollationCompatible (pingcap#3…
b690f1c 
…7243)

close pingcap#37241
@wjhuang2016
ddl: use the correct schema version when waitSchemaSynced (pingcap#37210
41b9e26 
)

close pingcap#37209
@xhebox
*: more concise bazel log (pingcap#37247)
c61199a
@hawkingrei
bazel: enable announcerc (pingcap#37217)
8b5b724
@lcwangchao
*: only create snapshot interceptor for temporary table when needed (p…
9af0f03 
…ingcap#37225)

close pingcap#37223
@Yisaer
doc: add design doc for stats lru cache (pingcap#36804)
aaf0613 
ref pingcap#34052
@Defined2014
executor: check ddl history, timestamp and privilege for flashback
1b44540
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 22, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a65ad217ddffadb3886ba5a371acf5999ffe0f36

xhebox
xhebox reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

parser/model/ddl.go Outdated Show resolved Hide resolved
executor/ddl.go Outdated Show resolved Hide resolved
ddl/cluster.go Outdated Show resolved Hide resolved
ddl/cluster.go Outdated Show resolved Hide resolved
xhebox
xhebox reviewed Aug 22, 2022
View reviewed changes
ddl/cluster.go Outdated Show resolved Hide resolved
ddl/cluster.go Outdated Show resolved Hide resolved
bb7133
bb7133 reviewed Aug 22, 2022
View reviewed changes
ddl/cluster.go Outdated Show resolved Hide resolved
ddl/cluster.go Outdated Show resolved Hide resolved
ddl/cluster.go Outdated Show resolved Hide resolved
bb7133
bb7133 reviewed Aug 23, 2022
View reviewed changes
parser/model/ddl.go Outdated Show resolved Hide resolved
@Defined2014
Copy link
Contributor Author

The mysql-test failed, I will merge master after review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2022
bb7133
bb7133 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2022
@Defined2014 Defined2014 requested a review from a team as a code owner August 23, 2022 06:21
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2022
@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a65ad21

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@Defined2014
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 9fec6fc into pingcap:feature/flashback-cluster Aug 23, 2022
Defined2014 added a commit to Defined2014/tidb that referenced this pull request Sep 1, 2022
@Defined2014
executor: check ddl history, timestamp and privilege for flashback (p…
d3d6aac 
…ingcap#37265)

close pingcap#37262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.