Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: fix issue, Fail-fast for unrecoverable DML errors #1928

Merged
merged 27 commits into from
Jul 19, 2021
Merged

sink: fix issue, Fail-fast for unrecoverable DML errors #1928

merged 27 commits into from
Jul 19, 2021

Conversation

ben1009
Copy link
Contributor

@ben1009 ben1009 commented Jun 3, 2021 •
edited
Loading

What problem does this PR solve?

  • fix issue, Fail-fast for unrecoverable DML errors Fail-fast for unrecoverable DML errors #1724
  • replace current retry usage with new pkg retry
  • for some test cases, set backoffMaxDelayInMs=60*1000 same as previous/backoff retry pkg

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • replace current retry usage with new pkg

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 3, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2021
@ben1009 ben1009 added the status/ptal Could you please take a look? label Jun 8, 2021
@ben1009 ben1009 changed the title not ready for review: replace retry usage with new retry pkg, partial done sink: fix issue, Fail-fast for unrecoverable DML errors #1724 Jun 8, 2021
@ben1009 ben1009 changed the title sink: fix issue, Fail-fast for unrecoverable DML errors #1724 sink: fix issue, Fail-fast for unrecoverable DML errors Jun 15, 2021
@ben1009
Copy link
Contributor Author

ben1009 commented Jul 13, 2021

/run-integration-tests
/run-kafka-tests

@ben1009
Copy link
Contributor Author

ben1009 commented Jul 13, 2021

/run-leak-tests

@ben1009
Copy link
Contributor Author

ben1009 commented Jul 13, 2021

/run-integration-tests
/run-kafka-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021 •
edited
Loading

Codecov Report

Merging #1928 (bf0f879) into master (0138edc) will increase coverage by 17.1327%.
The diff coverage is 67.4637%.

@@                Coverage Diff                @@
##             master      #1928         +/-   ##
=================================================
+ Coverage   37.8006%   54.9333%   +17.1327%     
=================================================
  Files           110        171         +61     
  Lines         11394      20787       +9393     
=================================================
+ Hits           4307      11419       +7112     
- Misses         6662       8252       +1590     
- Partials        425       1116        +691

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b070ea2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@ben1009
Copy link
Contributor Author

ben1009 commented Jul 19, 2021

/run-integration-tests
/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 283fa58 into master Jul 19, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 19, 2021
@ben1009 @ti-chi-bot
This is an automated cherry-pick of pingcap#1928
81dbfd7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2315.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 19, 2021
@ben1009 @ti-chi-bot
This is an automated cherry-pick of pingcap#1928
cd7cf4c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2316.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 19, 2021
@ben1009 @ti-chi-bot
sink: fix issue, Fail-fast for unrecoverable DML errors (pingcap#1928)
194edbb
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2317.

@ben1009 ben1009 deleted the cdc-retry-replace branch July 19, 2021 06:16
ti-chi-bot added a commit that referenced this pull request Jul 21, 2021
@ti-chi-bot
sink: fix issue, Fail-fast for unrecoverable DML errors (#1928) (#2316)
26adda2
ti-chi-bot added a commit that referenced this pull request Jul 21, 2021
@ti-chi-bot
sink: fix issue, Fail-fast for unrecoverable DML errors (#1928) (#2317)
812a614
ti-chi-bot added a commit that referenced this pull request Aug 12, 2021
@ti-chi-bot
sink: fix issue, Fail-fast for unrecoverable DML errors (#1928) (#2315)
151fa39
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request Sep 30, 2021
@ti-chi-bot @amyangfei
sink: fix issue, Fail-fast for unrecoverable DML errors (pingcap#1928) (
0824a1f 
pingcap#2315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@overvenus overvenus overvenus approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ben1009 @sre-bot @codecov-commenter @ti-chi-bot @amyangfei @overvenus