Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc/sink: Refine sink interface #3613

Merged
merged 5 commits into from
Nov 26, 2021

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Nov 25, 2021

What problem does this PR solve?

To fix the bug of #3503 , we should manage table checkpoint per table in the sink, this is PR is a part of the fix. In this PR, only change the interface method, no real logic is changed.

What is changed and how it works?

add table ID to Sink interface, below functions will be changed,

type Sink interface {
   FlushRowChangedEvents(ctx context.Context, tableID model.TableID, resolvedTs uint64) (uint64, error)
   Barrier(ctx context.Context, tableID model.TableID) error
}

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has interface methods change

Side effects

Related changes

Release note

 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 03a56ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 26, 2021
@sdojjy
Copy link
Member Author

sdojjy commented Nov 26, 2021

/run-all-tests /tidb=pr/30008

@xiongjiwei
Copy link
Contributor

/run-all-tests

@overvenus
Copy link
Member

Find a flaky test #3626 .

@overvenus
Copy link
Member

/run-all-tests

@overvenus
Copy link
Member

/run-unit-test

@codecov-commenter
Copy link

Codecov Report

Merging #3613 (03a56ff) into master (24030f8) will increase coverage by 1.6711%.
The diff coverage is 69.0571%.

@@               Coverage Diff                @@
##             master      #3613        +/-   ##
================================================
+ Coverage   56.5356%   58.2067%   +1.6711%     
================================================
  Files           211        241        +30     
  Lines         22798      24492      +1694     
================================================
+ Hits          12889      14256      +1367     
- Misses         8598       8822       +224     
- Partials       1311       1414       +103     

@ti-chi-bot ti-chi-bot merged commit d7fa431 into pingcap:master Nov 26, 2021
@sdojjy sdojjy deleted the refine-Sink-interface branch November 26, 2021 06:08
okJiang pushed a commit to okJiang/tiflow that referenced this pull request Dec 8, 2021
@sdojjy sdojjy restored the refine-Sink-interface branch December 27, 2021 02:46
sdojjy added a commit to sdojjy/tiflow that referenced this pull request Dec 27, 2021
# Conflicts:
#	cdc/sink/sink.go
#	cdc/sink/table_sink.go
sdojjy added a commit to sdojjy/tiflow that referenced this pull request Dec 27, 2021
# Conflicts:
#	cdc/sink/sink.go
#	cdc/sink/table_sink.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants