-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc/sink: Refine sink interface #3613
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 03a56ff
|
/run-all-tests /tidb=pr/30008 |
/run-all-tests |
Find a flaky test #3626 . |
/run-all-tests |
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #3613 +/- ##
================================================
+ Coverage 56.5356% 58.2067% +1.6711%
================================================
Files 211 241 +30
Lines 22798 24492 +1694
================================================
+ Hits 12889 14256 +1367
- Misses 8598 8822 +224
- Partials 1311 1414 +103 |
# Conflicts: # cdc/sink/sink.go # cdc/sink/table_sink.go
# Conflicts: # cdc/sink/sink.go # cdc/sink/table_sink.go
What problem does this PR solve?
To fix the bug of #3503 , we should manage table checkpoint per table in the sink, this is PR is a part of the fix. In this PR, only change the interface method, no real logic is changed.
What is changed and how it works?
add table ID to Sink interface, below functions will be changed,
Check List
Tests
Code changes
Side effects
Related changes
Release note