Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): cherry pick sink bug fix to release 5.1 (#4119) #4150

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4119

This is an automated cherry-pick of #4083

What problem does this PR solve?

Cherrypick #3613 #3621 #3625 #3638 #3645 #3746

cc #3545

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

Manage sink checkpoint per table to avoid checkpointTs advances unexpected.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Dec 30, 2021
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/needs-linked-issue size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. and removed do-not-merge/cherry-pick-not-approved labels Dec 30, 2021
@ti-chi-bot ti-chi-bot self-assigned this Dec 30, 2021
@sdojjy sdojjy changed the title sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119) sink(ticdc): cherry pick sink bug fix to release 5.1 (#4119) Dec 30, 2021
@sdojjy
Copy link
Member

sdojjy commented Dec 30, 2021

/run-leak-test

@sdojjy
Copy link
Member

sdojjy commented Dec 30, 2021

/run-unit-test

@asddongmen
Copy link
Contributor

/merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@d94cf7c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #4150   +/-   ##
================================================
  Coverage               ?   61.9903%           
================================================
  Files                  ?        160           
  Lines                  ?      16801           
  Branches               ?          0           
================================================
  Hits                   ?      10415           
  Misses                 ?       5476           
  Partials               ?        910           

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ac9588e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2021
@ti-chi-bot ti-chi-bot merged commit 0f69973 into pingcap:release-5.1 Dec 30, 2021
@sdojjy sdojjy added the needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. label Dec 30, 2021
ti-chi-bot added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 30, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created: #4164.

@sdojjy sdojjy added the needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. label Dec 30, 2021
ti-chi-bot added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 30, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created: #4165.

@overvenus overvenus added this to the v5.1.4 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/needs-linked-issue needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants