Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): cherry pick sink bug fix to release 4.0 (#4119) #4165

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4150

This is an automated cherry-pick of #4119

This is an automated cherry-pick of #4083

What problem does this PR solve?

Cherrypick #3613 #3621 #3625 #3638 #3645 #3746

cc #3545

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

Manage sink checkpoint per table to avoid checkpointTs advances unexpected.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/needs-linked-issue size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. and removed do-not-merge/cherry-pick-not-approved labels Dec 30, 2021
@ti-chi-bot ti-chi-bot self-assigned this Dec 30, 2021
@sdojjy sdojjy changed the title sink(ticdc): cherry pick sink bug fix to release 5.1 (#4119) (#4150) sink(ticdc): cherry pick sink bug fix to release 4.0 (#4119) Dec 30, 2021
@sdojjy
Copy link
Member

sdojjy commented Dec 30, 2021

/run-unit-test

@codecov-commenter
Copy link

Codecov Report

Merging #4165 (4bc0df7) into release-4.0 (753073a) will increase coverage by 8.0367%.
The diff coverage is 74.1907%.

@@                 Coverage Diff                 @@
##           release-4.0      #4165        +/-   ##
===================================================
+ Coverage      53.7661%   61.8028%   +8.0367%     
===================================================
  Files              153        161         +8     
  Lines            15958      16729       +771     
===================================================
+ Hits              8580      10339      +1759     
+ Misses            6475       5492       -983     
+ Partials           903        898         -5     

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 4bc0df7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sdojjy
Copy link
Member

sdojjy commented Dec 31, 2021

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 205ecbc into pingcap:release-4.0 Dec 31, 2021
@overvenus overvenus added this to the v5.1.4 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants