Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc/sink: buffer sink manage checkpoint ts per table #3625

Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Nov 26, 2021

What problem does this PR solve?

To fix the bug of #3503 , we should manage table checkpoint per table in the sink, this is PR is a part of the fix. In this PR, buffer manage checkpointTs per table

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #3625 (baf3105) into master (eed6f9b) will increase coverage by 0.2325%.
The diff coverage is 73.7313%.

Flag Coverage Δ
cdc 58.8615% <73.7313%> (+0.4243%) ⬆️
dm 56.4233% <ø> (+0.0481%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3625        +/-   ##
================================================
+ Coverage   57.3452%   57.5777%   +0.2325%     
================================================
  Files           460        461         +1     
  Lines         54927      55247       +320     
================================================
+ Hits          31498      31810       +312     
- Misses        20180      20182         +2     
- Partials       3249       3255         +6     

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 6, 2021
@liuzix
Copy link
Contributor

liuzix commented Dec 6, 2021

/run-integration-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 6, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0b67675

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2021
@sdojjy
Copy link
Member Author

sdojjy commented Dec 6, 2021

/run-integration-tests
/run-kafka-integration-test
/run-dm-integration-test

@sdojjy
Copy link
Member Author

sdojjy commented Dec 6, 2021

/run-dm-compatibility-test

@sdojjy
Copy link
Member Author

sdojjy commented Dec 6, 2021

/run-all-tests

@sdojjy
Copy link
Member Author

sdojjy commented Dec 6, 2021

/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@sdojjy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sdojjy
Copy link
Member Author

sdojjy commented Dec 6, 2021

/run-verify-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants