-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc/redo: redo applier flush resolvedTs per table #3638
cdc/redo: redo applier flush resolvedTs per table #3638
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
================================================
+ Coverage 56.5356% 58.0646% +1.5289%
================================================
Files 211 241 +30
Lines 22798 24502 +1704
================================================
+ Hits 12889 14227 +1338
- Misses 8598 8851 +253
- Partials 1311 1424 +113 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 88d50f7
|
@sdojjy: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
To fix the bug of #3503 , we should manage table checkpoint per table in the sink, this is PR is a part of the fix.
In this PR, redo applier use the new Sink interface to flush the table resolvedTs
Check List
Tests
Code changes
Release note