Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/sink: mysql sink manage checkpoint per table #3645

Merged
merged 80 commits into from
Dec 9, 2021
Merged

cdc/sink: mysql sink manage checkpoint per table #3645

merged 80 commits into from
Dec 9, 2021

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Nov 27, 2021 •
edited
Loading

What problem does this PR solve?

To fix the bug of #3503 , we should manage table checkpoint per table in the sink, this is PR is a part of the fix. In this PR, mysql sink manage checkpointTs per table

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

`None`.

@sdojjy
refine Sink interface
ba2c2fd
@sdojjy
fix ut
26070d9
@sdojjy
fix lint
f388718
@sdojjy
fix lint
51b754a
@sdojjy
sink manager manage checkpointTs per table
112b4e0
@sdojjy
Merge branch 'master' into sink-manager-manage-checkpoint-per-table
bf10cc1
@sdojjy
buffer sink manage checkpointTs per table
ce8598f
@sdojjy
buffer sink manage checkpointTs per table
aaa2a9d
@sdojjy
Merge remote-tracking branch 'origin/sink-manager-manage-checkpoint-p…
6bccf2f 
…er-table' into sink-manager-manage-checkpoint-per-table
@sdojjy
sink manager manage checkpointTs per table
dbd09d3
@sdojjy
Merge branch 'sink-manager-manage-checkpoint-per-table' into buffer_s…
1fd207d 
…ink_manage_checkpointTs_per_table
@sdojjy
buffer sink manage checkpointTs per table
e189647
@sdojjy
sink manager manage checkpointTs per table
fc0d687
@sdojjy
Merge branch 'master' into sink-manager-manage-checkpoint-per-table
4008fce
@sdojjy
Merge branch 'sink-manager-manage-checkpoint-per-table' into buffer_s…
e938ba9 
…ink_manage_checkpointTs_per_table
@sdojjy
mysql sink manage checkpoint per table
edee7b1
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 27, 2021
@sdojjy
Copy link
Member Author

sdojjy commented Dec 9, 2021

/run-all-tests

@sdojjy
Copy link
Member Author

sdojjy commented Dec 9, 2021

/run-kafka-integration-test

@sdojjy
Copy link
Member Author

sdojjy commented Dec 9, 2021

/run-all-tests

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a614acf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2021
@sdojjy
Copy link
Member Author

sdojjy commented Dec 9, 2021

/run-verify-test

@sdojjy
Copy link
Member Author

sdojjy commented Dec 9, 2021

/run-integration-tests
/run-kafka-integration-test

@ti-chi-bot
Copy link
Member

@sdojjy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sdojjy
Copy link
Member Author

sdojjy commented Dec 9, 2021

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 9dad091 into pingcap:master Dec 9, 2021
@sdojjy sdojjy deleted the mysql-sink-manage-checkpoint-per-table branch December 9, 2021 11:38
@sdojjy sdojjy restored the mysql-sink-manage-checkpoint-per-table branch December 27, 2021 03:19
@sdojjy sdojjy mentioned this pull request Dec 27, 2021
Merged
sdojjy added a commit to sdojjy/tiflow that referenced this pull request Dec 27, 2021
@sdojjy
cdc/sink: mysql sink manage checkpoint per table (pingcap#3645)
dc74082 
# Conflicts:
#	cdc/sink/common/common_test.go
#	cdc/sink/mysql_params_test.go
#	cdc/sink/mysql_test.go
#	cdc/sink/mysql_worker.go
#	cdc/sink/mysql_worker_test.go
#	tests/integration_tests/sink_hang/run.sh
sdojjy added a commit to sdojjy/tiflow that referenced this pull request Dec 27, 2021
@sdojjy
cdc/sink: mysql sink manage checkpoint per table (pingcap#3645)
8e34358 
# Conflicts:
#	cdc/sink/common/common_test.go
#	cdc/sink/mysql_params_test.go
#	cdc/sink/mysql_test.go
#	cdc/sink/mysql_worker.go
#	cdc/sink/mysql_worker_test.go
#	tests/integration_tests/sink_hang/run.sh
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 29, 2021
Merged
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
@sdojjy @zhaoxinyu
cdc/sink: mysql sink manage checkpoint per table (pingcap#3645)
7973c7e
This was referenced Dec 30, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus overvenus approved these changes

@liuzix liuzix Awaiting requested review from liuzix

@amyangfei amyangfei Awaiting requested review from amyangfei

@ben1009 ben1009 Awaiting requested review from ben1009

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sdojjy @ti-chi-bot @codecov-commenter @overvenus @asddongmen