Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mq (ticdc): mq sink manage checkpoint ts per table #3746

Merged
merged 13 commits into from
Dec 8, 2021
Merged

mq (ticdc): mq sink manage checkpoint ts per table #3746

merged 13 commits into from
Dec 8, 2021

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Dec 6, 2021 •
edited
Loading

What problem does this PR solve?

To fix the bug of #3503 , we should manage table checkpoint per table in the sink, this is PR is a part of the fix. In this PR, mq sink manage checkpointTs per table.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note 

Part of fix the bug of #3503 ,  mq sink manage checkpointTs per table to avoid checkpointTs advances unexpected.

@asddongmen asddongmen added type/bugfix This PR fixes a bug. component/sink Sink component. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/ticdc Issues or PRs related to TiCDC. labels Dec 6, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 6, 2021
@asddongmen
Copy link
Contributor Author

asddongmen commented Dec 6, 2021 •
edited
Loading

/run-kafka-integration-tests

@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests

@asddongmen
Copy link
Contributor Author

/run-verify

@asddongmen asddongmen changed the title [DNM-Testing]mq: mq sink manage checkpoint ts per table mq (ticdc): mq sink manage checkpoint ts per table Dec 7, 2021
@asddongmen asddongmen added the status/ptal Could you please take a look? label Dec 7, 2021
@ti-chi-bot
Copy link
Member

@sdojjy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus overvenus mentioned this pull request Dec 7, 2021
Closed
9 tasks
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2021
@Rustin170506
Copy link
Member

/merge

/hold

After you have processed the release note, please feel free to /unhold.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8d42b6c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2021
@Rustin170506
Copy link
Member

Rustin170506 commented Dec 8, 2021 •
edited
Loading

@asddongmen I suggest you trigger a few more kafka integration tests to make sure it doesn't introduce unstable tests. What do you think?

@asddongmen
Copy link
Contributor Author

/merge

/hold

After you have processed the release note, please feel free to /unhold.

done, PTAl~ thanks

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@Rustin170506
Copy link
Member

/run-kafka-integration-tests

3 similar comments
@Rustin170506
Copy link
Member

/run-kafka-integration-tests

@Rustin170506
Copy link
Member

/run-kafka-integration-tests

@Rustin170506
Copy link
Member

/run-kafka-integration-tests

@Rustin170506
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506 Rustin170506 removed the status/ptal Could you please take a look? label Dec 8, 2021
@ti-chi-bot
Copy link
Member

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5b1bbe8 into pingcap:master Dec 8, 2021
@sdojjy sdojjy mentioned this pull request Dec 27, 2021
Merged
sdojjy pushed a commit to sdojjy/tiflow that referenced this pull request Dec 27, 2021
@asddongmen @sdojjy
mq (ticdc): mq sink manage checkpoint ts per table (pingcap#3746)
a4f78ac
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 29, 2021
Merged
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
@asddongmen @zhaoxinyu
mq (ticdc): mq sink manage checkpoint ts per table (pingcap#3746)
c0466bc
This was referenced Dec 30, 2021
Merged
Merged
Merged
@asddongmen asddongmen deleted the mq_sink_report_ts_per_table branch February 18, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@overvenus overvenus overvenus approved these changes

@sdojjy sdojjy sdojjy approved these changes

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asddongmen @ti-chi-bot @Rustin170506 @sdojjy @overvenus