Upgrade google-cloud-sdk #5042
Merged
Upgrade google-cloud-sdk #5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
|
I tested with a command below |
Merged
t-kikuc
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Use x86_64 version of google-cloud-sdk Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Upgrade google-cloud-sdk Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
t-kikuc
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Use x86_64 version of google-cloud-sdk Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Upgrade google-cloud-sdk Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
added a commit
that referenced
this pull request
Jul 18, 2024
* fix: upgrade @loadable/component from 5.14.1 to 5.16.4 (#5000) Snyk has created this PR to upgrade @loadable/component from 5.14.1 to 5.16.4. See this package in yarn: @loadable/component See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: upgrade @reduxjs/toolkit from 1.8.5 to 1.9.7 (#4999) Snyk has created this PR to upgrade @reduxjs/toolkit from 1.8.5 to 1.9.7. See this package in yarn: @reduxjs/toolkit See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: upgrade react-router-dom from 5.2.0 to 5.3.4 (#5001) Snyk has created this PR to upgrade react-router-dom from 5.2.0 to 5.3.4. See this package in yarn: react-router-dom See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: upgrade grpc-web from 1.0.7 to 1.5.0 (#4984) Snyk has created this PR to upgrade grpc-web from 1.0.7 to 1.5.0. See this package in yarn: grpc-web See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * [Snyk] Security upgrade alpine from 3.17 to 3.20 (#5014) * fix: docs/Dockerfile to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413590 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413590 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413591 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-7413591 Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Bump alpine Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Upgrade google-cloud-sdk (#5042) * Use x86_64 version of google-cloud-sdk Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Upgrade google-cloud-sdk Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * feat: add support mention slack groups for NotificationReceiverSlack and NotificationMention (#4903) * feat: add support mentione groups for NotifactionReceiverSlack and slackGroups for NotificationMention Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * remove change in docs v0.47.x Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * update docs Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * update logic for having getGroupsAsString() Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * using <!subteam^ID> for group mentioning Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * typo Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * call both getAccountsAsString and getGroupsAsString Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * revert change pkg/model/notificationevent.pb.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * use same format for group <!subteam^ID> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * same method to format slack group Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * following slack api, !subteam^ is a literal string that should not change Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * feat: add slackUsers field and mark slack as deprecated field Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * revert pkg/model/notificationevent.pb.go Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * update doc Using the groupID or teamID in the documents makes it easier for users to use this feature. Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * add code gen Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * adjust mention users and slack logic Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * unify the process to get users and groups in the same method Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> --------- Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Ignore `desiredCount` of ECS when it's 0 or not set for AutoScaling (#5030) * add a flag: ignoreDesiredCountOnUpdate Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * ignore desiredCount on updateService if needed Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add a flag ignoreDesiredCountOnUpdate into each func Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Format func params and comment Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix tests: add a missing attribute Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * recover desiredCount in CreateService (mistake) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add mentioning driftdetection Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert changes of adding ignoreDesiredCountOnUpdate This reverts commit a0f3459. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert commits of adding ignoreDesiredCount" This reverts commit 7d65824. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert "add docs" This reverts commit dcd7dc9. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert "Format func params and comment" This reverts commit 5103158. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert "Add a flag ignoreDesiredCountOnUpdate into each func" This reverts commit d17a9b7. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert "ignore desiredCount on updateService if needed" This reverts commit cf3efbf. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Revert "add a flag: ignoreDesiredCountOnUpdate" This reverts commit 6b2af75. Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * ignore updating desiredCount if it's 0 or not defined Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Use pruning when 'recreate' is on Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * refine docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Clarify procedure of configuring Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Chris Aniszczyk <caniszczyk@gmail.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Henry Vu <26101787+hungran@users.noreply.github.com>
Merged
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
We upgraded the alpine to 3.20 in this PR
Alpine 3.20 uses the newer Python, so this issue occurred.
https://issuetracker.google.com/issues/303280713?pli=1
The issue is already fixed in the latest google-cloud-sdk, so I upgrade it.
Fixes #
Does this PR introduce a user-facing change?: No