Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #4571 #5171 #5190 #5191

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Cherry-pick #4571 #5171 #5190 #5191

merged 3 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. Modified to use Git with PAT (#4571) 

    * fix to read PAT settings from file

Signed-off-by: sZma5a <sZma5a@geekers.io>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* piped

Signed-off-by: sZma5a <sZma5a@geekers.io>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* include  PAT information in URL

Signed-off-by: sZma5a <sZma5a@geekers.io>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: modification of conditional branching

Co-authored-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: corrected error in error message

Co-authored-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: integration of mask function

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: make validation test

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: function name

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: rename function for validation PAT

Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: fix test code as pointed out in the review

Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* feat: add explan
for git personal access token in document

Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: change required in documentation

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: change return value

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: add test case

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: fix test

Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: PipedGit struct to use password
authentication instead of personal access token

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix to read PAT settings from file

Signed-off-by: sZma5a <sZma5a@geekers.io>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* piped

Signed-off-by: sZma5a <sZma5a@geekers.io>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: integration of mask function

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: make validation test

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: function name

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: rename function for validation PAT

Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: fix test

Signed-off-by: swallow <masaaki@haribote-lab.net>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: PipedGit struct to use password
authentication instead of personal access token

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Fix Git authentication configuration

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Update password authentication configuration

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Fix error variable name

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Fix rename password

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Refactor includePasswordAuthRemote function

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Update password authentication in clone test

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: delete PasswordAuth

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: remove unused PasswordAuth field and refactor password authentication in git client

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Remove unnecessary print statement in Validate function

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: fix code for rebase

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: remove unused GitPasswordAuth configuration

Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* feat: add password decoding for password in includePasswordRemote function

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: refactor Git password authentication method

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* fix: update password encoding in TestCloneUsingPassword

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Update docs/content/en/docs-dev/user-guide/managing-piped/configuration-reference.md

Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Update pkg/config/piped.go

Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* [wip] delete password

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* [wip] not tested - change token to args from url

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Fix commented out test case

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* Refactor authentication in git client

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

* feat: add password decoding function and replace Password string

Signed-off-by: sZma5a <masaaki.haribote@gmail.com>

---------

Signed-off-by: sZma5a <sZma5a@geekers.io>
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Signed-off-by: swallow <masaaki@haribote-lab.net>
Co-authored-by: sZma5a <sZma5a@geekers.io>
Co-authored-by: sivchari <shibuuuu5@gmail.com>
Co-authored-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Co-authored-by: Your Name <you@example.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
    @sZma5a @sivchari
    @ffjlabo @pipecd-bot
    6 people authored and pipecd-bot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    59bf54e View commit details
    Browse the repository at this point in the history

  2. Use singleflight to clone/update repository cache (#5171) 

    Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
    @Warashi @pipecd-bot
    Warashi authored and pipecd-bot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9910184 View commit details
    Browse the repository at this point in the history

  3. Refactor the git clone (#5190) 

    Move the authArgs into the singleflight closure, as they are only used within it.

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
    @Warashi @pipecd-bot
    Warashi authored and pipecd-bot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d27cff8 View commit details
    Browse the repository at this point in the history