Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering options to new submissions list #2612

Closed
6 of 12 tasks
NateWr opened this issue Jun 22, 2017 · 42 comments
Closed
6 of 12 tasks

Add filtering options to new submissions list #2612

NateWr opened this issue Jun 22, 2017 · 42 comments
Assignees
Labels
Enhancement:3:Major A new feature or improvement that will take a month or more to complete. Hosting Bug reports and feature requests from Publishing Services's hosted clients.

Comments

@NateWr
Copy link
Contributor

NateWr commented Jun 22, 2017

Initial testing of the new submissions list indicates strong demand for additional filtering options:

High Priority

Requested

Done

@NateWr NateWr added Enhancement:3:Major A new feature or improvement that will take a month or more to complete. UI/UX Review labels Jun 22, 2017
@NateWr NateWr added this to the OJS 3.1 milestone Jun 22, 2017
@NateWr NateWr self-assigned this Jun 22, 2017
NateWr added a commit to NateWr/pkp-lib that referenced this issue Aug 11, 2017
NateWr added a commit to NateWr/ojs that referenced this issue Aug 11, 2017
NateWr added a commit to NateWr/pkp-lib that referenced this issue Aug 11, 2017
NateWr added a commit to NateWr/omp that referenced this issue Aug 11, 2017
NateWr added a commit to NateWr/ojs that referenced this issue Aug 11, 2017
@NateWr
Copy link
Contributor Author

NateWr commented Aug 11, 2017

PRs:
#2704
pkp/ojs#1490
pkp/omp#428

Filtering is available on all the main submission lists for journal managers, subeditors and assistants.

submission-list-filtering

A couple questions for @jmacgreg and @stranack (and whoever):

  1. Does this look like it covers the requests we got for filtering?
  2. Is it ok to delay category/series filtering in OMP for now?
  3. Should these filters be added to the submission selection lists (eg - export and catalog entry)? Urgently for 3.1 or as a mid-priority feature?

@alexxxmendonca
Copy link
Contributor

Just wondering: is "Review overdue" something we could consider adding to the filters?

It would be a quick way to filter those submissions that have overdue reviews.

@jmacgreg
Copy link
Contributor

Hi Nate,

This looks great! It would be great to add a "Status" filter option as @alexxxmendonca suggests, but if this is a lot of work I think it could be added as a post-3.1 follow-up, so long as the status is indicated in the listing (as it appears to be). It should definitely be considered before too long, though.

One small note - just confirming that the submission ID will be re-added, correct?

I have no opinion about the category/series filtering, or adding this to other submission selection lists. The highest priority, which you are achieving here, is the submission dashboard.

@alexxxmendonca
Copy link
Contributor

Also, forgot to add, very important: it looks great! Good work, Nate!

@NateWr
Copy link
Contributor Author

NateWr commented Aug 11, 2017

@jmacgreg and @alexxxmendonca, see my initial comment in the issue for details about filtering by status. This is highly desired, but exists nowhere in our database, so we can't really query by it. We need to decide and implement some stage status tracking to get there (See: #1662).

@jmacgreg
Copy link
Contributor

jmacgreg commented Aug 11, 2017 via email

NateWr added a commit to NateWr/pkp-lib that referenced this issue Aug 14, 2017
NateWr added a commit to NateWr/omp that referenced this issue Aug 14, 2017
NateWr added a commit to NateWr/pkp-lib that referenced this issue Aug 14, 2017
NateWr added a commit to NateWr/pkp-lib that referenced this issue Aug 14, 2017
NateWr added a commit to NateWr/pkp-lib that referenced this issue Aug 14, 2017
NateWr added a commit to NateWr/ojs that referenced this issue Aug 14, 2017
NateWr added a commit to NateWr/ojs that referenced this issue Aug 14, 2017
@carzamora
Copy link
Contributor

Hi, the filter feature is really great but it can be better, of course. I have an idea or request for this filter... would will be great if we could filter by submission date and last modification date, I was looking and this parameters already exists in the database. This is really important for editors, many times some manuscripts spend more time in the “limbo” because that are forgotten.

@NateWr
Copy link
Contributor Author

NateWr commented Nov 8, 2017

Hi @t4x0n,

At the moment, submissions in the lists are ordered by submission date with the newest first. So an editor should be able to locate submissions in limbo by reaching the end of the list and checking the activity logs.

The last modification date probably won't mean what you expect it to mean. It only tracks modifications to the submission object itself (title, etc), but doesn't track activity that happens during the workflow (peer reviews, revisions submitted, etc). A better approach might be to look at the most recent entry in the activity log.

How long something must be inactive before it is considered in limbo will differ for each journal, though, so it's hard to determine this automatically. One possibility would be to have a configurable setting for each journal, and to include submissions inactive for X days in the Overdue filter.

@le-ti-ka
Copy link

le-ti-ka commented Nov 17, 2017 via email

@NateWr
Copy link
Contributor Author

NateWr commented Nov 17, 2017

Hi @le-ti-ka, are you talking about the in-context help panel that slides out from the right in OJS? If so, you can contribute a translation to that repository here: https://github.com/pkp/ojs-user-guide

@jmacgreg
Copy link
Contributor

Hi Nate (for when you return),

Revisiting @t4x0n's comments regarding filtering by submission by date - it was put to me this way by a client:

As an editor, I want to be able to see all submissions that haven't had activity for "X" days, so that I can triage those appropriately.

"Active" can mean different things, but I think once the statuses per item 3) in the issue description are added, you could do something like:

  • show me all submissions that are overdue by 7 days;
  • show me all submissions that haven't had an editor response in 20 days;

... and so on, maybe using a slider similar for the # of days as you have for the reviewer lists.

This is probably a substantial amount of work on top of work that hasn't been done yet, so let me know if it makes sense; and/or if it should be split into a separate bug!

@NateWr
Copy link
Contributor Author

NateWr commented Mar 5, 2018

This leans towards the requirement for tasks with due dates in #1662 (comment). I'm all for it but we'll need due dates attached to tasks before we can make it a reality.

@NateWr
Copy link
Contributor Author

NateWr commented May 3, 2018

@jmacgreg and @ajnyga: a follow-up on the request to filter by assigned editors. Should this filter be restricted to Journal Managers? Is there a scenario where it's inappropriate for a Subeditor to see what submissions have been assigned to other Subeditors? I noticed that Subeditors do not have access the the All Active or Archives submissions lists.

@jmacgreg
Copy link
Contributor

jmacgreg commented May 3, 2018

My understanding is that subeditors should only have access to their own submissions, so they probably shouldn't be able to filter by other editors - that should only be available to assigning editors - but I have no super-strong feelings about this.

@ajnyga
Copy link
Collaborator

ajnyga commented May 3, 2018

I agree with @jmacgreg. Using subeditors is the usual way of handling the author/editor problem in OJS so they should only see submissions assigned to them.

It is a tool for helping the assignment of submissions anyway so I do not see why subeditors would need it.

@amandastevens amandastevens added the Hosting Bug reports and feature requests from Publishing Services's hosted clients. label Jun 4, 2018
@NateWr
Copy link
Contributor Author

NateWr commented Oct 22, 2018

Following up on the UI/UX results from the 2018 Sprint, and discussion with the UI/UX team, we decided that quick filters need to be available for editors which breakdown a few different "what i need to do now" tasks:

  • In review and no reviewers assigned to current round
  • One or more review assignments and acceptance are overdue
  • Revisions have been submitted and a new review round has not been started and it has not been advanced to a new stage

@amandastevens
Copy link
Collaborator

Another client has requested the ability to filter the submission list by issue or otherwise see in the submission list (All Active and Archives) what issue a submission is scheduled to be published in or has been published in.

@NateWr
Copy link
Contributor Author

NateWr commented Sep 23, 2019

Thanks @amandastevens! Issue assignment should be fairly straightforward because the API already supports getting submissions by issue ID. https://github.com/pkp/ojs/blob/master/classes/services/SubmissionService.inc.php#L49

@eddoff
Copy link
Contributor

eddoff commented Oct 17, 2019

@NateWr, Are there any progress in implementing the issue filter?

@NateWr
Copy link
Contributor Author

NateWr commented Oct 18, 2019

Hi @eddoff, there is no progress yet. The REST API supports the filter parameter but we have to build a UI control to select one or more issues to filter by. Since there may be dozens or hundreds of issues, we can not just list them all like other filters.

@NateWr
Copy link
Contributor Author

NateWr commented Nov 29, 2021

I believe all of the filters identified here have been implemented or file separately now. Closing this in favor of those issues. If you want to track issues related to submission discovery and tracking, see this project:

https://github.com/pkp/pkp-lib/projects/8

@NateWr NateWr closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:3:Major A new feature or improvement that will take a month or more to complete. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Projects
None yet
Development

No branches or pull requests