feat: support tasklists (#333)

* Revert "Revert "feat: support children via GitHub Taskslist (#315)" to fix #324 (#326)"

This reverts commit 4a93ba2.

fixes #324
fixes #313

* test: add test to confirm failure in #324

* fix: failure when parsing non-child link in issue.body

* chore: address codeclimate comments

* test: ensure children link parsing handles markdown links

* fix: parsing markdown links in children

* fix: more issues parsing additional links as children

* chore: parse children links with for loop

User Guide.md

@@ -40,6 +40,7 @@ The fundamental unit of a roadmap is a project milestone. In the context of road
 - Roadmaps are represented by a single root node, or GitHub issue, which contains links to milestones contained within that roadmap.
 - The roadmap root node and child milestones can be in any public repository as long as the issues satisfy the requirements outlined in this document.
   - This means that you can link to existing GitHub issues as child milestones.
+- Errors will be logged and displayed for the user in starmap.site
 
 ### Milestone Encodings
 
@@ -93,18 +94,38 @@ can expect to get from this milestone.
 #### Children
 
 - A milestone may have child milestones.
-- Child milestones are simply full URL links to other GitHub milestone issues.
-- Child milestones can exist in any public Github repository.
+- Child milestones are simply GitHub issue identifiers (#<issue_number>, <org>/<repo>#<issue_number>, or full URLs) to other GitHub milestone issues.
+- Child milestones can exist in any public GitHub repository.
 - It is expected that child milestone issues are themselves properly encoded milestones; otherwise they will be ignored by Starmap.
 - Within a parent issue, child milestones are encoded as follows (raw Markdown):
 
+##### Tasklist syntax
+
+Tasklists allow for "taskifying" of strings, and we have no way to link a random string to a GitHub issue. You must convert any [tasks to issues](https://docs.github.com/en/issues/tracking-your-work-with-issues/about-tasklists#converting-draft-issues-to-issues-in-a-tasklist) for them to show up as a child milestone.
+
+We will do our best to support the expected syntax of GitHub's tasklist functionality.
+
+See https://docs.github.com/en/issues/tracking-your-work-with-issues/about-tasklists#creating-tasklists and https://github.com/pln-planning-tools/Starmap/issues/245 for more details.
+
+```
+```[tasklist]
+### Tasks
+- [ ] https://github.com/pln-roadmap/Roadmap-Vizualizer/issues/10
+- [ ] https://github.com/pln-roadmap/Roadmap-Vizualizer/issues/9
+- [ ] https://github.com/pln-roadmap/Roadmap-Vizualizer/issues/8
+\```
+```
+
+##### "Children:" syntax
+
+This syntax is deprecated. Please see https://github.com/pln-planning-tools/Starmap/issues/245 for more details.
+
 ```
 Children:
 - https://github.com/pln-roadmap/Roadmap-Vizualizer/issues/10
 - https://github.com/pln-roadmap/Roadmap-Vizualizer/issues/9
 - https://github.com/pln-roadmap/Roadmap-Vizualizer/issues/8
 ```
-- Errors will be logged and displayed for the user in starmap.site
 
 ### Progress Indicators
 
@@ -127,6 +148,39 @@ Children:
 ### Templates
 
 #### Root Node Issue
+
+##### Using GitHub Tasklists
+
+```
+Title: [Team/Project Name] [Duration] Roadmap
+
+Description (optional):
+The goal of this roadmap is to outline the key milestones and deliverables for our team/project over the next [Duration].
+
+```[tasklist]
+### Any descriptor or other text
+- [ ] #123 <!-- will be recognized by starmap -->
+- [ ] org/repo#123 <!-- will be recognized by starmap -->
+- [ ] some non-link description <!-- will NOT be recognized by starmap -->
+- [ ] https://github.com/org/repo/issue/987 <!-- will be recognized by starmap -->
+
+### Any text
+- [ ] #456 <!-- will be recognized by starmap -->
+- [ ] org/repo#567 <!-- will be recognized by starmap -->
+- [ ] https://github.com/other-org/other-repo/issue/987 <!-- will be recognized by starmap -->
+
+\```
+
+Note: This roadmap is subject to change as priorities and circumstances evolve.
+
+Starmap Link: [Starmap Link]
+
+```
+
+##### Using "Children:"
+
+**NOTE:** The children: section is deprecated. Please see https://github.com/pln-planning-tools/Starmap/issues/245 for more details
+
 ```
 Title: [Team/Project Name] [Duration] Roadmap
 

lib/backend/getGithubIssueDataWithGroupAndChildren.ts

@@ -5,7 +5,7 @@ import { resolveChildren } from './resolveChildren';
 import { resolveChildrenWithDepth } from './resolveChildrenWithDepth';
 
 export async function getGithubIssueDataWithGroupAndChildren (issueData: GithubIssueDataWithGroup, errorManager: ErrorManager, usePendingChildren = false): Promise<GithubIssueDataWithGroupAndChildren> {
-  const childrenParsed: ParserGetChildrenResponse[] = getChildren(issueData.body_html);
+  const childrenParsed: ParserGetChildrenResponse[] = getChildren(issueData);
   let pendingChildren: PendingChildren[] | undefined = undefined;
   let children: GithubIssueDataWithGroupAndChildren[] = [];
 

lib/backend/issue.ts

@@ -27,6 +27,7 @@ export async function getIssue ({ owner, repo, issue_number }): Promise<GithubIs
       state: data.state as IssueStates,
       node_id: data.node_id,
       body_html: data.body_html || '',
+      body: data.body || '',
       labels: data.labels
         .map((label) => (typeof label !== 'string' ? label.name : label)) as string[],
     };

lib/parser.ts

@@ -1,7 +1,9 @@
 import { parseHTML } from 'linkedom';
 import { ErrorManager } from './backend/errorManager';
+import { getValidUrlFromInput } from './getValidUrlFromInput';
 import { getEtaDate, isValidChildren } from './helpers';
-import { GithubIssueDataWithChildren, ParserGetChildrenResponse } from './types';
+import { paramsFromUrl } from './paramsFromUrl';
+import { GithubIssueData, GithubIssueDataWithChildren, ParserGetChildrenResponse } from './types';
 
 export const getDueDate = (issue: Pick<GithubIssueDataWithChildren, 'html_url' | 'body_html' | 'root_issue' | 'title'>, errorManager: ErrorManager) => {
   const { body_html: issueBodyHtml } = issue;
@@ -27,8 +29,107 @@ export const getDueDate = (issue: Pick<GithubIssueDataWithChildren, 'html_url' |
   };
 };
 
-export const getChildren = (issue: string): ParserGetChildrenResponse[] => {
-  const { document } = parseHTML(issue);
+function getSectionLines(text: string, sectionHeader: string) {
+  const sectionIndex = text.indexOf(sectionHeader);
+  if (sectionIndex === -1) {
+    return [];
+  }
+  return text.substring(sectionIndex)
+    .split(/[\r\n]+/).slice(1)
+    .map(getUrlFromMarkdownText)
+}
+
+const splitAndGetLastItem = (line: string) => line.trim().split(' ').slice(-1)[0]
+const ensureTaskListChild = (line: string) => line.trim().indexOf('-') === 0
+const getUrlFromMarkdownText = (line: string) => line.trim().split('](').slice(-1)[0].replace(')', '')
+
+function getUrlStringForChildrenLine(line: string, issue: Pick<GithubIssueData, 'html_url'>) {
+  if (/^#\d+$/.test(line)) {
+    const { owner, repo } = paramsFromUrl(issue.html_url)
+    line = `${owner}/${repo}${line}`
+  }
+  const url = getValidUrlFromInput(line)
+  if (!url.host.includes('github.com')) {
+    throw new Error('Invalid host for children item')
+  }
+  return url.href
+}
+/**
+ * We attempt to parse the issue.body for children included in 'tasklist' format
+ * @see https://github.com/pln-planning-tools/Starmap/issues/245
+ *
+ * @param {string} issue_body
+ */
+function getChildrenFromTaskList(issue: Pick<GithubIssueData, 'body' | 'html_url'>): ParserGetChildrenResponse[] {
+  // tasklists require the checkbox style format to recognize children
+  const lines = getSectionLines(issue.body, '```[tasklist]')
+    .filter(ensureTaskListChild)
+    .map(splitAndGetLastItem)
+    .filter(Boolean);
+
+  if (lines.length === 0) {
+    throw new Error('Section missing or has no children')
+  }
+
+  return convertLinesToChildren(lines, issue, 'tasklist')
+}
+
+/**
+ * A new version of getchildren which parses the issue body_text instead of issue body_html
+ *
+ * This function must support recognizing the current issue's organization and repo, because some children may simply be "#43" instead of a github short-id such as "org/repo#43"
+ * @param {string} issue
+ */
+function getChildrenNew(issue: Pick<GithubIssueData, 'body' | 'html_url'>): ParserGetChildrenResponse[] {
+
+  try {
+    return getChildrenFromTaskList(issue);
+  } catch (e) {
+    // Could not find children using new tasklist format,
+    // try to look for "children:" section
+  }
+  const lines = getSectionLines(issue.body, 'children:').map(splitAndGetLastItem).filter(Boolean);
+  if (lines.length === 0) {
+    throw new Error('Section missing or has no children')
+  }
+
+  // guard against HTML tags (covers cases where this method is called with issue.body_html instead of issue.body_text)
+  if (lines.some((line) => line.startsWith('<'))) {
+    throw new Error('HTML tags found in body_text');
+  }
+
+  return convertLinesToChildren(lines, issue, 'children:')
+}
+
+function getValidChildrenLinks(lines: string[], issue: Pick<GithubIssueData, 'html_url'>): string[] {
+  const validChildrenLinks: string[] = []
+  for (const line of lines) {
+    try {
+      validChildrenLinks.push(getUrlStringForChildrenLine(line, issue))
+    } catch (e) {
+      break
+    }
+  }
+  return validChildrenLinks
+}
+
+function convertLinesToChildren(lines: string[], issue: Pick<GithubIssueData, 'html_url'>, group: string): ParserGetChildrenResponse[] {
+  const validChildrenLinks = getValidChildrenLinks(lines, issue)
+
+  return validChildrenLinks
+    .map((html_url): ParserGetChildrenResponse => ({
+      group,
+      html_url,
+    }))
+}
+
+export const getChildren = (issue: Pick<GithubIssueData, 'body_html' | 'body' | 'html_url'>): ParserGetChildrenResponse[] => {
+  try {
+    return getChildrenNew(issue);
+  } catch (e) {
+    // ignore failures for now, fallback to old method.
+  }
+  const { document } = parseHTML(issue.body_html);
   const ulLists = [...document.querySelectorAll('ul')];
   const filterListByTitle = (ulLists) =>
     ulLists.filter((list) => {

lib/types.d.ts

@@ -4,6 +4,7 @@ import type { RoadmapMode, IssueStates, DateGranularityState } from './enums'
 
 export interface GithubIssueData {
   body_html: string;
+  body: string;
   html_url: string;
   labels: string[];
   node_id: string;

pages/api/roadmap.ts

@@ -33,7 +33,7 @@ export default async function handler(
   try {
     const rootIssue = await getIssue({ owner, repo, issue_number });
 
-    const childrenFromBodyHtml = (!!rootIssue && rootIssue.body_html && getChildren(rootIssue.body_html)) || null;
+    const childrenFromBodyHtml = (!!rootIssue && rootIssue.body_html && getChildren(rootIssue)) || null;
     let children: Awaited<ReturnType<typeof resolveChildrenWithDepth>> = [];
     try {
       if (childrenFromBodyHtml != null) {