Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmaps are not loading (error msg: error parsing issue) #324

Closed
AlexxNica opened this issue Feb 17, 2023 · 5 comments · Fixed by #326 or #333
Closed

Roadmaps are not loading (error msg: error parsing issue) #324

AlexxNica opened this issue Feb 17, 2023 · 5 comments · Fixed by #326 or #333
Assignees
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete fixed A PR has been merged for this issue kind/regression Categorizes issue or PR as related to a regression from a prior release. P0

Comments

@AlexxNica
Copy link
Collaborator

AlexxNica commented Feb 17, 2023

Roadmaps are not loading. It seems to be an error with the parser. Probably a regression from #315?

Tested on https://starmap.site/roadmap/github.com/filecoin-station/roadmap/issues/1

Response from the API:

https://starmap.site/api/roadmap?owner=filecoin-station&repo=roadmap&issue_number=1

{"errors":[{"issueUrl":"https://starmap.site/roadmap/github.com/filecoin-station/roadmap/issues/1","issueTitle":"https://starmap.site/roadmap/github.com/filecoin-station/roadmap/issues/1","errors":[{"userGuideUrl":"https://github.com/pln-planning-tools/Starmap/blob/main/User%20Guide.md#children","title":"Error parsing issue","message":"Unsupported URL: https://starmap.site/roadmap/github.com/filecoin-station/roadmap/issues/1"}]},{"issueUrl":"https://github.com/filecoin-station/roadmap/issues/1","issueTitle":"Filecoin Station 2023 Roadmap","errors":[{"userGuideUrl":"https://github.com/pln-planning-tools/Starmap/blob/main/User%20Guide.md#children","title":"Error resolving children","message":"No children found, is this a root issue?"}]}],"data":{"labels":["roadmap"],"completion_rate":0,"due_date":"2023-12-31","html_url":"https://github.com/filecoin-station/roadmap/issues/1","group":"root","title":"Filecoin Station 2023 Roadmap","state":"open","node_id":"I_kwDOIUF5GM5U5JPE","parent":{"completion_rate":0,"due_date":""},"children":[]},"pendingChildren":[]}

Screenshot

image

@whizzzkid
Copy link
Collaborator

@AlexxNica
Copy link
Collaborator Author

I think we need to revert that PR until we figure out what's causing the error.

cc @SgtPooki

@AlexxNica AlexxNica added bug Something isn't working P0 labels Feb 18, 2023
@AlexxNica
Copy link
Collaborator Author

Deployment from the previous commit is working fine: https://starmaps-ccad3vayi-ipfs-ignite.vercel.app/roadmap/github.com/filecoin-station/roadmap/issues/1

Deployment from the PR is not working: https://starmaps-o358kbppd-ipfs-ignite.vercel.app/roadmap/github.com/filecoin-station/roadmap/issues/1

I'll go ahead and revert that PR while we fix whatever is causing the issue.

AlexxNica added a commit that referenced this issue Feb 19, 2023
… (#326)

This reverts the PR #315, commit b3d13d9 to fix roadmaps not loading.
Fixes #324
@github-project-automation github-project-automation bot moved this from Needs Grooming to Done in IPFS-GUI (PL EngRes) Feb 19, 2023
@AlexxNica AlexxNica added fixed A PR has been merged for this issue kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Feb 19, 2023
@SgtPooki SgtPooki reopened this Feb 21, 2023
@github-project-automation github-project-automation bot moved this from Done to Needs Grooming in IPFS-GUI (PL EngRes) Feb 21, 2023
SgtPooki added a commit that referenced this issue Feb 21, 2023
@SgtPooki
Copy link
Contributor

Opened WIP PR #333 to address this

@SgtPooki
Copy link
Contributor

error reproduced locally:

error: Error: Error resolving children: Error: Unsupported URL: https://starmap.site/roadmap/github.com/filecoin-station/roadmap/issues/1
    at resolveChildren (webpack-internal:///(api)/./lib/backend/resolveChildren.ts:30:11)
    at async resolveChildrenWithDepth (webpack-internal:///(api)/./lib/backend/resolveChildrenWithDepth.ts:14:20)
    at async handler (webpack-internal:///(api)/./pages/api/roadmap.ts:60:20)
    at async Object.apiResolver (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/api-utils/node.js:366:9)
    at async DevServer.runApi (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/next-server.js:481:9)
    at async Object.fn (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/next-server.js:741:37)
    at async Router.execute (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/router.js:252:36)
    at async DevServer.run (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/base-server.js:365:29)
    at async DevServer.run (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/dev/next-dev-server.js:709:20)
    at async DevServer.handleRequest (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/base-server.js:303:20)
Error: No children found, is this a root issue?
    at handler (webpack-internal:///(api)/./pages/api/roadmap.ts:63:17)
    at async Object.apiResolver (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/api-utils/node.js:366:9)
    at async DevServer.runApi (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/next-server.js:481:9)
    at async Object.fn (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/next-server.js:741:37)
    at async Router.execute (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/router.js:252:36)
    at async DevServer.run (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/base-server.js:365:29)
    at async DevServer.run (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/dev/next-dev-server.js:709:20)
    at async DevServer.handleRequest (/Users/sgtpooki/code/work/protocol.ai/pln-planning-tools/Starmaps/node_modules/next/dist/server/base-server.js:303:20)

@SgtPooki SgtPooki moved this from Needs Grooming to In Progress in IPFS-GUI (PL EngRes) Feb 21, 2023
@SgtPooki SgtPooki self-assigned this Feb 21, 2023
@SgtPooki SgtPooki moved this from In Progress to In Review in IPFS-GUI (PL EngRes) Feb 21, 2023
SgtPooki added a commit that referenced this issue Feb 21, 2023
* Revert "Revert "feat: support children via GitHub Taskslist (#315)" to fix #324 (#326)"

This reverts commit 4a93ba2.

fixes #324
fixes #313

* test: add test to confirm failure in #324

* fix: failure when parsing non-child link in issue.body

* chore: address codeclimate comments

* test: ensure children link parsing handles markdown links

* fix: parsing markdown links in children

* fix: more issues parsing additional links as children

* chore: parse children links with for loop
@github-project-automation github-project-automation bot moved this from In Review to Done in IPFS-GUI (PL EngRes) Feb 21, 2023
@SgtPooki SgtPooki added the effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete fixed A PR has been merged for this issue kind/regression Categorizes issue or PR as related to a regression from a prior release. P0
Projects
None yet
3 participants