Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roadmaps not loading after #315 #326

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Fix roadmaps not loading after #315 #326

merged 1 commit into from
Feb 19, 2023

Conversation

AlexxNica
Copy link
Collaborator

This reverts the PR #315, commit b3d13d9.

Fixes #324

@vercel
Copy link

vercel bot commented Feb 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
starmaps ✅ Ready (Inspect) Visit Preview Feb 19, 2023 at 0:36AM (UTC)

@AlexxNica
Copy link
Collaborator Author

I'm merging this without waiting for review to fix #324 ASAP given the app is currently unusable for some roadmaps.

@SgtPooki
Copy link
Contributor

SgtPooki commented Feb 21, 2023

@AlexxNica I've removed you from the pln-planning-tools org since you're not an official maintainer of this project any longer and shouldn't have the ability to do this.

@SgtPooki SgtPooki mentioned this pull request Feb 21, 2023
SgtPooki added a commit that referenced this pull request Feb 21, 2023
SgtPooki added a commit that referenced this pull request Feb 21, 2023
* Revert "Revert "feat: support children via GitHub Taskslist (#315)" to fix #324 (#326)"

This reverts commit 4a93ba2.

fixes #324
fixes #313

* test: add test to confirm failure in #324

* fix: failure when parsing non-child link in issue.body

* chore: address codeclimate comments

* test: ensure children link parsing handles markdown links

* fix: parsing markdown links in children

* fix: more issues parsing additional links as children

* chore: parse children links with for loop
@AlexxNica
Copy link
Collaborator Author

@AlexxNica I've removed you from the pln-planning-tools org since you're not an official maintainer of this project any longer and shouldn't have the ability to do this.

@SgtPooki I don't think this is the right approach to take if the goal is to have an open and collaborative environment. You could've easily reached out to me to say that you wanted me to leave the organization and I would've done so without a problem.

Despite this, it wasn't and still isn't clear who the "official maintainers" are for this project/org. I suggest this information gets added somewhere to avoid conflicts and maintain a healthy community.

I'll also add some quotes from PLN Galaxy's working together & communication docs that I think is valuable for us, especially in this context:

We are kind and respectful.

  • We do not insult, bully, disparage, or antagonize one another.
  • We ask questions, seeking clarification and knowledge because we don't assume we have the full story.
  • We communicate in good faith, meaning that we don't provoke or pester people intentionally.
  • We help one another grow and assume that we have the best intent.

And from Protocol Labs Network's Code of Conduct:

Protocol Labs Network Code of Conduct
The Protocol Labs Network is a collection of open source R&D labs working together to build the next generation of the internet. The network is strong because its members share a set of common values such as integrity, respect, and accountability. The strength of this community hinges upon the contributions and trustworthiness of its members, and we look to each of you to continually support and build up the network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roadmaps are not loading (error msg: error parsing issue)
2 participants