Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings about unused varyings #38

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Fix warnings about unused varyings #38

merged 1 commit into from
Apr 1, 2019

Conversation

rhuitl
Copy link
Contributor

@rhuitl rhuitl commented Apr 1, 2019

by not declaring them when they would be optimized out.

Observed on Chrome on MacOS with AMD Radeon R9 M370X.

@rhuitl
Fix warnings about unused varyings by not declaring them when they wo…
7b64e0b 
…uld be optimized out.

Observed on Chrome on MacOS with AMD Radeon R9 M370X.
@hccampos
Copy link
Collaborator

hccampos commented Apr 1, 2019

Thank you @rhuitl ! This will be a pain to maintain, but it is indeed pretty annoying to get all those warnings.

@hccampos hccampos merged commit 1e74717 into pnext:master Apr 1, 2019
@rhuitl
Copy link
Contributor Author

rhuitl commented Apr 1, 2019

Yes I know! It's really annoying but I don't know a better solution at the moment. Maybe reducing the preprocessor complexity in the first place, e.g. have more different sets of shaders and use Webpack to @import common code parts.

@rhuitl rhuitl deleted the fix-shader-warnings branch April 1, 2019 17:12
@hccampos
Copy link
Collaborator

hccampos commented Apr 1, 2019

Also released in v0.0.19 @rhuitl

@rhuitl rhuitl mentioned this pull request Apr 3, 2019
Merged
hccampos pushed a commit that referenced this pull request Apr 3, 2019
@rhuitl
fix(point-cloud-material): define MAX_POINT_LIGHTS and MAX_DIR_LIGHTS (…
3d3306e 
…#40)

Otherwise IE11 fails to compile the shader with "syntax error, unexpected IDENT_TOK".

This has been introduced by my changes for #38.

This solution is not pretty, but the related code in the shader is dead anyways - required uniforms are not in the material (yet?).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhuitl @hccampos