make eslint fix the formatting #3412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
approved these changes
Jan 3, 2019
harpere
added
the
needs 2nd review
idettman
suggested changes
Jan 3, 2019
…ze instead of bid.sizes (prebid#3377) * Added telaria bid adapter * more documentation * Added more test cases. And improved some code in the adapter * Removed the check for optional params, they are handled in the server. Also updated certain param names used in the test spec. * added some spaces to fix CircleCI tests * added some spaces to fix CircleCI tests * fixed code indentation in /spec/AnalyticsAdapter_spec.js which causing the CircleCI tests to fail. * Reverted the changes * merged with prebid master. * creative Id is required when we build a response but our server doesn't always have the crid, so using a sentinel value when we don't have the crid. * - removed an un used method - Removed the package-lock file. * merging to master * updated telaria bid adapter to use player size provided by the bid.mediaTypes.video.playerSize instead of bid.sizes. prebid#3331 * - removed the requirement for having player size - updated the test spec to reflect the above change - removed changes to the package-lock.json file. * added a param to the ad call url to let us know that the request is coming via hb. * to lower casing the bidder code.
* New adapter "Coinzilla" added * Solved required modifications related to bidderRequest.referrerInfo.referer
* Changing to requestId in order to align with prebid cores mapping of bidId to responseId * Need to update in other events as well * Catching and logging no bid found * Lint error fix
* inprogress * add support for s2sConfig bidderOptions * merged missing updates from origin * changed arrow function in spec mocha tests to standard functions * fixed missing closing bracket and paren * updated incorrect spec expected values for s2sConfig tests * removed rubicon specific s2s configuration default value for sra * deleted unnecessary test and revised a test description since the rubicon specific defaults were removed * removed jsdoc for deprecated cookieSetUrl
prebid#3380) * Backward compatible update & reduced TTL * replaced deprecated getWindowTopLocation with referer detection module
* RAD-2356 Upgrade Mocha karma-webpack karma * RAD-2356 update readme to support node v6 or more * Remove webpack output logs while testing * move from gulp-webserver to gulp-connect * remove karma-require and redundant watch task
* Fix prebid#3265 - pbs cookie sync race condition * add/update jsdoc comments
Merged
|
This can be closed created a new PR with correct commits |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned here #3399, the fix attribute only manipulates the stream.
according the doc this is the way to modify the src;
and should auto format all code..which would mean, that if you don't want this special eslint comments should be used!