-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-gwapi-0.6] drop support for ReferencePolicy #4830
Merged
skriss
merged 2 commits into
projectcontour:dev-gwapi-0.6
from
skriss:pr-drop-referencepolicy
Nov 7, 2022
Merged
[dev-gwapi-0.6] drop support for ReferencePolicy #4830
skriss
merged 2 commits into
projectcontour:dev-gwapi-0.6
from
skriss:pr-drop-referencepolicy
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops support for ReferencePolicy, which has been replaced by ReferenceGrant in Gateway API. Updates projectcontour#4555. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added
the
release-note/deprecation
A deprecation or removal that needs about a paragraph of explanation in the release notes.
label
Nov 2, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4830 +/- ##
==========================================
+ Coverage 76.13% 76.27% +0.13%
==========================================
Files 139 139
Lines 16917 16886 -31
==========================================
Hits 12880 12880
+ Misses 3782 3752 -30
+ Partials 255 254 -1
|
sunjayBhatia
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, when we're able to un-draft this!
skriss
changed the title
drop support for ReferencePolicy
[dev-gwapi-0.6] drop support for ReferencePolicy
Nov 7, 2022
skriss
requested review from
tsaarni and
stevesloka
and removed request for
a team
November 7, 2022 17:39
Retargeted this to the |
sunjayBhatia
approved these changes
Nov 7, 2022
sunjayBhatia
pushed a commit
to sunjayBhatia/contour
that referenced
this pull request
Dec 14, 2022
Drops support for ReferencePolicy which has been replaced by ReferenceGrant in Gateway API. Updates projectcontour#4555. Signed-off-by: Steve Kriss <krisss@vmware.com>
sunjayBhatia
added a commit
that referenced
this pull request
Dec 14, 2022
* drop support for ReferencePolicy (#4830) Drops support for ReferencePolicy which has been replaced by ReferenceGrant in Gateway API. * update to latest Gateway API commit (#4839) - Update to v1beta1 ReferenceGrant - HTTPRequestHeaderFilter -> HTTPHeaderFilter - GatewayConditionScheduled -> GatewayConditionAccepted - ListenerConditionDetached -> ListenerConditionAccepted * updates for SupportedFeatures changes (#4844) * replace Gateway/Listener Ready conditions with Programmed (#4849) Replaces the "Ready" condition used for Gateways and Listeners with "Programmed". * update to Gateway API v0.6.0-rc1 (#4891) * Use generics for Gateway API pointer helpers (#4905) Can get rid of our existing gatewayapi package helpers for getting pointers to gateway api types based on primitive types Also found some more instances of v1alpha2 package being used where we should switch to v1beta1 Fixes #4555 Fixes #4699 Fixes #4848 Signed-off-by: Steve Kriss <krisss@vmware.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Steve Kriss <krisss@vmware.com>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
* drop support for ReferencePolicy (projectcontour#4830) Drops support for ReferencePolicy which has been replaced by ReferenceGrant in Gateway API. * update to latest Gateway API commit (projectcontour#4839) - Update to v1beta1 ReferenceGrant - HTTPRequestHeaderFilter -> HTTPHeaderFilter - GatewayConditionScheduled -> GatewayConditionAccepted - ListenerConditionDetached -> ListenerConditionAccepted * updates for SupportedFeatures changes (projectcontour#4844) * replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849) Replaces the "Ready" condition used for Gateways and Listeners with "Programmed". * update to Gateway API v0.6.0-rc1 (projectcontour#4891) * Use generics for Gateway API pointer helpers (projectcontour#4905) Can get rid of our existing gatewayapi package helpers for getting pointers to gateway api types based on primitive types Also found some more instances of v1alpha2 package being used where we should switch to v1beta1 Fixes projectcontour#4555 Fixes projectcontour#4699 Fixes projectcontour#4848 Signed-off-by: Steve Kriss <krisss@vmware.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Steve Kriss <krisss@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
* drop support for ReferencePolicy (projectcontour#4830) Drops support for ReferencePolicy which has been replaced by ReferenceGrant in Gateway API. * update to latest Gateway API commit (projectcontour#4839) - Update to v1beta1 ReferenceGrant - HTTPRequestHeaderFilter -> HTTPHeaderFilter - GatewayConditionScheduled -> GatewayConditionAccepted - ListenerConditionDetached -> ListenerConditionAccepted * updates for SupportedFeatures changes (projectcontour#4844) * replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849) Replaces the "Ready" condition used for Gateways and Listeners with "Programmed". * update to Gateway API v0.6.0-rc1 (projectcontour#4891) * Use generics for Gateway API pointer helpers (projectcontour#4905) Can get rid of our existing gatewayapi package helpers for getting pointers to gateway api types based on primitive types Also found some more instances of v1alpha2 package being used where we should switch to v1beta1 Fixes projectcontour#4555 Fixes projectcontour#4699 Fixes projectcontour#4848 Signed-off-by: Steve Kriss <krisss@vmware.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Steve Kriss <krisss@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
* drop support for ReferencePolicy (projectcontour#4830) Drops support for ReferencePolicy which has been replaced by ReferenceGrant in Gateway API. * update to latest Gateway API commit (projectcontour#4839) - Update to v1beta1 ReferenceGrant - HTTPRequestHeaderFilter -> HTTPHeaderFilter - GatewayConditionScheduled -> GatewayConditionAccepted - ListenerConditionDetached -> ListenerConditionAccepted * updates for SupportedFeatures changes (projectcontour#4844) * replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849) Replaces the "Ready" condition used for Gateways and Listeners with "Programmed". * update to Gateway API v0.6.0-rc1 (projectcontour#4891) * Use generics for Gateway API pointer helpers (projectcontour#4905) Can get rid of our existing gatewayapi package helpers for getting pointers to gateway api types based on primitive types Also found some more instances of v1alpha2 package being used where we should switch to v1beta1 Fixes projectcontour#4555 Fixes projectcontour#4699 Fixes projectcontour#4848 Signed-off-by: Steve Kriss <krisss@vmware.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/deprecation
A deprecation or removal that needs about a paragraph of explanation in the release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for ReferencePolicy, which
has been replaced by ReferenceGrant in
Gateway API.
Updates #4555.
Signed-off-by: Steve Kriss krisss@vmware.com
Leaving as draft until #4738 is unblocked.