Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-gwapi-0.6] drop support for ReferencePolicy #4830

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented Nov 2, 2022

Drops support for ReferencePolicy, which
has been replaced by ReferenceGrant in
Gateway API.

Updates #4555.

Signed-off-by: Steve Kriss krisss@vmware.com

Leaving as draft until #4738 is unblocked.

Drops support for ReferencePolicy, which
has been replaced by ReferenceGrant in
Gateway API.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss added the release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. label Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #4830 (42b9381) into main (e700127) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4830      +/-   ##
==========================================
+ Coverage   76.13%   76.27%   +0.13%     
==========================================
  Files         139      139              
  Lines       16917    16886      -31     
==========================================
  Hits        12880    12880              
+ Misses       3782     3752      -30     
+ Partials      255      254       -1     
Impacted Files Coverage Δ
cmd/contour/serve.go 12.86% <ø> (+0.05%) ⬆️
internal/dag/cache.go 94.10% <ø> (+1.72%) ⬆️
internal/dag/gatewayapi_processor.go 96.61% <100.00%> (+1.88%) ⬆️
...ovisioner/objects/rbac/clusterrole/cluster_role.go 80.59% <100.00%> (ø)
internal/provisioner/controller/gatewayclass.go 56.98% <0.00%> (+0.23%) ⬆️

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, when we're able to un-draft this!

@skriss skriss changed the base branch from main to dev-gwapi-0.6 November 7, 2022 17:38
@skriss skriss changed the title drop support for ReferencePolicy [dev-gwapi-0.6] drop support for ReferencePolicy Nov 7, 2022
@skriss skriss marked this pull request as ready for review November 7, 2022 17:39
@skriss skriss requested a review from a team as a code owner November 7, 2022 17:39
@skriss skriss requested review from tsaarni and stevesloka and removed request for a team November 7, 2022 17:39
@skriss
Copy link
Member Author

skriss commented Nov 7, 2022

Retargeted this to the dev-gwapi-0.6 branch for now.

@skriss skriss merged commit 6e469c9 into projectcontour:dev-gwapi-0.6 Nov 7, 2022
sunjayBhatia pushed a commit to sunjayBhatia/contour that referenced this pull request Dec 14, 2022
Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
sunjayBhatia added a commit that referenced this pull request Dec 14, 2022
* drop support for ReferencePolicy (#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (#4844)

* replace Gateway/Listener Ready conditions with Programmed (#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (#4891)

* Use generics for Gateway API pointer helpers (#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes #4555 
Fixes #4699 
Fixes #4848 

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
@skriss skriss deleted the pr-drop-referencepolicy branch January 31, 2023 19:19
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this pull request Feb 28, 2023
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555 
Fixes projectcontour#4699 
Fixes projectcontour#4848 

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants