Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gateway API to 0.6.0-rc.1 #4929

Merged
merged 7 commits into from
Dec 14, 2022

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Dec 14, 2022

Includes:

Fixes #4555
Fixes #4699
Fixes #4848

skriss and others added 7 commits December 14, 2022 20:56
Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

Updates projectcontour#4555.
Updates projectcontour#4738.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
…tour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

Updates projectcontour#4848.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner December 14, 2022 21:38
@sunjayBhatia sunjayBhatia requested review from stevesloka and skriss and removed request for a team December 14, 2022 21:38
@sunjayBhatia
Copy link
Member Author

considering leaving this as no-release note so we can add a release note to summarize GW API changes when we finally update to 0.6.0 if that works?

@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Dec 14, 2022
@skriss
Copy link
Member

skriss commented Dec 14, 2022

considering leaving this as no-release note so we can add a release note to summarize GW API changes when we finally update to 0.6.0 if that works?

Yeah sounds good to me!

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #4929 (a616511) into main (ee13679) will increase coverage by 0.33%.
The diff coverage is 87.96%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4929      +/-   ##
==========================================
+ Coverage   76.02%   76.36%   +0.33%     
==========================================
  Files         139      140       +1     
  Lines       16882    16676     -206     
==========================================
- Hits        12835    12734     -101     
+ Misses       3793     3691     -102     
+ Partials      254      251       -3     
Impacted Files Coverage Δ
cmd/contour/serve.go 12.86% <0.00%> (+0.05%) ⬆️
internal/controller/gateway.go 13.10% <0.00%> (ø)
internal/status/routeconditions.go 56.47% <0.00%> (ø)
internal/provisioner/controller/gateway.go 60.00% <66.66%> (ø)
internal/gatewayapi/helpers.go 84.54% <94.44%> (+12.80%) ⬆️
internal/dag/gatewayapi_processor.go 96.61% <98.24%> (+1.88%) ⬆️
internal/dag/cache.go 94.08% <100.00%> (+1.72%) ⬆️
internal/dag/policy.go 94.22% <100.00%> (ø)
internal/gatewayapi/listeners.go 100.00% <100.00%> (ø)
internal/k8s/statusaddress.go 80.11% <100.00%> (ø)
... and 4 more

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@sunjayBhatia sunjayBhatia merged commit e7a8a0d into projectcontour:main Dec 14, 2022
@sunjayBhatia sunjayBhatia deleted the dev-gwapi-0.6-rebased branch December 14, 2022 22:21
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this pull request Feb 28, 2023
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555 
Fixes projectcontour#4699 
Fixes projectcontour#4848 

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
2 participants