Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict upload of files other than images(jpeg,png etc) #364

Closed
vsk4 opened this issue Oct 1, 2018 · 8 comments
Closed

Restrict upload of files other than images(jpeg,png etc) #364

vsk4 opened this issue Oct 1, 2018 · 8 comments

Comments

@vsk4
Copy link
Member

vsk4 commented Oct 1, 2018

In image-sequencer only image type files types must be uploaded,all other file types like pdf, JS, .md files must be ignored/rejected.
while uploading a gif the uploaded gif is broken. please refer to the screenshots/gif attached.

screen shot 2018-10-01 at 7 46 32 pm
20181001-074034
screen shot 2018-10-01 at 7 44 56 pm

What to be done : -
while uploading restrict all the files other than image format files.This is the best fix for this issue.

@gitmate
Copy link

gitmate bot commented Oct 1, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #356 ('No file chosen' wrongly placed in Import Image module), #31 (Issue with non-JPEG images also affecting alpha channel), and #5 (image cropping module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 1, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #356 ('No file chosen' wrongly placed in Import Image module), #31 (Issue with non-JPEG images also affecting alpha channel), and #5 (image cropping module).

@gitmate gitmate bot added the bug label Oct 1, 2018
@avsingh999
Copy link
Member

@vsk4 great catch

@aashna27
Copy link

aashna27 commented Oct 1, 2018

@avsingh999 can I be assigned this? I would like to work on this

@aashna27
Copy link

aashna27 commented Oct 1, 2018

@avsingh999 please review.

jywarren pushed a commit that referenced this issue Oct 10, 2018
* added gif feature

* increased frame duration n changed gif btn name

* removed inline css

* improved ui

* #363 Add placeholder option to input (#370)

* Add placeholder option to input , change type of brightness input to number

 Changes to be committed:
	modified:   examples/lib/defaultHtmlStepUi.js
	modified:   src/modules/Brightness/info.json

* change 0% to 0 in brightness placeholder

* Add gamma module (#374)

* Add gamma module

* update description

* Add matrix math module (#358)

* Add matrix math module

* add info.json file

* correct format of module

* Add a constant factor input field

* clone the pixels array

* change default values

* add extra information on convolution module (#381)

* adds default values to input fields for all module steps ( fixes #382 ) (#384)

* added default values to input fields for all module steps

* merged

Signed-off-by: Ankit Singla <asingla590@gmail.com>

* Accept type images in input field #364 (#366)

* gif button name changed

* fixes #383 (#396)

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* fix (#387)

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* updated

* Issue #392 Fixes alignment of message in Add step box (#393)

*  Fixes alignment of message in Add step box

* fixes css info id

* updates class selector in demo

* Spacing changes

* correctly regulates the behaviour of all links (#397)

Signed-off-by: Ankit Singla <asingla590@gmail.com>

* enables Save button for an action if any of its input fields gain focus (#394)

* Updated index.html (#379)

* add histogram module (#354)

* add histogram module

Signed-off-by: tech4GT <varun.gupta1798@gmail.com>

* add option to drop gradient

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>

* fix bug

Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>
@AmanGarg97
Copy link

Hey @jywarren can I start working on this if this issue is not resolved?

@jywarren
Copy link
Member

I think it's complete, @aashna27 can you confirm? Thanks!!!

@aashna27
Copy link

Yes it is, the pr might not have referenced this issue. But it has been done. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants