adds default values to input fields for all module steps ( fixes #382 ) #384
Conversation
Signed-off-by: Ankit Singla <asingla590@gmail.com>
|
@jywarren let's merge this one in! |
|
🎉 👍 👍 👍 |
|
publishing it too! we'll need a new version number pretty soon! |
|
@Ankit-Singla this is great. Would you want to take a look at this one too? It is UI centric and I think would be really cool to see: #247 Just in case it catches your eye! 🙌 |
|
Ah, oops! The defaults are great, but they override the URL-specified values! Take a look: https://publiclab.github.io/image-sequencer/examples/#steps=convolution{constantFactor:0.1111111111111111|kernelValues:0 -1 0 -1 5 -1 0 -1 0} These are then overridden by the defaults :-( Would you mind taking a look? unfortunately this is not live on the demo! Thank you! |
|
Aha! I’ll see this!! Silly me!! |
|
@Ankit-Singla the thing is that the input values that are taken from the url are being overriden by the value parameter, I'll figure this out!! Thanks for all the help!! |
* added gif feature * increased frame duration n changed gif btn name * removed inline css * improved ui * #363 Add placeholder option to input (#370) * Add placeholder option to input , change type of brightness input to number Changes to be committed: modified: examples/lib/defaultHtmlStepUi.js modified: src/modules/Brightness/info.json * change 0% to 0 in brightness placeholder * Add gamma module (#374) * Add gamma module * update description * Add matrix math module (#358) * Add matrix math module * add info.json file * correct format of module * Add a constant factor input field * clone the pixels array * change default values * add extra information on convolution module (#381) * adds default values to input fields for all module steps ( fixes #382 ) (#384) * added default values to input fields for all module steps * merged Signed-off-by: Ankit Singla <asingla590@gmail.com> * Accept type images in input field #364 (#366) * gif button name changed * fixes #383 (#396) Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com> * fix (#387) Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com> * updated * Issue #392 Fixes alignment of message in Add step box (#393) * Fixes alignment of message in Add step box * fixes css info id * updates class selector in demo * Spacing changes * correctly regulates the behaviour of all links (#397) Signed-off-by: Ankit Singla <asingla590@gmail.com> * enables Save button for an action if any of its input fields gain focus (#394) * Updated index.html (#379) * add histogram module (#354) * add histogram module Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * add option to drop gradient Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com> * fix bug Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>
Provides default input values in input of all step modules to indicate the input values on which the module step is running. This also provides a function signature for inputs that require a function.