Add gamma module #374
Add gamma module #374
Conversation
|
This is a screenshot of the output with gamma = 0.2 :
|
|
Wow, very cool! Maybe add a link to Wikipedia's page on Gamma to the description? @tech4GT what do you think of this? 👍 |
src/modules/Gamma/info.json
Outdated
| "inputs": { | ||
| "adjustment": { | ||
| "type": "float", | ||
| "desc": "gamma correction for the new image", |
There was a problem hiding this comment.
Just to be extra clear let's also mention this is inverse of the actual gamma.
There was a problem hiding this comment.
I will change the module name to Gamma Correction and also add a link to Wikipedia's page on Gamma to the description. Thanks!
I didn't quite get 'inverse of the actual gamma'. I think it is gamma, how is this inverse of the actual gamma? Sorry.
There was a problem hiding this comment.
Oh Actually the gamma correction is the inverse of the actual gamma factor, so just to be extra clear I was thinking maybe we should mention that this is the gamma correction, inverse of the actual gamma factor. Thanks!
There was a problem hiding this comment.
Oh okay, I will do that! Thanks!
|
I have made the changes. Please have a look! |
|
Great :-) 👍 👍 👍 Now that @Mridul97 knows the module format, they can help other people get their modules into the right format! One thing that can help is to have a "Saved reply" which links to the module docs. https://github.com/settings/replies It could have a friendly message and link to: https://github.com/publiclab/image-sequencer/blob/master/CONTRIBUTING.md Actually we could also have a pull request template linking to that as well! See some of the templates we can install here: |
* added gif feature * increased frame duration n changed gif btn name * removed inline css * improved ui * #363 Add placeholder option to input (#370) * Add placeholder option to input , change type of brightness input to number Changes to be committed: modified: examples/lib/defaultHtmlStepUi.js modified: src/modules/Brightness/info.json * change 0% to 0 in brightness placeholder * Add gamma module (#374) * Add gamma module * update description * Add matrix math module (#358) * Add matrix math module * add info.json file * correct format of module * Add a constant factor input field * clone the pixels array * change default values * add extra information on convolution module (#381) * adds default values to input fields for all module steps ( fixes #382 ) (#384) * added default values to input fields for all module steps * merged Signed-off-by: Ankit Singla <asingla590@gmail.com> * Accept type images in input field #364 (#366) * gif button name changed * fixes #383 (#396) Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com> * fix (#387) Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com> * updated * Issue #392 Fixes alignment of message in Add step box (#393) * Fixes alignment of message in Add step box * fixes css info id * updates class selector in demo * Spacing changes * correctly regulates the behaviour of all links (#397) Signed-off-by: Ankit Singla <asingla590@gmail.com> * enables Save button for an action if any of its input fields gain focus (#394) * Updated index.html (#379) * add histogram module (#354) * add histogram module Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * add option to drop gradient Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com> * fix bug Signed-off-by: Varun Gupta <varun.gupta1798@gmail.com>
Issue #368
Changes : A module is added which applies gamma correction on an image and takes gamma as an input.