Change "Save" to "Apply" on save button in add step UI

[Rishabh570]

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

First Timers Only

Hi, this is a first-timers-only issue. This means this has been worked to make it more legible to folks who either haven't contributed to our codebase before or even folks who haven't contributed to open source before.

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

The Problem

Save button on a new step should have text on it saying: Apply instead of Save

Currently, it looks like,

The Solution

This line in examples/lib/defaultHtmlStepUi.js would be updated in order to do the required changes.

- "<p><button class='btn btn-default btn-save' disabled = 'true' >Save</button><span> Press save to see changes</span></p>"
+ "<p><button class='btn btn-default btn-save' disabled = 'true' >Apply</button><span> Press save to see changes</span></p>"

It would look like this,

Instance Count = 1

[welcome]

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

[gitmate]

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #466 (Add an "insert step" button on each step UI), #395 (Disable the Save Sequence button until one step is added), #302 (Disable/dim the Save button until step inputs have been changed), #348 (Improve Images step Ui), and #471 (Change Gif to GIF in 'View Gif' button.).

[gitmate]

GitMate.io thinks the contributors most likely able to help are @tech4GT, @SidharthBansal, and @GitMate[bot].

Possibly related issues are #466 (Add an "insert step" button on each step UI), #395 (Disable the Save Sequence button until one step is added), #302 (Disable/dim the Save button until step inputs have been changed), #348 (Improve Images step Ui), and #471 (Change Gif to GIF in 'View Gif' button.).

[rajcrk]

I would like to work on this issue.
Getting on it right now.

[harshkhandeparkar]

@Rishabh570
I feel like the text besides it should also change to "press apply to see changes" or simply "press to see changes"

[jywarren]

Agreed!

…

On Thu, Nov 22, 2018, 10:52 AM HarshKhandeparkar ***@***.*** wrote: I feel like the text besides it should also change to "press apply to see changes" or simply "press to see changes" — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#489 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ_vngMQQ_-dCS4OLZ7k8Bm-kiUCLks5uxsgKgaJpZM4Yvk-k> .

[Rishabh570]

@harshkhandeparkar Yess...

[oorjitchowdhary]

Is anyone working on this... I'd like to work on this issue

[Paarmita]

@oorjitchowdhary I guess @rajcrk is working on this. You can see other first time issues.

[jonxuxu]

@rajcrk would you like help on this issue?

[oorjitchowdhary]

@rajcrk are you still working on this? if not, @publiclab/mentors can I take this up?

[aashna27]

Since this is a first timer issue I would suggest you to move on with some other as you have already helped solve many other issues and let it be for someone new. :-)
@oorjitchowdhary

[oorjitchowdhary]

@aashna27 Okay sure.. 😃

[tech4GT]

I think this was solved, closing this now! Thanks everyone! 😄