forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Meta modules and add inputs to ndvi-colormap #1432
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2c02c27
fix meta module bug
rishabhshuklax 4509b87
Merge branch 'main' into create-meta-module
rishabhshuklax 8c6486a
fix create meta module and add inputs to ndvi-colormap
rishabhshuklax de0301a
Merge branch 'main' into meta-modules
rishabhshuklax 5cbe9f7
Merge branch 'main' into meta-modules
harshkhandeparkar c360015
Merge branch 'main' into meta-modules
jywarren 425b531
Merge branch 'main' into meta-modules
jywarren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,24 @@ | ||
{ | ||
"name": "ndvi-colormap", | ||
"description": "Sequentially Applies NDVI and Colormap steps", | ||
"inputs": {}, | ||
"inputs": { | ||
"filter": { | ||
"type": "select", | ||
"desc": "Filter color", | ||
"default": "red", | ||
"values": ["red", "blue"] | ||
}, | ||
"colormap": { | ||
"type": "select", | ||
"desc": "Name of the Colormap", | ||
"default": "default", | ||
"values": [ | ||
"default", | ||
"greyscale", | ||
"stretched", | ||
"fastie" | ||
] | ||
} | ||
}, | ||
"docs-link": "https://github.com/publiclab/image-sequencer/blob/main/docs/MODULES.md#ndvi-colormap-module" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,11 +16,6 @@ module.exports = function createMetaModule(mapFunction, moduleOptions) { | |
} | ||
} | ||
|
||
// map inputs to internal step options; | ||
// use this to set defaults for internal steps | ||
// and to expose internal settings as external meta-module parameters; | ||
// it must return a steps object | ||
var steps = mapFunction(options); | ||
|
||
/* example: | ||
function mapFunction(opt, _defaults) { | ||
|
@@ -40,7 +35,13 @@ module.exports = function createMetaModule(mapFunction, moduleOptions) { | |
function draw(input, callback) { | ||
|
||
var step = this; | ||
|
||
|
||
// map inputs to internal step options; | ||
// use this to set defaults for internal steps | ||
// and to expose internal settings as external meta-module parameters; | ||
// it must return a steps object | ||
var steps = mapFunction(options); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @tech4GT can you check this change of scope? Thank you! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Linking to explanation: #1239 (comment) |
||
|
||
var internalSequencer = ImageSequencer({ inBrowser: false, ui: false }); | ||
internalSequencer.loadImage(input.src, function onAddImage() { | ||
internalSequencer.importJSON(steps); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. That's a big fix. Very important.