feat: Add extra options #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simenandre
commented
Mar 16, 2021
| @@ -4,8 +4,7 @@ | |||
| "plugin:@typescript-eslint/eslint-recommended", | |||
| "plugin:@typescript-eslint/recommended", | |||
| "plugin:jest/recommended", | |||
| "prettier", | |||
| "prettier/@typescript-eslint" | |||
| "prettier" | |||
There was a problem hiding this comment.
prettier/@typescript-eslint has been merged into prettier in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
simenandre
commented
Mar 16, 2021
| parallel: 3 | ||
| message: this-is-just-a-test | ||
| expect-no-changes: false | ||
| diff: true |
There was a problem hiding this comment.
Missing target and targetDependents due to the small test stack 🤷♂️
stack72
reviewed
Mar 17, 2021
| - `comment-on-pr` - (optional) If `true`, then the action will add the results | ||
| of the Pulumi action to the PR | ||
|
|
||
| - `github-token` - (required if comment-on-pr) A GitHub token that has access | ||
| levels to allow the Action to comment on a PR. | ||
|
|
||
| ### Extra options |
There was a problem hiding this comment.
We should add a small comment here to suggest that these extra options, are the equivalent of the command line args
stack72
approved these changes
Mar 17, 2021
| parallel: | ||
| description: 'Allow P resource operations to run in parallel at once (1 for no parallelism). Defaults to unbounded.' | ||
| required: false | ||
| default: '2147483647' |
There was a problem hiding this comment.
this relates to what the automation api does - this isn't actually the number we pass, this is to document what we can do
* master: ci: Automatically update dist files on every push (#119) feat: Add `upsert` option (#118) chore(deps-dev): bump eslint-plugin-jest from 24.3.1 to 24.3.2 (#120) chore(deps-dev): bump @typescript-eslint/eslint-plugin from 4.17.0 to 4.18.0 (#116) chore(deps-dev): bump @typescript-eslint/parser from 4.17.0 to 4.18.0 (#115) chore(deps-dev): bump @types/node from 14.14.34 to 14.14.35 (#114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #88
Note:
argsis removed.