Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 688: Making the buffer protocol accessible in Python #102500

Closed
JelleZijlstra opened this issue Mar 7, 2023 · 1 comment
Closed

Implement PEP 688: Making the buffer protocol accessible in Python #102500

JelleZijlstra opened this issue Mar 7, 2023 · 1 comment
Assignees
@JelleZijlstra
Labels
3.12 bugs and security fixes topic-typing type-feature A feature request or enhancement

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 7, 2023 •
edited by AlexWaygood
Loading

PEP-688 has just been accepted. I will use this issue to track its implementation in CPython.

Linked PRs
@JelleZijlstra JelleZijlstra added type-feature A feature request or enhancement 3.12 bugs and security fixes labels Mar 7, 2023
@JelleZijlstra JelleZijlstra self-assigned this Mar 7, 2023
This was referenced Mar 8, 2023
Merged
Merged
@AlexWaygood AlexWaygood mentioned this issue Mar 15, 2023
Closed
JelleZijlstra added a commit that referenced this issue May 4, 2023
@JelleZijlstra @kumaraditya303
gh-102500: Implement PEP 688 (#102521)
04f6733 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
JelleZijlstra added a commit that referenced this issue May 4, 2023
@JelleZijlstra @hugovk @hauntsaninja
gh-102500: Document PEP 688 (#102571)
b7a0a52 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@JelleZijlstra
Copy link
Member Author

All done!

@bedevere-bot bedevere-bot mentioned this issue May 4, 2023
Merged
hugovk added a commit that referenced this issue May 4, 2023
@hugovk
gh-102500: Add PEP 688 and 698 to the 3.12 release highlights (#104174)
d47cddf
carljm added a commit to carljm/cpython that referenced this issue May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue May 8, 2023
@hauntsaninja
pythongh-102500: Remove mention of bytes shorthand
e807bce 
The bytes shorthand was removed in PEP 688:
https://peps.python.org/pep-0688/#no-special-meaning-for-bytes

I also remove the reference to `collections.abc.ByteString`, since that
object is deprecated (python#91896) and has different semantics (python#102092)

I think it would be good to backport this since the changes in the type
system are immediate and apply to all versions of Python.
@bedevere-bot bedevere-bot mentioned this issue May 8, 2023
Merged
AlexWaygood pushed a commit that referenced this issue May 8, 2023
@hauntsaninja
gh-102500: Remove mention of bytes shorthand (#104281)
1f56795 
The bytes shorthand was removed in PEP 688:
https://peps.python.org/pep-0688/#no-special-meaning-for-bytes

I also remove the reference to `collections.abc.ByteString`, since that
object is deprecated (#91896) and has different semantics (#102092)
@bedevere-bot bedevere-bot mentioned this issue May 8, 2023
Merged
AlexWaygood pushed a commit to AlexWaygood/cpython that referenced this issue May 8, 2023
@hauntsaninja @AlexWaygood
pythongh-102500: Remove mention of bytes shorthand (python#104281)
4d49df3 
The bytes shorthand was removed in PEP 688:
https://peps.python.org/pep-0688/#no-special-meaning-for-bytes

I also remove the reference to `collections.abc.ByteString`, since that
object is deprecated (python#91896) and has different semantics (python#102092)
AlexWaygood added a commit that referenced this issue May 8, 2023
@AlexWaygood @hauntsaninja
[3.11] gh-102500: Remove mention of bytes shorthand (#104281) (#104288)
499b79d 
gh-102500: Remove mention of bytes shorthand (#104281)

The bytes shorthand was removed in PEP 688:
https://peps.python.org/pep-0688/#no-special-meaning-for-bytes

The reference to collections.abc.ByteString is also removed, since that object is deprecated (#91896) and has different semantics (#102092)

Although PEP 688 is new in Python 3.12, type checkers are expected to implement the new semantics for type annotations even if users are using an older version of Python, so this docs PR is backported to Python 3.11.

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
jbower-fb pushed a commit to jbower-fb/cpython-jbowerfb that referenced this issue May 8, 2023
@hauntsaninja @jbower-fb
pythongh-102500: Remove mention of bytes shorthand (python#104281)
013469f 
The bytes shorthand was removed in PEP 688:
https://peps.python.org/pep-0688/#no-special-meaning-for-bytes

I also remove the reference to `collections.abc.ByteString`, since that
object is deprecated (python#91896) and has different semantics (python#102092)
carljm added a commit to carljm/cpython that referenced this issue May 9, 2023
@carljm
Merge branch 'main' into inlinecomp2
76077cd 
* main: (47 commits)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)
  pythongh-103193: Improve `getattr_static` test coverage (python#104286)
  Trim trailing whitespace and test on CI (python#104275)
  pythongh-102500: Remove mention of bytes shorthand (python#104281)
  pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)
  pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)
  pythongh-104273: Remove redundant len() calls in argparse function (python#104274)
  pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200)
  pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266)
  pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244)
  pythongh-103650: Fix perf maps address format (python#103651)
  pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243)
  ...
hauntsaninja added a commit to hauntsaninja/cpython that referenced this issue May 9, 2023
@hauntsaninja
[3.11] pythongh-102500: collections.abc.Buffer doesn't exist in 3.11
2547efd
@bedevere-bot bedevere-bot mentioned this issue May 9, 2023
Merged
AlexWaygood pushed a commit that referenced this issue May 9, 2023
@hauntsaninja
[3.11] gh-102500: collections.abc.Buffer doesn't exist in 3.11 (#104317)
15624b4
carljm added a commit to carljm/cpython that referenced this issue May 9, 2023
@carljm
Merge branch 'main' into fixsendfamily
a614216 
* main: (29 commits)
  pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)
  pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)
  pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320)
  require-pr-label.yml: Add missing "permissions:" (python#104309)
  pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)
  pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)
  pythongh-103193: Improve `getattr_static` test coverage (python#104286)
  Trim trailing whitespace and test on CI (python#104275)
  pythongh-102500: Remove mention of bytes shorthand (python#104281)
  pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)
  pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)
  ...
AlexWaygood added a commit to AlexWaygood/cpython that referenced this issue May 12, 2023
@AlexWaygood
pythongh-102500: Fixup some docs issues following ByteString deprecation
efc9106
@bedevere-bot bedevere-bot mentioned this issue May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JelleZijlstra JelleZijlstra

Labels
3.12 bugs and security fixes topic-typing type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JelleZijlstra