Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTHREAD_SCOPE_SYSTEM configure check fails with Clang 16 (-Wimplicit-int) #99086

Closed
thesamesam opened this issue Nov 4, 2022 · 5 comments
Closed
Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@thesamesam
Copy link
Contributor

thesamesam commented Nov 4, 2022

Bug report

The PTHREAD_SCOPE_SYSTEM configure check lacks int before the main() definition and causes Clang to emit a -Wimplicit-int warning. This warning becomes an error by default with Clang 16+.

Your environment

  • CPython versions tested on: master
  • Operating system and architecture: Gentoo Linux amd64
  • Clang 16 (or Clang 15 with -Werror=implicit-int -Werror=implicit-function-declaration)
@thesamesam thesamesam added the type-bug An unexpected behavior, bug, or error label Nov 4, 2022
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 4, 2022
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 4, 2022
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 4, 2022
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
@kumaraditya303 kumaraditya303 added 3.11 only security fixes 3.10 only security fixes 3.12 bugs and security fixes build The build process and cross-build labels Nov 4, 2022
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this issue Nov 5, 2022
… check for PTHREAD_SCOPE_SYSTEM (pythonGH-99085)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this issue Nov 5, 2022
… check for PTHREAD_SCOPE_SYSTEM (pythonGH-99085)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>
erlend-aasland added a commit that referenced this issue Nov 5, 2022
… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99118)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>
erlend-aasland added a commit that referenced this issue Nov 6, 2022
… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99119)

(cherry picked from commit 12078e7)

Co-authored-by: Sam James <sam@cmpct.info>

Co-authored-by: Sam James <sam@cmpct.info>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 12, 2022
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 12, 2022
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 12, 2022
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 24, 2022
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
Signed-off-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Nov 24, 2022
…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7
kumaraditya303 pushed a commit that referenced this issue Nov 26, 2022
thesamesam added a commit to thesamesam/cpython that referenced this issue Dec 1, 2022
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)
thesamesam added a commit to thesamesam/cpython that referenced this issue Dec 1, 2022
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
thesamesam added a commit to thesamesam/cpython that referenced this issue Dec 1, 2022
…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7..
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
miss-islington pushed a commit that referenced this issue Dec 1, 2022
GH-99919)

…tion warnings in configure.ac (GH-99406)

Follow up to 12078e7. (cherry picked from commit e35ca41)
hroncok pushed a commit to fedora-python/cpython that referenced this issue Mar 7, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
stratakis pushed a commit to stratakis/cpython that referenced this issue Mar 11, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
stratakis pushed a commit to stratakis/cpython that referenced this issue Mar 11, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
stratakis pushed a commit to stratakis/cpython that referenced this issue Mar 20, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
hrnciar pushed a commit to fedora-python/cpython that referenced this issue Mar 20, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
hrnciar pushed a commit to fedora-python/cpython that referenced this issue Mar 20, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
stratakis pushed a commit to stratakis/cpython that referenced this issue Mar 20, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
stratakis pushed a commit to stratakis/cpython that referenced this issue Mar 20, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
stratakis pushed a commit to stratakis/cpython that referenced this issue Mar 20, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
stratakis pushed a commit to stratakis/cpython that referenced this issue Mar 25, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
hroncok pushed a commit to fedora-python/cpython that referenced this issue Mar 26, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue Apr 2, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue Apr 10, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: pythongh-99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue Apr 11, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: pythongh-99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue Apr 11, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: gh#python#99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue Apr 11, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: gh#python#99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue Apr 11, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: gh#python#99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue May 16, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: gh#python#99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue May 16, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: gh#python#99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue May 21, 2024
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue May 21, 2024
…eclara… (python#99920)

[3.10] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue May 21, 2024
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue May 21, 2024
…eclara… (python#99920)

[3.10] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
hrnciar pushed a commit to fedora-python/cpython that referenced this issue Sep 9, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
hrnciar pushed a commit to fedora-python/cpython that referenced this issue Sep 9, 2024
… check for PTHREAD_SCOPE_SYSTEM

Co-authored-by: Sam James <sam@cmpct.info>
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue Sep 19, 2024
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue Sep 19, 2024
…eclara… (python#99920)

[3.10] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue Sep 19, 2024
…ck (python#99085)

Clang 16 makes -Wimplicit-int fatal by default.

Avoids errors like:
```
conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
```

Signed-off-by: Sam James <sam@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this issue Sep 19, 2024
…eclara… (python#99920)

[3.10] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>
mcepl pushed a commit to openSUSE-Python/cpython that referenced this issue Oct 9, 2024
…E_SYSTEM

Code is from gh#python/cpython!99085 (released upstream in 3.10.9)

Co-authored-by: Sam James <sam@cmpct.info>
Fixes: gh#python#99086
Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants