PTHREAD_SCOPE_SYSTEM configure check fails with Clang 16 (-Wimplicit-int) #99086

thesamesam · 2022-11-04T03:00:22Z

Bug report

The PTHREAD_SCOPE_SYSTEM configure check lacks int before the main() definition and causes Clang to emit a -Wimplicit-int warning. This warning becomes an error by default with Clang 16+.

Your environment

CPython versions tested on: master
Operating system and architecture: Gentoo Linux amd64
Clang 16 (or Clang 15 with -Werror=implicit-int -Werror=implicit-function-declaration)

PR: gh-99086: Fix implicit int warning in configure check for PTHREAD_SCOPE_SYSTEM (#99085) #99085

PR: [3.11] gh-99086: Fix implicit int compiler warning in configure check for PTHREAD_SCOPE_SYSTEM (GH-99085) #99118

PR: [3.10] gh-99086: Fix implicit int compiler warning in configure check for PTHREAD_SCOPE_SYSTEM (GH-99085) #99119

PR: gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac #99406

PR: [3.11] gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declara… #99919

PR: [3.10] GH-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declara… #99920

The text was updated successfully, but these errors were encountered:

…ck (python#99085) Clang 16 makes -Wimplicit-int fatal by default. Avoids errors like: ``` conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] ``` Signed-off-by: Sam James <sam@gentoo.org>

…HREAD_SCOPE_SYSTEM (#99085)

… check for PTHREAD_SCOPE_SYSTEM (pythonGH-99085) (cherry picked from commit 12078e7) Co-authored-by: Sam James <sam@cmpct.info>

… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99118) (cherry picked from commit 12078e7) Co-authored-by: Sam James <sam@cmpct.info>

… for PTHREAD_SCOPE_SYSTEM (GH-99085) (#99119) (cherry picked from commit 12078e7) Co-authored-by: Sam James <sam@cmpct.info> Co-authored-by: Sam James <sam@cmpct.info>

…aration fixes Followup to 12078e7. I ended up missing a few, apparently. Clang 16 makes -Wimplicit-function-declaration an error by default and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes while we're here and it futureproofs us, so throw that in. The only notable part of this which might not be super obvious is <stddef.h> for size_t. See: 12078e7 Signed-off-by: Sam James <sam@gentoo.org>

…aration fixes Followup to 12078e7. I ended up missing a few, apparently. Clang 16 makes -Wimplicit-function-declaration an error by default and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes while we're here and it futureproofs us, so throw that in. The only notable part of this which might not be super obvious is <stddef.h> for size_t. See: 12078e7

…rnings in configure.ac (#99406) Follow up to 12078e7.

…eclaration warnings in configure.ac (pythonGH-99406) Follow up to 12078e7. (cherry picked from commit e35ca41)

…eclaration warnings in configure.ac (pythonGH-99406) Follow up to 12078e7. (cherry picked from commit e35ca41) Co-authored-by: Sam James <sam@gentoo.org>

…eclaration warnings in configure.ac (pythonGH-99406) Follow up to 12078e7.. (cherry picked from commit e35ca41) Co-authored-by: Sam James <sam@gentoo.org>

GH-99919) …tion warnings in configure.ac (GH-99406) Follow up to 12078e7. (cherry picked from commit e35ca41)

… check for PTHREAD_SCOPE_SYSTEM Co-authored-by: Sam James <sam@cmpct.info>

…E_SYSTEM Code is from gh#python/cpython!99085 (released upstream in 3.10.9) Co-authored-by: Sam James <sam@cmpct.info> Fixes: pythongh-99086 Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch

…E_SYSTEM Code is from gh#python/cpython!99085 (released upstream in 3.10.9) Co-authored-by: Sam James <sam@cmpct.info> Fixes: gh#python#99086 Patch: PTHREAD_SCOPE_SYSTEM-int-warning.patch

…ck (python#99085) Clang 16 makes -Wimplicit-int fatal by default. Avoids errors like: ``` conftest.c:142:7: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int] ``` Signed-off-by: Sam James <sam@gentoo.org>

…eclara… (python#99920) [3.10] pythongh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac (pythonGH-99406) Follow up to 12078e7. (cherry picked from commit e35ca41) Co-authored-by: Sam James <sam@gentoo.org>