GH-100982: Add COMPARE_AND_BRANCH instruction
#100983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Jan 12, 2023
•
markshannon
commented
- Issue: Specialization of some instructions does not conform to PEP 659, and prevents PEP 669 #100982
iritkatriel
reviewed
Jan 12, 2023
| @@ -189,7 +189,8 @@ def pseudo_op(name, op, real_ops): | |||
| def_op('DELETE_DEREF', 139) | |||
| hasfree.append(139) | |||
| jrel_op('JUMP_BACKWARD', 140) # Number of words to skip (backwards) | |||
|
|
|||
| def_op('COMPARE_AND_BRANCH', 141) # Comparison and jump | |||
| hascompare.append(141) | |||
There was a problem hiding this comment.
This opcode needs to be in hasjrel as well.
There was a problem hiding this comment.
The problem is that dis sees COMPARE_AND_BRANCH, then POP_JUMP_IF_. The POP_JUMP_IF_ is where we jump from.
So marking COMPARE_AND_BRANCH as a jump confuses dis, it thinks the operator is a jump offset. COMPARE_AND_BRANCH is effectively a superinstruction.
I could special case COMPARE_AND_BRANCH in dis, but I think it might be better to wait for proper support for longer instructions.
iritkatriel
approved these changes
Jan 16, 2023
iritkatriel
reviewed
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.