Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-100982: Add
COMPARE_AND_BRANCH
instruction #100983GH-100982: Add
COMPARE_AND_BRANCH
instruction #100983Changes from 4 commits
e5059b2
482777c
358393d
c5c1764
944147c
ef3fe45
447f63e
7d33508
776ba54
5b01cc5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This opcode needs to be in hasjrel as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that
dis
seesCOMPARE_AND_BRANCH
, thenPOP_JUMP_IF_
. ThePOP_JUMP_IF_
is where we jump from.So marking
COMPARE_AND_BRANCH
as a jump confuses dis, it thinks the operator is a jump offset.COMPARE_AND_BRANCH
is effectively a superinstruction.I could special case
COMPARE_AND_BRANCH
in dis, but I think it might be better to wait for proper support for longer instructions.