Add the Gone Hacking Studio XLS #18362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
zvecr
requested changes
Sep 14, 2022
| ), | ||
| }; | ||
|
|
||
| keyevent_t encoder0_cw = { |
There was a problem hiding this comment.
This is no longer accepted for new contributions, as #17734 provides proper support.
keyboards/ghs/xls/info.json
Outdated
| }, | ||
| "matrix_pins": { | ||
| "cols": ["C15", "C14", "C13", "A3"], | ||
| "rows": ["A4", "B12", "A6", "A10", "A5", "B2", "NO_PIN", "NO_PIN"] |
There was a problem hiding this comment.
Suggested change
| "rows": ["A4", "B12", "A6", "A10", "A5", "B2", "NO_PIN", "NO_PIN"] | |
| "rows": ["A4", "B12", "A6", "A10", "A5", "B2"] |
| @@ -0,0 +1,57 @@ | |||
| #include QMK_KEYBOARD_H | |||
In qmk#18631 some IN notification callbacks that were doing nothing were removed, which should be a valid thing to do (ChibiOS HAL checks the `in_cb` and `out_cb` pointers for being non-NULL before invoking those optional callbacks). However, it turned out that some less popular USB LLDs (KINETIS and MIMXRT1062) have their own checks for those pointers, and (incorrectly) skip the ChibiOS callback handling when those pointers are NULL, which breaks the code for the `USB_USE_WAIT` configuration option (the waiting thread never gets resumed if the corresponding callback pointer is NULL). Add those dummy callbacks again (but use a single function for all of them instead of individual ones for each endpoint); this restores the KINETIS and MIMXRT1062 boards to the working state while the LLDs are getting fixed.
* Add HOLD_ON_OTHER_KEY_PRESS to data/ files * Add unit tests for HOLD_ON_OTHER_KEY_PRESS
* Fix garbled test output * Correct SRC listing
Co-authored-by: Selene ToyKeeper <git@toykeeper.net>
* rename LAYOUT_65_ansi_blocker_tsangan to LAYOUT_65_ansi_blocker_tsangan_split_bs Layout was implemented with Split Backspace. * rename LAYOUT_65_iso_blocker_7u_spc to LAYOUT_65_iso_blocker_tsangan_split_bs * rules.mk: update Community Layout support setting * mb65s.h: update matrix diagram * add LAYOUT_65_ansi_blocker * add LAYOUT_65_iso_blocker * add LAYOUT_65_ansi_blocker_tsangan * add LAYOUT_65_iso_blocker_tsangan * move Community Layout support to info.json * update Community Layout support
* refactor default keymap - shorten layer names - KM_QWERTY -> _QW - KM_MEDIA -> _MD - KM_GUI_LOCK -> _GL - use QMK-native keycode aliases - use four-space indent - grid-align keycodes * remove third layer from default keymap The third layer only serves to disable the GUI keys, which we can do with a keycode. * update default keymap readme * ghost_squid.h: add matrix diagram * add LAYOUT_fullsize_ansi * add LAYOUT_fullsize_iso * use LAYOUT_fullsize_iso macro in default keymap Refactor the default keymap to use the new LAYOUT_fullsize_iso macro. * remove LAYOUT macro Same matrix as LAYOUT_fullsize_iso, but in a different assignment order. * enable Community Layout support
* Add H50 keyboard from huytbt Add H50 keyboard The H50 is a mini keyboard with a 50 percent layout. The keyboard consists of 53 keys. * Optimize code * Optimize keymap code * Optimize code H50 keyboard
* info.json: apply friendly formatting * info.json: correct layout data
Switch the matrix positions for `KC_NUHS` and `KC_ENT`.
qmk#18929) * add split space and ISO * Update wkl.h * update ISO * update * change KC_LGUI to KC_RGUI * delete RGUI * format * update promise87 readme.md * update promise87 wkl readme.md * Update readme.md * Update readme.md * change KC_SLCK to KC_SCRL * wuque/promise87/ansi: standardize Layout Macro names - rename `LAYOUT_tkl_f13_ansi` to `LAYOUT_tkl_f13_ansi_tsangan` - convert `LAYOUT_tkl_f13_ansi_iso` to `LAYOUT_tkl_f13_iso_tsangan` (adds position `K41`) - rename `LAYOUT_tkl_f13_ansi_split_space` to `LAYOUT_tkl_f13_ansi_tsangan_split_space` - rename `LAYOUT_tkl_f13_ansi_split_bs` to `LAYOUT_tkl_f13_ansi_tsangan_split_bs` - rename `LAYOUT_tkl_f13_ansi_split_lshift` to `LAYOUT_tkl_f13_ansi_tsangan_split_lshift` - rename `LAYOUT_tkl_f13_ansi_split_rshift` to `LAYOUT_tkl_f13_ansi_tsangan_split_rshift` - rename `LAYOUT_tkl_f13_ansi_split_bs_rshift` to `LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift` * wuque/promise87/wkl: refactor LAYOUT_tkl_f13_ansi_wkl_iso Refactors `LAYOUT_tkl_f13_ansi_wkl_iso` into `LAYOUT_tkl_f13_iso_wkl` by adding position `K41` (Non-US Backslash) to the layout macro. Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
* Additional dd backlight config * Update docs
Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com>
* Add piantor * Update keyboards/beekeeb/piantor/readme.md Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Drashna Jaelre <drashna@live.com>
* [Docs] Update reference_info_json.md - Makes it easier to find keyboard.jsonschema. - Adds a reference to the Data Driven page. * Update docs/reference_info_json.md Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com>
* rb1 * Update keymap.c * Update keyboards/ryanbaekr/rb1/info.json Co-authored-by: Ryan <fauxpark@gmail.com> * Delete rb1.c * Delete rb1.h * Update keyboards/ryanbaekr/rb1/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/ryanbaekr/rb1/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/ryanbaekr/rb1/config.h Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Add encoder functionality Update VID Update VID and PID Update files to use encoder map
|
Will reopen a new PR. I messed up rebasing this. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Gone Hacking Studio XLS numpad.
Types of Changes
Issues Fixed or Closed by This PR
Checklist