Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site api #135

Merged
merged 130 commits into from
Mar 26, 2015
Merged

Site api #135

merged 130 commits into from
Mar 26, 2015

Conversation

gperez-r7
Copy link
Contributor

This pull request contains the following changes:

  • For all modified classes:
    • Adding methods to serializing to JSON
  • Changes to the Nexpose::Site class:
    • Adding support for specifying asset groups as scan targets
    • Renaming member variables to more clearly represent the data type of the variables
    • Renaming methods for adding/removing scan targets
    • Making requests to new Restful JSON APIs instead of XML APIs.
  • Changes to the Nexpose::Schedule class:
    • Renaming variables
  • Changes to the Nexpose::Credential class:
    • Adding utility methods for creating all currently-support types of credentials.
  • Adding web app credentials to nexpose-client
  • Adding discovery configurations to nexpose-client
  • Adding discovery filters to nexpose-client

TODO:

  • Update existing site method tests
  • Update VCR recordings for new API responses
  • Review code docs
  • Add 100% test coverage for new changes (Optional/Desired)

Scott Green and others added 30 commits February 10, 2015 16:23
adding wait class to test report downloads during nightly build
fb3ca40
adding a few inline comments for documentation.
db2148f
documentation for default timeout and polling interval times.
ac8f6fe
@sgreen-r7
more documentation
c62f9cf
@sgreen-r7
initial workings for integration method
d701790
@sgreen-r7
temp fix to allow tests to run on ruby 2.0
f64e03e
Added utility methods on Site to add or remove scan targets
b739b43
@sgreen-r7
merge with rapid7 master
ad8f7f6
@sgreen-r7
setup to use retry_count for timeout failures.
5eba755
@ugohil-r7
Gem site credentials updated to use 2.1 api
2e2d452
@ugohil-r7
Created site credential object from hash
ad9a239
@dcastellanos-r7
JsonSerializer mixin as a possible solution for crud ops on api
2f04aee
@dcastellanos-r7
Re-add site credentials creation
9173097
@gperez-r7
Updating site.rb to interact with the new 2.1 APIs.
0c86508 
Modifying the save method to submit requests to the 2.1 RESTful endpoints. Also renaming public member variables to better reflect the type of data that they will contain.
@gperez-r7
Merge branch 'site-api' of github.com:rapid7/nexpose-client into site…
7427363 
…-api
@gperez-r7
Improving scan target methods and implementing to_hash and from_hash …
f06bbde 
…methods.

The scan target methods were simplified. Also, the methods were modified to support not only string parameters but also IPRange objects for IP addresses and HostName objects for hostnames. Implemented to_hash and from_hash methods to convert the scan targets between strings and their HostName/IPRange objects.
@ugohil-r7
Discovery config for site 2.1
6e4cb2c
@sgreen-r7
rescuse more errors for better error output on failures.
255d03d
@ugohil-r7
Put nil check for discovery config
f389df6
@sgreen-r7
text update for api error output
8ff292d
@ugohil-r7
Introduce scope of credential
2a3ed3e
@mrongali
Added tags support to site api
d8e1980
@ugohil-r7
Using existing discovery.rb file instead of new discovery_Config file…
cff61d5 
… for discovery connection
@dcastellanos-r7
Gem changes for alerts, users and sites
6795d3c
@ugohil-r7
Fixed refrence of module in site credentials
23bceb7
@ugohil-r7
hmm need to learn how to reference constant in ruby
f4b21f9
@sgreen-r7
adding for_judgement method which will accept any proc and poll for i…
f771ea8 
…t to be true
@ugohil-r7
Web Auth Html header for site 2.1 api
85bf211
@dcastellanos-r7
Add validation to Alert initializers
397e2c6
@sgreen-r7
mild cleanup while looking for feedback
f01b4a3
Adam Bunn and others added 20 commits March 20, 2015 16:49
Address more hound comments
0a043e4
Add shared_secret to nexpose.rb
de936b0
Update after testing with cucumber
3ecd576
@dcastellanos-r7
Add server port field to Alerts, splitting it up from server string.
a65a15b
@abunn-r7
Merge pull request #141 from abunn-r7/bidirectional_engines
0917f49 
API updates for Bi-directional engine features
@abunn-r7
Update engine.rb
f7b47ca 
Remove '.success' from 2.1 API reponse
@abunn-r7
Update engine.rb#reverse_engine_connection
419d035 
Return a boolean from the reverse_engine_connection method
@mhughes-r7
Update adhoc schedules to support force parameter
d1d757b 
Force parameter added to allow scheduling of adhoc scans in blackout periods.

NEX-40391
@mhughes-r7
test commit to see if i have permissions
4fedde9
@mhughes-r7
Add support for ad-hoc scans with schedules
1475254 
NEX-40391
@mhughes-r7
Add support for ad-hoc scans with schedules
c6df1d3 
Fix some issues with site loading

NEX-40391
@mhughes-r7
Add support for ad-hoc scans with schedules
312329a 
Fix param name for adhocschedule class

NEX-40391
@mhughes-r7
Add support for ad-hoc scans with schedules
29112ac 
Fix scan_device(s)_with schedule to work properly as I'd moved a line of code I shouldn't have

NEX-40391
@mhughes-r7
Add support for ad-hoc scans with schedules
b6daafb 
Remove some unnecessary changes to site.rb

NEX-40391
@mhughes-r7
Update adhoc schedules to support force parameter
77f1ded 
Force parameter added to allow scheduling of adhoc scans in blackout periods.

NEX-40391
@mhughes-r7
Merge remote-tracking branch 'origin/site-api-adhoc-schedule' into si…
5f302bd 
…te-api-adhoc-schedule
@mhughes-r7
Fix error with scan_device_with_schedule
3353498 
NEX-40391
@mhughes-r7
Clean up code based on rubocop/hound output
9239c25 
NEX-40391
@rtaylor-r7
MOB-149: Add support for mobile powerhshell and office 365 connection…
f002ebf 
…s connections
@gschneider-r7
Address some hound comments on whitespace
f7e271c
@gschneider-r7 gschneider-r7 reopened this Mar 25, 2015
gschneider-r7 and others added 6 commits March 24, 2015 19:19
@gschneider-r7
Remove stray semicolon
c4d7cc2
@gschneider-r7
Merge pull request #144 from rapid7/mobile
9499ce6 
MOB-149: Add support for mobile powershell and office 365 connections c...
@erran
cherry-pick: Send the engine-id when calling DiscoveryConnection#save
6519729 
This commit resolves conflicts introduced by recent changes though
e4e21b0 had already been merged to
master.
@sgreen-r7
Merge pull request #145 from rapid7/support-engine-id-in-discovery-in…
d15a91b 
…-site-api

cherry-pick: Send the engine-id when calling DiscoveryConnection#save
@gschneider-r7
Merge pull request #142 from rapid7/site-api-adhoc-schedule
54ed13f 
Update gem to support XML API adding of schedules to adhoc scans
@gperez-r7
Merge branch 'master' into site-api
2f3f6bb
@ugohil-r7 ugohil-r7 merged commit 2f3f6bb into staging/v1 Mar 26, 2015
@gschneider-r7 gschneider-r7 deleted the site-api branch March 27, 2015 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Need Feeback
Projects
None yet
Milestone
One Dot Oh
Development

Successfully merging this pull request may close these issues.