fix: updates to optimize tree shaking #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhowenstine
requested review from
erautenberg,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Failed. |
1 similar comment
|
Test Execution Failed. |
joshhowenstine
force-pushed
the
tree-shaking
branch
from
a6140a9 to
d18888c
Compare
|
Test Execution Failed. |
|
Test Execution Failed. |
6 similar comments
|
Test Execution Failed. |
|
Test Execution Failed. |
|
Test Execution Failed. |
|
Test Execution Failed. |
|
Test Execution Failed. |
|
Test Execution Failed. |
ImCoolNowRight
force-pushed
the
tree-shaking
branch
from
9b55dea to
c7ae596
Compare
|
Test Execution Passed. |
ImCoolNowRight
force-pushed
the
tree-shaking
branch
from
c7ae596 to
f00f872
Compare
|
Test Execution Passed. |
|
I've built this, brought it into inner source's |
joshhowenstine
force-pushed
the
tree-shaking
branch
from
f00f872 to
c8ff258
Compare
|
Test Execution Passed. |
packages/@lightningjs/ui-components/src/globals/context/index.d.ts
Outdated
Show resolved
Hide resolved
packages/@lightningjs/ui-components/src/mixins/withThemeStyles/utils.js
Outdated
Show resolved
Hide resolved
packages/@lightningjs/ui-components/src/textures/index-remove.js
Outdated
Show resolved
Hide resolved
joshhowenstine
force-pushed
the
tree-shaking
branch
from
c8ff258 to
1570d4f
Compare
ImCoolNowRight
approved these changes
Mar 13, 2024
slhay28
approved these changes
Mar 19, 2024
…ge to withThemeStyles
joshhowenstine
force-pushed
the
tree-shaking
branch
from
b288dcc to
c7dd5b1
Compare
|
Test Execution Failed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Mar 21, 2024
# [@lightningjs/ui-components-v2.20.5](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.4...@lightningjs/ui-components-v2.20.5) (2024-03-21) ### Bug Fixes * allow CardContent to pass through style to Tile component ([#487](#487)) ([ef67bc8](ef67bc8)) * allow CardContentVerticalSmall to control marquee onFocus ([#485](#485)) ([6a0208a](6a0208a)) * **KeyboardSearch:** allow custom key styles inside a preset Keyboard ([#484](#484)) ([68387a0](68387a0)) * updates to optimize tree shaking ([#467](#467)) ([f11dc92](f11dc92))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.20.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR eliminates all re-exports from the codebase and replaces them with direct file references. The primary goal of this change is to improve our project's compatibility with tree shaking. By directly referring to files, we can ensure that only the code actually used in the project is included in the final bundle, which will lead to smaller bundle sizes and better performance in production environments.
References
NO-JIRA
Testing
Testing if tree shaking is working properly takes a few steps. You will need to utilize an existing or new project to see the results.
Build the Project: Execute the Webpack build process using npm run build or your project's equivalent script to generate the production bundle.
Review Output: After the build, review the output to ensure there are no errors or warnings related to the tree shaking process or the direct file references. This step is crucial to verify that the modifications have not introduced any build issues. The final bundle should only include Lightning UI components that have been used in your project. All others should no longer be present in the final code.
Automation
All automation tests should pass as expected. This should have no effect on exported components or functions.
Checklist