Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow CardContentVerticalSmall to control marquee onFocus #485

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

joshhowenstine
Copy link
Contributor

Description

Allow Marquee scroll behavior to be controlled with the theme

References

Ticket

Testing

  • CardContentVerticalSmall should marquee the title on focus.
  • You should be able to update the theme for CardContentVerticalSmall with componentConfig. Setting the marqueeOnFocus to false should disable marquee for the title on scroll

Automation

Title should marquee title on focus

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@joshhowenstine joshhowenstine changed the title fix: allow CardContentVerticalSmall to control marquee behavior from … fix: allow CardContentVerticalSmall to control marquee onFocus Mar 13, 2024
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

Copy link
Contributor

@ImCoolNowRight ImCoolNowRight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some whitespace removed, but looks good!

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

@joshhowenstine joshhowenstine merged commit 6a0208a into develop Mar 14, 2024
9 checks passed
@joshhowenstine joshhowenstine deleted the fix/LUI-1405 branch March 14, 2024 20:10
svc-lightning-ui-components pushed a commit that referenced this pull request Mar 21, 2024
# [@lightningjs/ui-components-v2.20.5](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.4...@lightningjs/ui-components-v2.20.5) (2024-03-21)

### Bug Fixes

* allow CardContent to pass through style to Tile component ([#487](#487)) ([ef67bc8](ef67bc8))
* allow CardContentVerticalSmall to control marquee onFocus ([#485](#485)) ([6a0208a](6a0208a))
* **KeyboardSearch:** allow custom key styles inside a preset Keyboard ([#484](#484)) ([68387a0](68387a0))
* updates to optimize tree shaking ([#467](#467)) ([f11dc92](f11dc92))
@svc-lightning-ui-components
Copy link
Collaborator

🎉 This PR is included in version @lightningjs/ui-components-v2.20.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants