Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow CardContent to pass through style to Tile component #487

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

joshhowenstine
Copy link
Contributor

Description

In some instances it may be necessary to pass a style down from CardContentHorizantal through the tile prop into the Tile component. This

References

No Jira

Testing

Open CardContentHorizantal story
remove all controls to ensure you can add the required props directly to the component. Then add something like the following.

        tile: {
            style: {
              paddingX: 40
            },
            progressBar: {
              progress: .5
            },
            metadata: {
              title: 'foo'
            }
          }

All tile styles should now be allowed to be modified at the instance level.

Automation

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Passed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight force-pushed the fix/card-content-tile-style branch from 552fa1a to 1489fc5 Compare March 20, 2024 17:51
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight merged commit ef67bc8 into develop Mar 20, 2024
9 checks passed
@ImCoolNowRight ImCoolNowRight deleted the fix/card-content-tile-style branch March 20, 2024 18:12
svc-lightning-ui-components pushed a commit that referenced this pull request Mar 21, 2024
# [@lightningjs/ui-components-v2.20.5](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.4...@lightningjs/ui-components-v2.20.5) (2024-03-21)

### Bug Fixes

* allow CardContent to pass through style to Tile component ([#487](#487)) ([ef67bc8](ef67bc8))
* allow CardContentVerticalSmall to control marquee onFocus ([#485](#485)) ([6a0208a](6a0208a))
* **KeyboardSearch:** allow custom key styles inside a preset Keyboard ([#484](#484)) ([68387a0](68387a0))
* updates to optimize tree shaking ([#467](#467)) ([f11dc92](f11dc92))
@svc-lightning-ui-components
Copy link
Collaborator

🎉 This PR is included in version @lightningjs/ui-components-v2.20.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants