feat(og-gen): Update implementation of useLocation | Update App template #10441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to build all the meta tags in one go
…support * 'main' of github.com:redwoodjs/redwood: (30 commits) fix(scenario): Make sure to cleanup even if test fails (#10112) Update babel monorepo to v7.24.0 (#10090) Update storybook monorepo to v7.6.17 (#10089) Update dependency @apollo/client to v3.9.5 (#10087) fix(serve): Allow periods in most paths (#10114) feat(rsc-streaming): Integrating RSC builds with Streaming and Client side hydration (#10031) chore(style): getDefaultViteConfig source format (#10111) chore(refactor): vite - extract default vite config (#10110) chore(comment): cli index FIXME comment about ugly big red box RSC: rscBuildAnalyze: Start at web/src/ (#10109) RSC: ensureProcessDirWeb() (#10108) RSC: Extract webpack shims into their own file (#10107) RSC: Remove completed TODO comment RSC: Babel react plugin not needed for analyze phase (#10106) RSC: runFeServer: wrap RSC code with `if (rscEnabled)` (#10105) RSC: Update comments, naming etc based on Danny's input (#10104) RSC: Rename to buildRscClientAndServer (#10103) RSC: Rename to rscBuildForServer, and tweak some comments (#10102) SSR: Extract buildForStreamingServer function (#10099) chore(unit-tests): Silence middleware error logging (#10097) ...
14 tasks
dac09
added a commit
that referenced
this pull request
Apr 12, 2024
…g-gen-mw-p2 * 'main' of github.com:redwoodjs/redwood: feat(og-gen): Update implementation of useLocation | Update App template (#10441)
dac09
added a commit
that referenced
this pull request
Apr 16, 2024
…-dbauth-middleware * 'main' of github.com:redwoodjs/redwood: chore(location): Accept URL-like object (#10467) fix(router): Remove barrel exports from router.tsx (#10464) chore(dbauth-mw): Refactor web side dbAuth creation (#10460) chore(router): Prevent circular dependency for namedRoutes (#10463) chore(router): route-validators: Better types and clean up comments (#10462) feat(server-auth): dbAuth 3/3 - handle login, logout, signup, etc. requests if forwarded from middleware (#10457) docs(router): Document new NavLink className replacement behavior (#10401) chore(refactor): Split the router out into smaller logical units (#10434) feat(server-auth): Part 1/3: dbAuth middleware support (web side changes) (#10444) chore(auth): Build: Put ESM at the root, and CJS in /cjs (#10458) fix(ssr): Successfully serve static assets like `favicon.png` (#10455) chore(deps): update chore (#10367) (docs) Fix useCache headers and links (#10451) chore: remove aws-lambda (#10450) chore(deps): update dependency typescript to v5.4.5 (#10452) feat(og-gen): Update implementation of useLocation | Update App template (#10441) feat(og-gen): Adds package and vite plugin for dynamic og generation (#10439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10440
Changes
Updated App.tsx template
We modified the
App.tsxtemplate to accept possible children, and render them if present. This lets the og:image handler inject your component into the Document tree, without including the entire Router, but still style your og:image component using whatever you used to style the rest of your app (Tailwind, perhaps?)Updated useLocation implementation
We also modified the
useLocation()hook to now return everything that the URL API returns. Previously it only returned three attributes of the url (pathname, search, hash), now it returns everything available to a call tonew URL()(origin, href, searchParams, etc.).The reason for this is now that we have SSR, we can get access to more details in the hook - in this case we needed origin
Rob moved some tests
Rob wanted to move some tests
Both changes should be non-breaking!