Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing changes from sonic-build image #41

Merged
merged 108 commits into from
Jul 26, 2023

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    c81c368 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45210c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c9279dc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e0918d2 View commit details
    Browse the repository at this point in the history
  5. [submodule] Update submodule sonic-mgmt-framework to the latest HEAD …

    …automatically (sonic-net#15549)
    
    #### Why I did it
    src/sonic-mgmt-framework
    ```
    * 4a2ff41 - (HEAD -> master, origin/master, origin/HEAD) [actions] Support Semgrep by Github Actions (sonic-net#116) (5 hours ago) [Mai Bui]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    e5d6401 View commit details
    Browse the repository at this point in the history
  6. [submodule] Update submodule sonic-dbsyncd to the latest HEAD automat…

    …ically (sonic-net#15547)
    
    #### Why I did it
    src/sonic-dbsyncd
    ```
    * e4ac906 - (HEAD -> master, origin/master, origin/HEAD) [actions] Support Semgrep by Github Actions (sonic-net#59) (7 hours ago) [Mai Bui]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b211227 View commit details
    Browse the repository at this point in the history
  7. [submodule] Update submodule linkmgrd to the latest HEAD automatically (

    sonic-net#15546)
    
    #### Why I did it
    src/linkmgrd
    ```
    * 4bda49b - (HEAD -> master, origin/master, origin/HEAD) [actions] Support Semgrep by Github Actions (sonic-net#210) (7 hours ago) [Mai Bui]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ac0c18b View commit details
    Browse the repository at this point in the history
  8. [submodule] Update submodule dhcprelay to the latest HEAD automatical…

    …ly (sonic-net#15545)
    
    #### Why I did it
    src/dhcprelay
    ```
    * c36b8e3 - (HEAD -> master, origin/master, origin/HEAD) [actions] Support Semgrep by Github Actions (sonic-net#39) (7 hours ago) [Mai Bui]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    076dae8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    12a039c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a003861 View commit details
    Browse the repository at this point in the history
  11. [buildsystem] Fix hiredis package version: 0.14.1-1 (sonic-net#15461)

    - Why I did it
    To fix hiredis compilation
    
    - How I did it
    Changed package version: 0.14.0-3~bpo9+1 -> 0.14.1-1
    
    - How to verify it
    make configure PLATFORM=mellanox
    make target/sonic-mellanox.bin
    
    Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
    nazariig authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d9dfb36 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. enable info log for graceful restart events (sonic-net#15535)

    Why I did it
    Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered.
    
    Work item tracking
    Microsoft ADO (13875291):
    How I did it
    To create patch file to change from debug level to info level.
    
    How to verify it
    To run PR test and capture the print.
    StormLiangMS authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a67bffa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c65bdc1 View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule sonic-host-services to the latest HEAD a…

    …utomatically (sonic-net#15548)
    
    #### Why I did it
    src/sonic-host-services
    ```
    * 508d642 - (HEAD -> master, origin/master, origin/HEAD) [actions] Support Semgrep by Github Actions (sonic-net#67) (31 hours ago) [Mai Bui]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3a75519 View commit details
    Browse the repository at this point in the history
  4. Update gnxi ptr (sonic-net#15562)

    #### Why I did it
    
    Need new changes that were added to gnxi inside ptf docker
    
    ##### Work item tracking
    - Microsoft ADO **(number only)**: 17747466
    
    #### How I did it
    
    Update commit number
    
    #### How to verify it
    
    Pipeline
    zbud-msft authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e0f287b View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    a81505f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e5268d9 View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule sonic-sairedis to the latest HEAD automa…

    …tically (sonic-net#15565)
    
    #### Why I did it
    src/sonic-sairedis
    ```
    * 14a863a - (HEAD -> master, origin/master, origin/HEAD) [warmboot] Add workaround for `INIT_VIEW` failure  (sonic-net#1252) (5 hours ago) [Jing Zhang]
    * abb02a5 - [actions] Support Semgrep by Github Actions (sonic-net#1254) (2 days ago) [Mai Bui]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    067ef67 View commit details
    Browse the repository at this point in the history
  4. Modify azure cli to install through apt-get and pyaml to specific ver…

    …sion supported by py2 (sonic-net#15472)
    
    Why I did it
    Current docker-sonic-mgmt build is broken. So below are two fixes which can help in mitigating the same.
    
    PYAML - Download a specific version in python2 as after https://pypi.org/project/pyaml/23.5.5/ there was support only for python3. This update happened on May 5th. And consequently all daily builds after this changes https://dev.azure.com/mssonic/build/_build/results?buildId=266733&view=results (starting build to break) kept failing
    Azure-CLI - this can be downloaded by apt-get repository. So modify as an improvement.
    Work item tracking
    Microsoft ADO (number only): [Build] fix docker-sonic-mgmt build sonic-net#15567
    How I did it
    By manually checking the release notes of pyaml and install azure-cli in newly installed docker container using apt-get
    
    How to verify it
    You can run below commands to validate:
    
    make configure PLATFORM=generic
    make target/docker-sonic-mgmt.gz
    
    Second line would fail without the commit.
    shbalaku-microsoft authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    1389772 View commit details
    Browse the repository at this point in the history
  5. [Arista][x86_64-arista_7050_qx32] Add Components to platform.json (so…

    …nic-net#15252)
    
    * [Arista][x86_64-arista_7050_qx32] Add Components to platform.json
    
    Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
    
    * fix comment
    
    Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
    
    * fix comment
    
    Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
    
    * reformat
    
    Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
    
    ---------
    
    Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
    vdahiya12 authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    78c262e View commit details
    Browse the repository at this point in the history
  6. [dns] Add support for static DNS configuration. (sonic-net#14549)

    - Why I did it
    Add support for static DNS configuration. According to sonic-net/SONiC#1262 HLD.
    
    - How I did it
    Add a new resolv-config.service that is responsible for transferring configuration from Config DB into /etc/resolv.conf file that is consumed by various subsystems in Linux to resolve domain names into IP addresses.
    
    - How to verify it
    Run the image compilation. Each component related to the static DNS feature is covered with the unit tests.
    Run sonic-mgmt tests. Static DNS feature will be covered with the system tests.
    Install the image and run manual tests.
    oleksandrivantsiv authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    475fe27 View commit details
    Browse the repository at this point in the history
  7. [systemd-sonic-generator] replace sscanf with strtol (sonic-net#15357)

    #### Why I did it
    Avoid 'sscanf()' for number conversions. Its use can lead to undefined behavior, slow processing, and integer overflows. Instead prefer the 'strto*()' family of functions.
    
    #### How I did it
    replace sscanf with strtol
    #### How to verify it
    Manual test
    maipbui authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    fca3458 View commit details
    Browse the repository at this point in the history
  8. docker prefer COPY to ADD in dockerfile (sonic-net#15394)

    #### Why I did it
    Docker best practices prefer COPY to ADD
    https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy
    ##### Work item tracking
    - Microsoft ADO **(number only)**: 17418730
    
    #### How I did it
    Use the COPY command as opposed to ADD unless working with a tar file.
    maipbui authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    110a3fd View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. [chassis][lldp] Fix the lldp error log in host instance which doesn't…

    … contain front panel ports (sonic-net#14814)
    
    * [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front pannel ports
    
    ---------
    
    Signed-off-by: mlok <marty.lok@nokia.com>
    mlok-nokia authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    16bb026 View commit details
    Browse the repository at this point in the history
  2. [yang] add Yang model for MUX_LINKMGR|LINK_PROBER (sonic-net#15384)

    Add yang model for MUX_LINKMGR|LINK_PROBER table.
    
    sign-off: zhangjing@microsoft.com
    zjswhhh authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6ba5b84 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Configuration menu
    Copy the full SHA
    c1462f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    05aa404 View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule sonic-host-services to the latest HEAD a…

    …utomatically (sonic-net#15591)
    
    #### Why I did it
    src/sonic-host-services
    ```
    * eab4a9e - (HEAD -> master, origin/master, origin/HEAD) [hostcfgd][dns] Subscribe to DNS_NAMESERVER table to react to static DNS configuration changes. (sonic-net#49) (2 days ago) [Oleksandr Ivantsiv]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    2f4cd3a View commit details
    Browse the repository at this point in the history
  4. [sonic-mgmt] install newest az-cli to mitigate old version az-cli iss…

    …ue (sonic-net#15621)
    
    Force merge to work around the az-cli installation issue.
    yejianquan authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    6bb0483 View commit details
    Browse the repository at this point in the history
  5. Timezone sync issue between the host and containers (sonic-net#14000)

    #### Why I did it
    To fix the timezone sync issue between the containers and the host. If a certain timezone has been configured on the host (SONIC) then the expectation is to reflect the same across all the containers.
    
    This will fix [Issue:13046](sonic-net#13046).
    
    For instance, a PST timezone has been set on the host and if the user checks the link flap logs (inside the FRR), it shows the UTC timestamp. Ideally, it should be PST.
    nmoray authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    f978b2b View commit details
    Browse the repository at this point in the history
  6. Fix issue: systemctl daemon-reload would sporadically cause udev hand…

    …ler fail (sonic-net#15253)
    
    #### Why I did it
    
    A workaround to back port the fix for a systemd issue.
    
    The systemd issue: systemd/systemd#24668
    The systemd PR to fix the issue: https://github.com/systemd/systemd/pull/24673/files
    
    The formal solution should upgrade systemd to a version that contains the fix. But, systemd is a very basic service, upgrading systemd requires heavy test. 
    
    #### How I did it
    Copy the correct systemd-udevd.service file in build time 
    
    #### Tested branch (Please provide the tested image version)
    
    - [x] 202211
    - [ ] <!-- image version 2 -->
    
    ```
    SONiC Software Version: SONiC.fix-udev.3-b65c7bdec_Internal
    SONiC OS Version: 11
    Distribution: Debian 11.7
    Kernel: 5.10.0-18-2-amd64
    Build commit: b65c7bd
    Build date: Mon Jun 19 10:54:50 UTC 2023
    Built by: sw-r2d2-bot@r-build-sonic-ci02-241
    
    Platform: x86_64-mlnx_msn4700-r0
    HwSKU: ACS-MSN4700
    ASIC: mellanox
    ASIC Count: 1
    Serial Number: MT2022X08597
    Model Number: MSN4700-WS2FO
    Hardware Revision: A1
    Uptime: 08:10:11 up 1 min,  1 user,  load average: 1.81, 0.67, 0.24
    Date: Sun 25 Jun 2023 08:10:11
    
    Docker images:
    REPOSITORY                    TAG                             IMAGE ID       SIZE
    docker-fpm-frr                fix-udev.3-b65c7bdec_Internal   a7b911e7cb6f   346MB
    docker-fpm-frr                latest                          a7b911e7cb6f   346MB
    docker-platform-monitor       fix-udev.3-b65c7bdec_Internal   94c5178cf80b   731MB
    docker-platform-monitor       latest                          94c5178cf80b   731MB
    docker-orchagent              fix-udev.3-b65c7bdec_Internal   46b393e0ace8   328MB
    docker-orchagent              latest                          46b393e0ace8   328MB
    docker-syncd-mlnx             fix-udev.3-b65c7bdec_Internal   1f5c6c23e33a   734MB
    docker-syncd-mlnx             latest                          1f5c6c23e33a   734MB
    docker-sflow                  fix-udev.3-b65c7bdec_Internal   7e45992c8c59   317MB
    docker-sflow                  latest                          7e45992c8c59   317MB
    docker-teamd                  fix-udev.3-b65c7bdec_Internal   e4d905592cda   316MB
    docker-teamd                  latest                          e4d905592cda   316MB
    docker-nat                    fix-udev.3-b65c7bdec_Internal   7fe799367580   319MB
    docker-nat                    latest                          7fe799367580   319MB
    docker-macsec                 latest                          d702a5554171   318MB
    docker-snmp                   fix-udev.3-b65c7bdec_Internal   3bce8fcf71cd   338MB
    docker-snmp                   latest                          3bce8fcf71cd   338MB
    docker-sonic-telemetry        fix-udev.3-b65c7bdec_Internal   f13949cbc817   597MB
    docker-sonic-telemetry        latest                          f13949cbc817   597MB
    docker-dhcp-relay             latest                          153d9072805d   306MB
    docker-router-advertiser      fix-udev.3-b65c7bdec_Internal   aed642b9a6bc   299MB
    docker-router-advertiser      latest                          aed642b9a6bc   299MB
    docker-sonic-p4rt             fix-udev.3-b65c7bdec_Internal   a3cae5ca65a7   870MB
    docker-sonic-p4rt             latest                          a3cae5ca65a7   870MB
    docker-mux                    fix-udev.3-b65c7bdec_Internal   b81f0401b9a8   347MB
    docker-mux                    latest                          b81f0401b9a8   347MB
    docker-eventd                 fix-udev.3-b65c7bdec_Internal   c5917d0e801f   298MB
    docker-eventd                 latest                          c5917d0e801f   298MB
    docker-lldp                   fix-udev.3-b65c7bdec_Internal   fd5dc14a7976   341MB
    docker-lldp                   latest                          fd5dc14a7976   341MB
    docker-database               fix-udev.3-b65c7bdec_Internal   438c2715a1dd   299MB
    docker-database               latest                          438c2715a1dd   299MB
    docker-sonic-mgmt-framework   fix-udev.3-b65c7bdec_Internal   5c50b115fbcd   414MB
    docker-sonic-mgmt-framework   latest  
    ```
    Junchao-Mellanox authored Jun 25, 2023
    Configuration menu
    Copy the full SHA
    b07957b View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Add support for secure upgrade (sonic-net#11862)

    - What I did
    Added support for secure upgrade.
    
    - How I did it
    During sonic_installer install, added secure upgrade image verification.
    HLD can be found in the following PR: sonic-net/SONiC#1024
    
    - Why I did it
    Feature is used to allow image was not modified since built from vendor. During installation, image can be verified with a signature attached to it.
    
    - How I did it
    Feature includes image signing during build (in sonic buildimage repo) and verification during image install (in sonic-utilities).
    
    - How to verify it
    In order for image verification - image must be signed - need to provide signing key and certificate (paths in SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT in rules/config) during build , and during image install, need to enable secure boot flag in bios, and signing_certificate should be available in bios.
    
    - Feature dependencies
    In order for this feature to work smoothly, need to have secure boot feature implemented as well.
    The Secure boot feature will be merged in the near future.
    ycoheNvidia authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ccf1cd5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa11acd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f154ff0 View commit details
    Browse the repository at this point in the history
  4. [Marvell] Update arm64 sai debian (sonic-net#15602)

    - SAI-1.12.0 support
    
    Signed-off-by: rajkumar38 <rpennadamram@marvell.com>
    rajkumar38 authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ec6723d View commit details
    Browse the repository at this point in the history
  5. [Arista] Update platform library submodules (sonic-net#15405)

    - fix pcied leak on chassis
    - fix fan status led setting on fixed systems
    - misc fixes
    Staphylo authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    4e43484 View commit details
    Browse the repository at this point in the history
  6. Move /var/log to RAM for Mellanox SN2700, Nokia 7215 and Dell S6100 (s…

    …onic-net#15077)
    
    * add ONIE_PLATFORM_EXTRA_CMDLINE_LINUX to kernel bootparam
    prgeor authored Jun 26, 2023
    Configuration menu
    Copy the full SHA
    05f326e View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. [CI/CD] Refine t0 sonic and remove SPECIFIED_PARAMS (sonic-net#15625)

    Why I did it
    t0-sonic's specific params has been set on sonic-mgmt repo, remove useless SPECIFIED_PARAMS usage
    yejianquan authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    4449d47 View commit details
    Browse the repository at this point in the history
  2. [submodule] Update submodule sonic-swss to the latest HEAD automatica…

    …lly (sonic-net#15635)
    
    #### Why I did it
    src/sonic-swss
    ```
    * a67f684f - (HEAD -> master, origin/master, origin/HEAD) [hash]: Implement GH backend (sonic-net#2598) (3 hours ago) [Nazarii Hnydyn]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    bacba1f View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule dhcpmon to the latest HEAD automatically (

    …sonic-net#15634)
    
    #### Why I did it
    src/dhcpmon
    ```
    * 824a144 - (HEAD -> master, origin/master, origin/HEAD) replace atoi with strtol (sonic-net#6) (3 hours ago) [Mai Bui]
    * 32c0c3f - Fix libswsscommon package installation for non-amd64 (sonic-net#7) (6 hours ago) [Saikrishna Arcot]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2047e5c View commit details
    Browse the repository at this point in the history
  4. [sonic-pit] Add PIT(Platform Integration Test) feature, second part, … (

    sonic-net#12530)
    
    * [sonic-pit] Add PIT(Platform Integration Test) feature, second part, add 6 test cases.
    
    Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
    
    * Add missing test case configuration and platform configuration.
    
    Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
    
    * Remove unsed comment, replace duplicated function with import from other moduls.
    
    ---------
    
    Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
    clarklee-guizhao authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    8b21b61 View commit details
    Browse the repository at this point in the history
  5. Vnet monitor table cleanup (sonic-net#15399)

    * Added  VNET_MONITOR_TABLE, BFD_SESSION_TABLE, to the listof tables to be cleaned up after swss restart.
    * Added  VNET_ROUTE* table in cleanup. This should cover VNET_ROUTE_TUNNEL_TABLE as well.
    siqbal1986 authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    bf5b72a View commit details
    Browse the repository at this point in the history
  6. [docker-sonic-vs]: dd NPU SKU for docker-sonic-vs (sonic-net#15604)

    Define a generic 2-port NPU SKU for docker-sonic-vs to 
    enable DASH vstests to pass on azure pipelines
    
    Work item tracking
    Microsoft ADO 24375371:
    
    How I did it
    Define a generic 2-port NPU hwsku that is used only for DASH-specific vstests.
    
    Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
    prabhataravind authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d4de62d View commit details
    Browse the repository at this point in the history
  7. [Ci] Support to build sonic-swss-common for test (sonic-net#15566)

    #### Why I did it
    [Ci] Support to build sonic-swss-common for test
    
    ##### Work item tracking
    - Microsoft ADO **(number only)**: 24341479
    xumia authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f0617c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Configuration menu
    Copy the full SHA
    42671e7 View commit details
    Browse the repository at this point in the history
  2. [submodule] Update submodule sonic-host-services to the latest HEAD a…

    …utomatically (sonic-net#15645)
    
    #### Why I did it
    src/sonic-host-services
    ```
    * bc08806 - (HEAD -> master, origin/master, origin/HEAD) Implemented ssh configurations (sonic-net#32) (14 hours ago) [ycoheNvidia]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a06ffc9 View commit details
    Browse the repository at this point in the history
  3. [nvidia] make sure shared storage with syncd is cleared on restarts (s…

    …onic-net#14547)
    
    Why I did it
    Sharing the storage of syncd with other proprietary application extensions allows them to communicate with syncd in differnt ways.
    If one container wants to pass some information to syncd then shared storage can be used. However, today the shared storage isn't cleaned on restarts making it possible for syncd to read out-of-date information generated in the past.
    
    NOTE: No plans to use it for standard SONIC dockers and we are working on removing the SDK dependency from PMON docker
    
    How I did it
    Implemented new service to clean the shared storage.
    
    How to verify it
    Do reboot/fast-reboot/warm-reboot/config-reload/systemctl restart swss and verify /tmp/ is cleaned after each restart in syncd container.
    
    Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
    stepanblyschak authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1ebdcda View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Configuration menu
    Copy the full SHA
    5aaa65d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    874390a View commit details
    Browse the repository at this point in the history
  3. [Nokia][sonic-platform] Update Nokia sonic-platform submodule (sonic-…

    …net#15239)
    
    Why I did it
    To support dynamic swapping of module types/speeds (400G/100G/40G)
    To optimize CMIS ZR optics operation
    How I did it
    Reinitialize xcvr_api at module removal/insertion time, and also optimize cache for ZR optics.
    
    How to verify it
    Verify that different (supported) module types can be dynamically swapped (removed/inserted) and that each is properly provisioned by Xcvrd and has its EEPROM information accurately reported in Redis DB (using "show transceiver eeprom") as well as "sfputil show eeprom" direct access.
    
    Also verify that Xcvrd initialization and operation with 400G CMIS ZR optics is both efficient and functional.
    ** edit 6/14/23: pushed enhanced caching (full memory map) support and elimination of base class APIs override.
    snider-nokia authored Jun 29, 2023
    Configuration menu
    Copy the full SHA
    aa46167 View commit details
    Browse the repository at this point in the history
  4. Migrate flush_unused_database from py-redis to sonic-swss-common (son…

    …ic-net#15511)
    
    Migrate flush_unused_database from py-redis to sonic-swss-common
    
    #### Why I did it
    flush_unused_database using py-redis, but sonic-swss-common already support flushdb, so we need migrate to sonic-swss-common
    
    ##### Work item tracking
    - Microsoft ADO **(number only)**: 24292565
    
    #### How I did it
    Migrate flush_unused_database from py-redis to sonic-swss-common
    
    #### How to verify it
    Pass all UT and E2E test
    
    #### Description for the changelog
    Migrate flush_unused_database from py-redis to sonic-swss-common
    liuh-80 authored Jun 29, 2023
    Configuration menu
    Copy the full SHA
    c91707f View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. [arp_update]: Fix IPv6 neighbor race condition (sonic-net#15583)

    * [arp_update]: Fix IPv6 neighbor race condition on dualtors
    Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
    theasianpianist authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b4a3711 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. [Netberg][Barefoot] Added support for Aurora 710 (sonic-net#15298)

    * [202012][platform/barefoot] (sonic-net#8543)
    
    Why I did it
    Pcied running by python 2.
    
    How I did it
    dropped python2 support and add python3 support for pcied in file docker-pmon.supervisord.conf.j2
    
    How to verify it
    docker exec pmon supervisorctl status
    
    * [Netberg][nba710] Added initial support for Aurora 710
    
    Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
    
    ---------
    
    Signed-off-by: Andrew Sapronov <andrew.sapronov@gmail.com>
    Co-authored-by: Kostiantyn Yarovyi <kostiantynx.yarovyi@intel.com>
    andrewsapronov and KostiantynYarovyiBf authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    c190a8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb9639e View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule sonic-platform-common to the latest HEAD…

    … automatically (sonic-net#15697)
    
    #### Why I did it
    src/sonic-platform-common
    ```
    * 10af810 - (HEAD -> master, origin/master, origin/HEAD) More prevention of fatal exception caused by VDM dictionary missing fields when a transceiver has just been pulled (sonic-net#376) (5 hours ago) [snider-nokia]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    91fb783 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aa5164e View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    7ef59d5 View commit details
    Browse the repository at this point in the history
  2. Add YANG model for FABRIC_PORT (sonic-net#15629)

    #### Why I did it
    
    Introduce YANG model for FABRIC in CONFIG_DB, which was added in sonic-net#14170.
    
    #### How I did it
    
    This is a clone of @jfeng-arista's PR sonic-net#14282 to resolve conflicts with upstream changes. 
    
    #### How to verify it
    
    Passing pipeline build is sufficient.
    kenneth-arista authored Jul 3, 2023
    Configuration menu
    Copy the full SHA
    1dfe35c View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    de65640 View commit details
    Browse the repository at this point in the history
  2. [dash-api]: Add dash-api and related protobuf library (sonic-net#14515)

    Why I did it
    For the DASH scenario, the APP_DB will be optimized by protobuf message for less memory consumption.
    
    How I did it
    Download the Debian package of protobuf 3.21.12 and create a corresponding rule for building it.
    Add a submodule of sonic-dash-api and generated its Debian package which includes C++ library and Python library
    
    How to verify it
    Check artifacts of Azp that the protobuf-related and dash-api deb packages should be generated.
    
    Signed-off-by: Ze Gan <ganze718@gmail.com>
    Pterosaur authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2f89949 View commit details
    Browse the repository at this point in the history
  3. Revert "[gearbox] use credo sai v0.9.0 (sonic-net#14149)" (sonic-net#…

    …15708)
    
    Reverts sonic-net#14149
    
    This SAI libsaicredo_0.9.0_amd64.deb causing packet forwarding issues on Linecards aristanetworks/sonic#92
    
    This reverts commit c4c621c.
    arlakshm authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    eaa795d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6dbfa9 View commit details
    Browse the repository at this point in the history
  5. Use execle instead of popen in tacas nss to avoid shell escape exploi…

    …ts (sonic-net#15284)
    
    Why I did it
    Tacacs nss library uses popen to execute useradd and usermod commands. Popen executes using a shell (/bin/sh) which is passed the command string with "-c". This means that if untrusted user input is supplied, unexpected shell escapes can occur. In this case the username supplied can be untrusted user input when logging in via ssh or other methods when tacacs is enabled. Debian has very little limitation on usernames and as such characters such as quotes, braces, $, >, | etc are all allowed. Since the nss library is run by root, any shell escape will be ran as root.
    
    In the current community version of tacacs nss library, the issue is mitigated by the fact that the useradd command is only ran if the user is found to exist on the tacacs server, so the bad username would have to already exists there which is unlikely. However, internally (at Dell) we had to modify this behavior to support other tacacs servers that do not allow authorization messages to verify user existence prior to a successful authentication. These servers include Cisco ISE and Aruba ClearPass. In order to support these tacacs+ servers, we have to create a temporary user immediately, which means this would be a much bigger issue.
    
    I also plan to supply the patch to support ISE and ClearPass and as such, I would suggest taking this patch to remediate this issue first.
    
    How I did it
    Replace call to popen with fork/execl of the useradd/usermod binary directly.
    
    How to verify it
    Install patched version of libnss-tacplus and verify that tacacs+ user login still works as expected.
    seiferteric authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4e78f58 View commit details
    Browse the repository at this point in the history
  6. Move k8s script to docker-config-engine (sonic-net#14788)

    Why I did it
    To reduce the container's dependency from host system
    
    Work item tracking
    Microsoft ADO (number only):
    17713469
    How I did it
    Move the k8s container startup script to config engine container, other than mount it from host.
    
    How to verify it
    Check file path(/usr/share/sonic/scripts/container_startup.py) inside config engine container.
    
    Signed-off-by: Yun Li <yunli1@microsoft.com>
    Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
    lixiaoyuner and qiluo-msft authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ca29197 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. [submodule] Update submodule sonic-dash-api/sonic-dash-api to the lat…

    …est HEAD automatically (sonic-net#15725)
    
    #### Why I did it
    src/sonic-dash-api/sonic-dash-api
    ```
    * 3f728d1 - (HEAD -> master, origin/master, origin/HEAD) Update vnet_direct in route.proto (sonic-net#4) (11 days ago) [Ze Gan]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    673b8b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39cb254 View commit details
    Browse the repository at this point in the history
  3. Update the docker daemon to 24.0.2 (sonic-net#15652)

    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    saiarcot895 authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e46be54 View commit details
    Browse the repository at this point in the history
  4. [FRR]Fixing the advertisement of static ipv6 route (sonic-net#15688)

    Co-authored-by: dgsudharsan <sudharsand@nvidia.com>
    Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
    3 people authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6f6218a View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    ddb3086 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74e3917 View commit details
    Browse the repository at this point in the history
  3. [staticroutebfd] fix static route uninstall issue when all nexthops a…

    …re not reachable (sonic-net#15575)
    
    fix static route uninstall issue when all nexthops are not reachable.
    the feature was working but the bug was introduced when support dynamic bfd enable/disable. Added UT testcase to guard this.
    baorliu authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a86a026 View commit details
    Browse the repository at this point in the history
  4. Enable BFD for Static Route for chassis-packet. (sonic-net#15383)

    *What I did:
    Enable BFD for Static Route for chassis-packet. This will trigger the use of the feature as defined in here: sonic-net#13789
    
    Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
    abdosi authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    87066ab View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Configuration menu
    Copy the full SHA
    f6282b8 View commit details
    Browse the repository at this point in the history
  2. [submodule] Update submodule sonic-mgmt-common to the latest HEAD aut…

    …omatically (sonic-net#15521)
    
    #### Why I did it
    src/sonic-mgmt-common
    ```
    * 341fd73 - (HEAD -> master, origin/master, origin/HEAD) Remove invalid db type definitions: ERROR_DB, USER_DB (sonic-net#94) (3 days ago) [Sachin Holla]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    cd3cdee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e57692c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Configuration menu
    Copy the full SHA
    9321c97 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Refine PR test template format (sonic-net#15636)

    Why I did it
    Refine PR test template format.
    
    How I did it
    Refine PR test template format.
    
    How to verify it
    PR test executed normally.
    
    Signed-off-by: Chun'ang Li <chunangli@microsoft.com>
    lerry-lee authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c07447a View commit details
    Browse the repository at this point in the history
  2. Remove DNS configuration from minigraph schema (sonic-net#15727)

    #### Why I did it
    We should not modify minigraph schema.
    
    #### How I did it
    Update minigraph.py and remove unit test.
    
    #### How to verify it
    Run sonic-config-engine unit test.
    ganglyu authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    cb3ee65 View commit details
    Browse the repository at this point in the history
  3. [staticroutebfd] fix ipv6 letter case issue (sonic-net#15765)

    *use lower case for IPv6 address as internal key and bfd session key. fixes sonic-net#15764
    
    Why I did it
    *staticroutebfd uses the IPv6 address string as a key to create bfd session and cache the bfd sessions using it as a key.
    When the IPv6 address string has uppercase letter in the static route nexthop list, the string with uppercase letter key is stored in the cache, but the BFD STATE_DB uses lowercase for IPv6 address, so when the staticroutebfd get the bfd state event, it cannot find the bfd session in its local cache because of the letter case.
    baorliu authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    4303308 View commit details
    Browse the repository at this point in the history
  4. Added ssh configurations to YANG model (sonic-net#13338)

    - Why I did it
    Implemented ssh configurations
    
    - How I did it
    Added ssh config table in configDB, once changed - hostcfgd will change the relevant OS files (sshd_config)
    
    - How to verify it
    Tests in sonic-host-services. Change relevant configs in configDB such as ports, and see sshd port was modified
    ycoheNvidia authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7639df0 View commit details
    Browse the repository at this point in the history
  5. Add remote syslog configuration (sonic-net#14513)

    * Add an ability to configure remote syslog servers
    * Add an initial configuration for remote syslog
    * Extend YANG module and add unit tests
    
    #### Why I did it
    Adding the following functionality to rsyslog feature:
    
    - Configure remote syslog servers: protocol, filter, severity level
    - Update global syslog configuration: severity level, message format
    
    #### How I did it
    added parameters to syslog server and global configuration.
    
    #### How to verify it
    create syslog server using CLI/adding to Redis-DB
    verify server is added to file /etc/rsyslog.conf and server is functional.
    
    #### Description for the changelog
    extend rsyslog capabilities, added server and global configuration parameters.
    
    #### Link to config_db schema for YANG module changes
    https://github.com/iavraham/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-syslog.yang
    iavraham authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    72021fd View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Add Python3 packages to sonic-mgmt-docker (sonic-net#15726)

    Why I did it
    This is part of sonic-mgmt-docker Python3 migration project.
    Currently Python3 packages are in the Python3 virtual environment. This PR will add Python3 packages to real file system.
    After we migrate all script to use Python3 in real file system, the Python3 venv will be deleted.
    
    After this PR, in sonic-mgmt-docker,
    Directly run cmd - pytest will use Python2's version.
    python3 -m pytest will use Python3's version.
    
    How I did it
    Modify sonic-mgmt-docker j2 script.
    
    How to verify it
    Build a private sonic-mgmt-docker and run basic test case with Python3.
    wsycqyz authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c589230 View commit details
    Browse the repository at this point in the history
  2. Add health check probe for k8s upgrade containers. (sonic-net#15223)

    #### Why I did it
    After k8s upgrade a container, k8s can only know the container is running, don't know the service's status inside container. So we need a probe inside container, k8s will call the probe to check whether the container is really ready.
    ##### Work item tracking
    - Microsoft ADO **(number only)**: 22453004
    #### How I did it
    Add a health check probe inside config engine container, the probe will check whether the start service exit normally or not if the start service exists and call the python script to do container self-related specific checks if the script is there. The python script should be implemented by feature owner if it's needed.
    
    more details: [design doc](https://github.com/sonic-net/SONiC/blob/master/doc/kubernetes/health-check.md)
    #### How to verify it
    Check path /usr/bin/readiness_probe.sh inside container.
    
    #### Which release branch to backport (provide reason below if selected)
    
    - [ ] 201811
    - [ ] 201911
    - [ ] 202006
    - [ ] 202012
    - [ ] 202106
    - [ ] 202111
    - [x] 202205
    - [x] 202211
    
    #### Tested branch (Please provide the tested image version)
    - [x] 20220531.28
    lixiaoyuner authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c470b7d View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule sonic-gnmi to the latest HEAD automatica…

    …lly (sonic-net#15520)
    
    #### Why I did it
    src/sonic-gnmi
    ```
    *   01fe667 - (HEAD -> master, origin/master, origin/HEAD) Merge pull request sonic-net#134 from FengPan-Frank/fenpan_dialout_rename (3 days ago) [Feng-msft]
    |\  
    | * 994c69c - Rename --enable-dialout option into ENABLE_DIALOUT to follow the convention. (3 days ago) [Feng Pan]
    |/  
    * a9126da - Update makefile to support armhf (sonic-net#132) (3 days ago) [ganglv]
    * 0d80c0d -  prevent potential panic: return immediately if there exists error (sonic-net#113) (7 days ago) [Mai Bui]
    *   3c0fca3 - Merge pull request sonic-net#131 from FengPan-Frank/fenpan_dialout (7 days ago) [Feng-msft]
    |\  
    | * c3d3266 - Add build flag into gnmi as --enable-dialout. (8 days ago) [Feng Pan]
    |/  
    * fd78c42 - add semgrep (sonic-net#126) (2 weeks ago) [Mai Bui]
    * 214fa1c - TranslClient: Use new translib subscription APIs (sonic-net#122) (3 weeks ago) [Sachin Holla]
    * 87d8eb3 - (origin/202305) TranslClient: use PathValidator to sanitize the request paths (sonic-net#112) (3 weeks ago) [Sachin Holla]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d1c0fae View commit details
    Browse the repository at this point in the history
  4. [submodule] Advance sonic-utilities pointer (sonic-net#15779)

    Update sonic-utilities submodule pointer to include the following:
    * ff380e04 [hash]: Implement GH frontend ([sonic-net#2580](sonic-net/sonic-utilities#2580))
    * 61bad064 [db_migrator] Set correct CURRENT_VERSION, extend UT ([sonic-net#2895](sonic-net/sonic-utilities#2895))
    * 6b8ee47c [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([sonic-net#2885](sonic-net/sonic-utilities#2885))
    * 73d8d633 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([sonic-net#2750](sonic-net/sonic-utilities#2750))
    * 7bc08c28 [db_migrator] Remove hardcoded config and migrate config from minigraph ([sonic-net#2887](sonic-net/sonic-utilities#2887))
    * b1aa9426 [generate_dump]: Enhance show techsupport for Marvell platform ([sonic-net#2676](sonic-net/sonic-utilities#2676))
    * 316b14c0 Add support for secure upgrade ([sonic-net#2698](sonic-net/sonic-utilities#2698))
    * dc2945bc [dns] Implement config and show commands for static DNS. ([sonic-net#2737](sonic-net/sonic-utilities#2737))
    * 8414a709 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([sonic-net#2525](sonic-net/sonic-utilities#2525))
    * 0b629ba1 Revert [chassis][voq] Clear fabric counters queue/port (2789) ([sonic-net#2882](sonic-net/sonic-utilities#2882))
    * 3ba8241a [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([sonic-net#2839](sonic-net/sonic-utilities#2839))
    * fceef2ed [chassis][voq] Clear fabric counters queue/port ([sonic-net#2789](sonic-net/sonic-utilities#2789))
    
    Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
    dgsudharsan authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5cbae46 View commit details
    Browse the repository at this point in the history
  5. [submodule] Update submodule sonic-swss to the latest HEAD automatica…

    …lly (sonic-net#15785)
    
    #### Why I did it
    src/sonic-swss
    ```
    * 776af62c - (HEAD -> master, origin/master, origin/HEAD) [CodeQL]: Use dependencies with relevant versions in azp template. (sonic-net#2845) (4 hours ago) [Nazarii Hnydyn]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5eaa0d2 View commit details
    Browse the repository at this point in the history
  6. [submodule] Update submodule sonic-utilities to the latest HEAD autom…

    …atically (sonic-net#15456)
    
    #### Why I did it
    src/sonic-utilities
    ```
    * ff380e04 - (HEAD -> master, origin/master, origin/HEAD) [hash]: Implement GH frontend (sonic-net#2580) (13 hours ago) [Nazarii Hnydyn]
    * 61bad064 - [db_migrator] Set correct CURRENT_VERSION, extend UT (sonic-net#2895) (4 days ago) [Vadym Hlushko]
    * 6b8ee47c - [CLI][Show][BGP] Show BGP Change for no neighbor scenario (sonic-net#2885) (6 days ago) [Dev Ojha]
    * 73d8d633 - [doc] Update Command-Reference.md, change "show bgp peer" command to "show bfd peer" (sonic-net#2750) (11 days ago) [PinghaoQu]
    * 7bc08c28 - [db_migrator] Remove hardcoded config and migrate config from minigraph (sonic-net#2887) (11 days ago) [Vaibhav Hemant Dixit]
    * b1aa9426 - [generate_dump]: Enhance show techsupport for Marvell platform (sonic-net#2676) (11 days ago) [pavannaregundi]
    * 316b14c0 - Add support for secure upgrade (sonic-net#2698) (2 weeks ago) [ycoheNvidia]
    * dc2945bc - [dns] Implement config and show commands for static DNS. (sonic-net#2737) (2 weeks ago) [Oleksandr Ivantsiv]
    * 8414a709 - [chassis][multi asic] change acl_loader to use tcp socket for db communication (sonic-net#2525) (2 weeks ago) [Arvindsrinivasan Lakshmi Narasimhan]
    * 0b629ba1 - Revert "[chassis][voq] Clear fabric counters queue/port (sonic-net#2789)" (sonic-net#2882) (3 weeks ago) [RoRonoa]
    * 3ba8241a - [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. (sonic-net#2839) (4 weeks ago) [Vadym Hlushko]
    * fceef2ed - [chassis][voq] Clear fabric counters queue/port (sonic-net#2789) (4 weeks ago) [jfeng-arista]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    75a1fd9 View commit details
    Browse the repository at this point in the history
  7. [docker-sonic-vs]: More changes to support DPU-2P HWKSU (sonic-net#15695

    )
    
    Why I did it
    port_config.ini and hwsku.json are needed to generate the default config
    switch_type needs to be "dpu" to spawn the right set of processes during dvs initialization and to make sure that DASH APIs can be handled properly
    
    Work item tracking
    Microsoft ADO 24375371:
    
    How I did it
    Use the same hwsku.json and port_config.ini for DPU-2P as the ones used for Nvidia-MBF2H536C SKU in nvidia-sonic sonic-buildimage repo.
    Set switch_type to "dpu" in DEVICE_METADATA configuration to make sure DASH specific APIs are handled properly
    
    Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
    prabhataravind authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    114f276 View commit details
    Browse the repository at this point in the history
  8. Pick dependency files in submodules. (sonic-net#15142)

    #### Why I did it
    
    Failed to build sonic-dhcp6relay_1.0.0-0_amd64.deb
    
    #### How I did it
    
    src/dhcprelay has git submodule.
    Dependency files by "git ls-files" are not picked files in submodules.
    Add --recurse-submodules, work again.
    
    #### How to verify it
    
    make all
    iMasaruOki authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    51b5008 View commit details
    Browse the repository at this point in the history
  9. Support Reset factory (sonic-net#14105)

    #### Why I did it
    Support reset factory in Sonic OS
    [Reset Factory HLD](sonic-net/SONiC#1231)
    [Sonic-mgmt tests](sonic-net/sonic-mgmt#7652)
    
    #### How I did it
    - Added new script "/usr/bin/reset-factory"
       * It generates a new config_db.json files with factory configurations
       * It clears system files and logs
       * It removes all docker containers on system except database
       * It clears non-default users and restores default users password
    - Dump the default users info to a new file during build "/etc/sonic/default_users.json"
    - Supported new type "Keep-basic" in "config-setup factory"
    - Add new conf file for config-setup "/etc/config-setup/config-setup.conf
    
    #### How to verify it
    - Run reset-factory script with all types: < none | keep-all-config | only-config | keep-basic >
    - Run config-setup factory with parameters < none | keep-basic >
    
    #### Description for the changelog
    Support reset factory in Sonic OS
    
    #### Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
    Mohammedz93 authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    28b9299 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. [submodule] Update submodule sonic-utilities to the latest HEAD autom…

    …atically (sonic-net#15798)
    
    #### Why I did it
    src/sonic-utilities
    ```
    * 7ca31477 - (HEAD -> master, origin/master, origin/HEAD) [db_migrator] Set docker_routing_config_mode to the value obtained from minigraph parser (sonic-net#2890) (10 hours ago) [Vaibhav Hemant Dixit]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3b9e8ff View commit details
    Browse the repository at this point in the history
  2. [submodule] Update submodule sonic-platform-common to the latest HEAD…

    … automatically (sonic-net#15797)
    
    #### Why I did it
    src/sonic-platform-common
    ```
    * 465f95e - (HEAD -> master, origin/master, origin/HEAD) Default implementation of under/over speed checks (sonic-net#382) (9 hours ago) [spilkey-cisco]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e3fc93d View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule sonic-linux-kernel to the latest HEAD au…

    …tomatically (sonic-net#15782)
    
    #### Why I did it
    src/sonic-linux-kernel
    ```
    * d070cae - (HEAD -> master, origin/master, origin/HEAD) arm64: dts: marvell: Add Nokia 7215-IXS-A1 board (sonic-net#321) (34 hours ago) [Pavan-Nokia]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4f4559c View commit details
    Browse the repository at this point in the history
  4. [SNMP][IPv6]: Fix SNMP IPv6 reachability issue in certain scenarios (s…

    …onic-net#15487)
    
    Modify snmpd.conf to start snmpd to listen on specific management and loopback ips instead of listening on any ip.
    
    #### Why I did it
    SNMP over IPv6 is not working for all scenarios for a single asic platforms.
    The expectation is that SNMP query over IPv6 should work over Management or Loopback0 addresses.
    **Specific scenario where this issue is seen**
    In case of Lab T0 device,  when SNMP request is sent from a directly connected T1 neighbor over Loopback IP, SNMP response was not received.
    This was because the SRC IP address in SNMP response was not Loopback IP, it was the PortChannel IP connected to the neighboring device.
    ```
    23:18:51.620897  In 22:26:27:e6:e0:07 ethertype IPv6 (0x86dd), length 105: fc00::72.41725 > **fc00:1::32**.161:  C="msft" **GetRequest**(28)  .1.3.6.1.2.1.1.1.0
    23:18:51.621441 Out 28:99:3a:a0:97:30 ethertype IPv6 (0x86dd), length 241: **fc00::71**.161 > fc00::72.41725:  C="msft" **GetResponse**(162)  .1.3.6.1.2.1.1.1.0="SONiC Software Version: SONiC.xxx - HwSku: xx - Distribution: Debian 10.13 - Kernel: 4.19.0-12-2-amd64"
    ```
    In case of IPv4, the SRC IP in SNMP response was correctly set to Loopback IP.
    ```
    23:25:32.769712  In 22:26:27:e6:e0:07 ethertype IPv4 (0x0800), length 85: 10.0.0.57.56701 > **10.1.0.32**.161:  C="msft" **GetRequest**(28)  .1.3.6.1.2.1.1.1.0
    23:25:32.975967 Out 28:99:3a:a0:97:30 ethertype IPv4 (0x0800), length 221: **10.1.0.32**.161 > 10.0.0.57.56701:  C="msft" **GetResponse**(162)  .1.3.6.1.2.1.1.1.0="SONiC Software Version: SONiC.xxx - HwSku: xx - Distribution: Debian 10.13 - Kernel: 4.19.0-12-2-amd64"
    ```
    
    **Sequence of SNMP request and response**
    1. SNMP request will be sent with SRC IP fc00::72 DST IP fc00:1::32
    2. SNMP request is received at SONiC device is sent to snmpd which is listening on port 161 :::161/
    3. snmpd process will parse the request create a response and sent to DST IP fc00::72. 
    snmpd process does not track the DST IP on which the SNMP request was received, which in this case is Loopback IP.
    snmpd process will only keep track what is tht IP to which the response should be sent to.
    4. snmpd process will send the response packet.
    5. Kernel will do a route look up on destination IP and find the best path.
    ip -6 route get fc00::72
    fc00::72 from :: dev PortChannel101 proto kernel src fc00::71 metric 256 pref medium
    5. Using the "src" ip from about, the response is sent out. This SRC ip is that of the PortChannel and not the device Loopback IP.
    
    The same issue is seen when SNMP query is sent from a remote server over Management IP.
    SONiC device eth0 --------- Remote server
    SNMP request comes with SRC IP <Remote_server> DST IP <Mgmt IP>
    If kernel finds best route to Remote_server_IP is via BGP neighbors, then it will send the response via front-panel interface with SRC IP as Loopback IP instead of Management IP.
    
    Main issue is that in case of IPv6, snmpd ignores the IP address to which SNMP request was sent, in case of IPv6.
    In case of IPv4, snmpd keeps track of DST IP of SNMP request, it will keep track if the SNMP request was sent to mgmt IP or Loopback IP.
    Later, this IP is used in ipi_spec_dst as SRC IP which helps kernel to find the route based on DST IP using the right SRC IP.
    https://github.com/net-snmp/net-snmp/blob/master/snmplib/transports/snmpUDPBaseDomain.c#L300 
    ipi.ipi_spec_dst.s_addr = srcip->s_addr
    Reference: https://man7.org/linux/man-pages/man7/ip.7.html
    ```
    If IP_PKTINFO is passed to sendmsg(2)
                  and ipi_spec_dst is not zero, then it is used as the local
                  source address for the routing table lookup and for
                  setting up IP source route options.  When ipi_ifindex is
                  not zero, the primary local address of the interface
                  specified by the index overwrites ipi_spec_dst for the
                  routing table lookup.
    ```
    
    **This issue is not seen on multi-asic platform, why?**
    on multi-asic platform, there exists different network namespaces.
    SNMP docker with snmpd process runs on host namespace.
    Management interface belongs to host namespace.
    Loopback0 is configured on asic namespaces.
    Additional inforamtion on how the packet coming over Loopback IP reaches snmpd process running on host namespace: sonic-net#5420
    Because of this separation of network namespaces, the route lookup of destination IP is confined to routing table of specific namespace where packet is received.
    if packet is received over management interface, SNMP response also is sent out of management interface. Same goes with packet received over Loopback Ip.
    
    ##### Work item tracking
    - Microsoft ADO **17537063**:
    
    #### How I did it
    Have snmpd listen on specific Management and Loopback IPs specifically instead of listening on any IP for single-asic platform.
    
    Before Fix
    ```
    admin@xx:~$ sudo netstat -tulnp | grep 161   
    udp        0      0 0.0.0.0:161             0.0.0.0:*                           15631/snmpd         
    udp6       0      0 :::161                  :::*                                15631/snmpd  
    ```
    After fix
    ```
    admin@device:~$ sudo netstat -tulnp | grep 161
    udp        0      0 10.1.0.32:161           0.0.0.0:*                           215899/snmpd        
    udp        0      0 10.3.1.1:161             0.0.0.0:*                           215899/snmpd        
    udp6       0      0 fc00:1::32:161          :::*                                215899/snmpd        
    udp6       0      0 fc00:2::32:161          :::*                                215899/snmpd  
    ``` 
    
    **How this change helps with the issue?**
    To see snmpd trace logs, modify snmpd to start using the below parameters, in supervisord.conf file
    ```
    /usr/sbin/snmpd -f -LS0-7i -Lf /var/log/snmpd.log
    ```
    When snmpd listens on any IP, snmpd binds to IPv4 and IPv6 sockets as below:
    ```
    netsnmp_udpbase: binding socket: 7 to UDP: [0.0.0.0]:0->[0.0.0.0]:161
    trace: netsnmp_udp6_transport_bind(): transports/snmpUDPIPv6Domain.c, 303:
    netsnmp_udpbase: binding socket: 8 to UDP/IPv6: [::]:161
    ```
    
    When IPv4 response is sent, it goes out of fd 7 and IPv6 response goes out of fd 8.
    When IPv6 response is sent, it does not have the right SRC IP and it can lead to the issue described.
    
    When snmpd listens on specific Loopback/Management IPs, snmpd binds to different sockets:
    ```
    trace: netsnmp_udpipv4base_transport_bind(): transports/snmpUDPIPv4BaseDomain.c, 207:
    netsnmp_udpbase: binding socket: 7 to UDP: [0.0.0.0]:0->[10.250.0.101]:161
    trace: netsnmp_udpipv4base_transport_bind(): transports/snmpUDPIPv4BaseDomain.c, 207:
    netsnmp_udpbase: binding socket: 8 to UDP: [0.0.0.0]:0->[10.1.0.32]:161
    trace: netsnmp_register_agent_nsap(): snmp_agent.c, 1261:
    netsnmp_register_agent_nsap: fd 8
    netsnmp_udpbase: binding socket: 10 to UDP/IPv6: [fc00:1::32]:161
    trace: netsnmp_register_agent_nsap(): snmp_agent.c, 1261:
    netsnmp_register_agent_nsap: fd 10
    netsnmp_ipv6: fmtaddr: t = (nil), data = 0x7fffed4c85d0, len = 28
    trace: netsnmp_udp6_transport_bind(): transports/snmpUDPIPv6Domain.c, 303:
    netsnmp_udpbase: binding socket: 9 to UDP/IPv6: [fc00:2::32]:161
    ```
    When SNMP request comes in via Loopback IPv4, SNMP response is sent out of fd 8
    ```
    trace: netsnmp_udpbase_send(): transports/snmpUDPBaseDomain.c, 511:
    netsnmp_udp: send 170 bytes from 0x5581f2fbe30a to UDP: [10.0.0.33]:46089->[10.1.0.32]:161 on fd 8
    ```
    When SNMP request comes in via Loopback IPv6, SNMP response is sent out of fd 10
    ```
    netsnmp_ipv6: fmtaddr: t = (nil), data = 0x5581f2fc2ff0, len = 28
    trace: netsnmp_udp6_send(): transports/snmpUDPIPv6Domain.c, 164:
    netsnmp_udp6: send 170 bytes from 0x5581f2fbe30a to UDP/IPv6: [fc00::42]:43750 on fd 10
    ```
    
    #### How to verify it
    Verified on single asic and multi-asic devices.
    Single asic SNMP query with Loopback 
    ```
    ARISTA01T1#bash snmpget -v2c -c xxx 10.1.0.32 1.3.6.1.2.1.1.1.0
    SNMPv2-MIB::sysDescr.0 = STRING: SONiC Software Version: SONiC.xx - HwSku: Arista-7260xx - Distribution: Debian 10.13 - Kernel: 4.19.0-12-2-amd64
    ARISTA01T1#bash snmpget -v2c -c xxx fc00:1::32 1.3.6.1.2.1.1.1.0
    SNMPv2-MIB::sysDescr.0 = STRING: SONiC Software Version: SONiC.xx - HwSku: Arista-7260xxx - Distribution: Debian 10.13 - Kernel: 4.19.0-12-2-amd64
    ```
    
    On multi-asic -- no change.
    ```
    sudo netstat -tulnp | grep 161
    udp        0      0 0.0.0.0:161             0.0.0.0:*                           17978/snmpd         
    udp6       0      0 :::161                  :::*                                17978/snmpd 
    ```
    Query result using Loopback IP from a directly connected BGP neighbor
    ```
    ARISTA01T2#bash snmpget -v2c -c xxx 10.1.0.32 1.3.6.1.2.1.1.1.0
    SNMPv2-MIB::sysDescr.0 = STRING: SONiC Software Version: SONiC.xx - HwSku: xx - Distribution: Debian 9.13 - Kernel: 4.9.0-14-2-amd64
    ARISTA01T2#bash snmpget -v2c -c xxx fc00:1::32 1.3.6.1.2.1.1.1.0
    SNMPv2-MIB::sysDescr.0 = STRING: SONiC Software Version: SONiC.xx - HwSku: xx - Distribution: Debian 9.13 - Kernel: 4.9.0-14-2-amd64  
    ```
    <!--
    If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
    -->
    SuvarnaMeenakshi authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9864dfe View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. [Build] Fix the python module importlib.metadata not found issue (son…

    …ic-net#15800)
    
    Why I did it
    It is to fix the docker-ptf-sai build failure.
    https://dev.azure.com/mssonic/build/_build/results?buildId=311315&view=logs&j=cef3d8a9-152e-5193-620b-567dc18af272&t=cf595088-5c84-5cf1-9d7e-03331f31d795
    
    2023-07-09T13:53:19.9025355Z �[91mTraceback (most recent call last):
    2023-07-09T13:53:19.9025715Z   File "/root/ptf/.eggs/setuptools_scm-7.1.0-py3.7.egg/setuptools_scm/_entrypoints.py", line 74, in <module>
    2023-07-09T13:53:19.9025933Z     from importlib.metadata import entry_points  # type: ignore
    2023-07-09T13:53:19.9026167Z ModuleNotFoundError: No module named 'importlib.metadata'
    Work item tracking
    Microsoft ADO (number only): 24513583
    How I did it
    How to verify it
    xumia authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    dc5258e View commit details
    Browse the repository at this point in the history
  2. [submodule] Update submodule sonic-swss to the latest HEAD automatica…

    …lly (sonic-net#15811)
    
    #### Why I did it
    src/sonic-swss
    ```
    * c7e1308e - (HEAD -> master, origin/master, origin/HEAD) Remove redundant updateFabricPortState (sonic-net#2850) (2 hours ago) [kenneth-arista]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    25defcf View commit details
    Browse the repository at this point in the history
  3. [submodule] Update submodule sonic-platform-daemons to the latest HEA…

    …D automatically (sonic-net#15810)
    
    #### Why I did it
    src/sonic-platform-daemons
    ```
    * d73808c - (HEAD -> master, origin/master, origin/HEAD) Added PCIe transaction check for all peripherals on the bus (sonic-net#331) (9 hours ago) [Ashwin Srinivasan]
    * 432602a - Update active application selected code in transceiver_info table aft… (sonic-net#381) (13 hours ago) [Michael Wang - TW]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    b3e5910 View commit details
    Browse the repository at this point in the history
  4. [Build] Change the build option from ENABLE_FIPS_FEATURE to INCLUDE_F…

    …IPS (sonic-net#15758)
    
    Why I did it
    [Build] Change the build option from ENABLE_FIPS_FEATURE to INCLUDE_FIPS
    
    Work item tracking
    Microsoft ADO (number only): 24485797
    How I did it
    xumia authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    30959ec View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. limit privileged flag for bgp container (sonic-net#14932)

    Why I did it
    HLD implementation: Container Hardening (sonic-net/SONiC#1364)
    
    Work item tracking
    Microsoft ADO (number only): 14807420
    How I did it
    Reduce linux capabilities in privileged flag, retain NET_ADMIN and SYS_ADMIN capabilities
    
    How to verify it
    Install new image to DUT, verify bgp container is up
    Run bgp sonic-mgmt kvmtest
    maipbui authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d549787 View commit details
    Browse the repository at this point in the history
  2. [k8s]: Bypass the systemd service restart limit and do immediately re…

    …start when change to local mode (sonic-net#15432)
    
    Why I did it
    During the upgrade process via k8s, the feature's systemd service will restart as well, all of the feature systemd service has restart number limit, and the limit number is too small, only three times. if fallback happens when upgrade, the start count will be 2, just once again, the systemd service will be down. So, need to bypass this. This restart function will be called when do local -> kube, kube -> kube, kube ->local, each time call this function, we indeed need to restart successfully, so do reset-failed every time we do restart.
    When need to go back to local mode, we do systemd restart immediately without waiting the default restart interval time so that we can reduce the container down time.
    
    Work item tracking
    Microsoft ADO (number only):
    24172368
    
    How I did it
    Before every restart for upgrade, do reset feature's restart number. The restart number will be reset to 0 to bypass the restart limit.
    When need to go back to local mode, we do systemd restart immediately.
    
    How to verify it
    Feature's systemd service can be always restarted successfully during upgrade process via k8s.
    lixiaoyuner authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    df13380 View commit details
    Browse the repository at this point in the history
  3. [ctrmgr]: Container image clean up bug fix (sonic-net#15772)

    Why I did it
    When do clean up container images, current code has two bugs need to be fixed. And some variables' name maybe cause confused, change the variables' name.
    
    Work item tracking
    Microsoft ADO (number only): 24502294
    
    How I did it
    We do clean up after tag latest successfully. But currently tag latest function only return 0 and 1, 0 means succeed and 1 means failed, when we get 1, we will retry, when we get 0, we will do clean up. Actually the code 0 includes another case we don't need to do clean up. The case is that when we are doing tag latest, the container image we want to tag maybe not running, so we can not tag latest and don't need to cleanup, we need to separate this case from 0, return -1 now.
    
    When local mode(v1) -> kube mode(v2) happens, one problem is how to handle the local image, there are two cases. one case is that there was one kube v1 container dry-run(cause we don't relace the local if kube version = local version), we will remove the kube v1 image and tag the local version with ACR prefix and remove local v1 local tag. Another case is that there was no kube v1 container dry-run, we remove the local v1 image directly, cause the local v1 image should not be the last desire version.
    
    About the docker_id variable, it may cause confused, it's actually docker image id, so rename the variable. About the two dicts and the list, rename them to be more readable.
    
    How to verify it
    Check tag latest and image clean up result.
    lixiaoyuner authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    1bf2a61 View commit details
    Browse the repository at this point in the history
  4. update rsyslog log size conf (sonic-net#15821)

    Why I did it
    For some devices whose log folder size is larger than 200M, for example, 256M, the LOG_FILE_ROTATE_SIZE_KB should be 16M. and
    THRESHOLD_KB=$((USABLE_SPACE_KB - (NUM_LOGS_TO_ROTATE * LOG_FILE_ROTATE_SIZE_KB * 2)))
    = $(( (VAR_LOG_SIZE_KB * 90 / 100) - RESERVED_SPACE_KB)) - (NUM_LOGS_TO_ROTATE * LOG_FILE_ROTATE_SIZE_KB * 2)))
    = $(( (256M * 90 / 100) - 4096)) - (8 * 16M * 2)))
    the result would be a negative value
    
    Work item tracking
    Microsoft ADO (number only):
    24524827
    How I did it
    Add a case for 400M, if the log folder size is between 200M and 400M, set the log file size to 2M
    
    How to verify it
    Do cmd "sudo logrotate -f /etc/logrotate.conf" on DUT which val/log folder size is 256M, and check the syslog.
    lipxu authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    95d1197 View commit details
    Browse the repository at this point in the history
  5. [submodule] Update submodule sonic-utilities to the latest HEAD autom…

    …atically (sonic-net#15812)
    
    #### Why I did it
    src/sonic-utilities
    ```
    * 51c7a43c - (HEAD -> master, origin/master, origin/HEAD) [show][muxcable] update `show mux config` to print out `soc_ipv6` as well  (sonic-net#2909) (6 hours ago) [Jing Zhang]
    * fd497755 - [route_check][dualtor] Ignore vlan neighbor route miss (sonic-net#2888) (18 hours ago) [Longxiang Lyu]
    * 81c0ed4e - [show][muxcable] update `show mux tunnel-route` to check soc_ipv6 as well (33 hours ago) [Jing Zhang]
    * 1ee73668 - [db_migrator] Migrate DNS configuratuion (sonic-net#2893) (2 days ago) [ganglv]
    * 553a3432 - [dualtor][route_check] filter out `soc_ipv6`  (sonic-net#2899) (2 days ago) [Jing Zhang]
    ```
    #### How I did it
    #### How to verify it
    #### Description for the changelog
    mssonicbld authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    23a0a87 View commit details
    Browse the repository at this point in the history
  6. Upgrade scapy in the PTF's python3 virtualenv to 2.5.0 (sonic-net#15573)

    This is primarily to fix a bug in scapy hitting an error when trying to
    listen on multiple interfaces in a single `sniff` call. This also
    upgrades it to the current latest version.
    
    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    saiarcot895 authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    c991c5f View commit details
    Browse the repository at this point in the history
  7. Potential fix for Celestica E1031 device hang (sonic-net#15822)

    set CPU max_cstate to 0
    
    Co-authored-by: Sumukha Tumkur Vani <sumukhatv@outlook.com>
    yxieca and sumukhatv authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    bf49154 View commit details
    Browse the repository at this point in the history
  8. [ctgmgr]: do not remove label when do systemd service stop when servi…

    …ce is in kube mode (sonic-net#15642)
    
    Why I did it
    When sonic is managed by k8s, the sonic container is managed by k8s daemonset, daemonset identifies its members by labels. Currently when restarting a sonic service by systemctl, if the service's container is already managed by k8s, systemd script stops the container by removing the feature label to make it disjoin from k8s daemonset, and then starts it by adding the label to make it join k8s daemonset again.
    
    This behavior would cause problem during k8s container upgrade. Containers in daemonset are upgraded in a rolling fashion, that means the daemonset version is updated first, then rollout the new version to containers with precheck/postcheck one by one. However, if a sonic device joins a daemonset, k8s will directly deploy a pod with the current version of daemonset, it is expected when a device joins k8s cluster at first time.
    
    But for a device which has already joined k8s cluster, the re-joining daemonset will cause the container upgraded to new version without precheck, so if a systemd service is restarted during daemonset upgrade, the container may be upgraded without precheck and break rolling update policy. To fix it, we need to remove the logic about dropping k8s label in systemd service stop script for kube mode.
    
    Work item tracking
    Microsoft ADO (number only): 24304563
    
    How I did it
    Don't drop label in systemd service stop script when feature's set_owner is kube. Only drop label when feature's set_owner is local.
    
    How to verify it
    The label feature_enabled should be always true if the feature's set owner is kube.
    lixiaoyuner authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    2602ad2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    94c47c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Configuration menu
    Copy the full SHA
    109830b View commit details
    Browse the repository at this point in the history